ide: remove "paranoia" checks for hwgroup->busy

PATCH In review Bartlomiej Zolnierkiewicz 1 participant 1 message Nov 18, 2008 libata

Share & tools

Bartlomiej Zolnierkiewicz

author

2008-11-18 20:22 UTC #0 lore raw

PATCH 1/3 ide: remove "paranoia" checks for hwgroup->busy

Remove "paranoia" checks for hwgroup->busy from ide_timer_expiry() and ide_intr(). This is a preparation for future changes.

Cc Michael Schmitz <[email protected]>

Cc Geert Uytterhoeven <[email protected]>

Cc Elias Oltmanns <[email protected]>

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

---
against current pata-2.6 tree (should also apply fine to linux-next)

 drivers/ide/ide-io.c |    9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

drivers/ide/ide-io.c +1 -8

Index: b/drivers/ide/ide-io.c
===================================================================
@@ -1018,10 +1018,7 @@ void ide_timer_expiry (unsigned long dat
 		} else {
 			ide_hwif_t *hwif;
 			ide_startstop_t startstop = ide_stopped;
-			if (!hwgroup->busy) {
-				hwgroup->busy = 1;	/* paranoia */
-				printk(KERN_ERR "%s: ide_timer_expiry: hwgroup->busy was 0 ??\n", drive->name);
-			}
+
 			if ((expiry = hwgroup->expiry) != NULL) {
 				/* continue */
 				if ((wait = expiry(drive)) > 0) {

@@ -1234,10 +1231,6 @@ irqreturn_t ide_intr (int irq, void *dev
 		 */
 		goto out;
 
-	if (!hwgroup->busy) {
-		hwgroup->busy = 1;	/* paranoia */
-		printk(KERN_ERR "%s: ide_intr: hwgroup->busy was 0 ??\n", drive->name);
-	}
 	hwgroup->handler = NULL;
 	hwgroup->req_gen++;
 	del_timer(&hwgroup->timer);