Skip to contentSkip to conversation

USB fixes for 2.6.28-git

PATCH In review Greg KH 3 participants 6 messages Nov 20, 2008 – Nov 25, 2008 1 message not in the archive

lore
Share & tools
lore

Greg KH

author
#0 lore raw

PATCH 1/1 USB fixes for 2.6.28-git

Here are a few USB fixes against your current git tree.

These patches are:
- fix for broken AMD USB controllers
- musb bugfix
- rndis bugfix to keep Windows from blue-screening
- new device ids
- usb-storage quirks

Please pull from:

	master.kernel.org:/pub/scm/linux/kernel/git/gregkh/usb-2.6.git/

All of these patches have been in the -next and -mm tree for a few releases.

The full patches will be sent to the linux-usb mailing list, if anyone wants to see them.

thanks,

greg k-h

------------------

 drivers/usb/gadget/f_rndis.c       |    3 +--
 drivers/usb/host/ehci-pci.c        |   21 +++++++++++++++++++++
 drivers/usb/mon/mon_bin.c          |    5 ++++-
 drivers/usb/musb/musb_host.c       |    2 +-
 drivers/usb/serial/cp2101.c        |    1 +
 drivers/usb/storage/unusual_devs.h |   11 +++++++++--
 6 files changed, 37 insertions(+), 6 deletions(-)

---------------

Alan Stern (2):
USB: storage: updates unusual_devs entry for the Nokia 6300
USB: storage: update unusual_devs entries for Nokia 5300 and 5310

Andiry Xu (1):
USB: fix SB700 usb subsystem hang bug

David Brownell (1):
USB: gadget rndis: stop windows self-immolation

Felipe Balbi (1):
usb: musb: fix bug in musb_schedule

M Kondrin (1):

      USB: ACE1001 patch for cp2101.c

Pete Zaitcev (1):
USB: usbmon: fix read(2)

Richard Röjfors (1):
USB: gadget rndis: send notifications

#1 lore raw
Quoted 3 lines · Greg KH

Please pull from:

	master.kernel.org:/pub/scm/linux/kernel/git/gregkh/usb-2.6.git/

"Already up-to-date".

I think you forgot to actually push them out.

Linus

author
#2 lore raw
Quoted 10 lines · Linus Torvalds
Quoted 3 lines · Greg KH

Please pull from:

	master.kernel.org:/pub/scm/linux/kernel/git/gregkh/usb-2.6.git/

"Already up-to-date".

I think you forgot to actually push them out.

Crap, you're right, they are now there, sorry about that.

greg k-h

#3 lore raw
Quoted 5 lines · Greg KH
Quoted 4 lines · Linus Torvalds
Quoted 1 line · Greg KH
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

Please pull from:

	master.kernel.org:/pub/scm/linux/kernel/git/gregkh/usb-2.6.git/

"Already up-to-date".

I think you forgot to actually push them out.

Crap, you're right, they are now there, sorry about that.

I've been wondering if git can do something to avoid things like this.

For example, if you push into a particular branch of a particular repository _only_ to ask Linus to pull and for no other purpose, one possible solution may be to trigger a hook on the receiving end of your push (i.e. the public repository Linus is asked to pull from) to send out the "Please pull from" message (I presume this would be a no-go as there is not much room for you to customize the message).

Alternatively, we may want to give an option to git-request-pull to actually run "git push" to the destination.

Thoughts? Is it "none of Git's business"?

author
#4 lore raw
Quoted 27 lines · Junio C Hamano
Quoted 5 lines · Greg KH
Quoted 4 lines · Linus Torvalds
Quoted 1 line · Greg KH
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

Please pull from:

	master.kernel.org:/pub/scm/linux/kernel/git/gregkh/usb-2.6.git/

"Already up-to-date".

I think you forgot to actually push them out.

Crap, you're right, they are now there, sorry about that.

I've been wondering if git can do something to avoid things like this.

For example, if you push into a particular branch of a particular repository _only_ to ask Linus to pull and for no other purpose, one possible solution may be to trigger a hook on the receiving end of your push (i.e. the public repository Linus is asked to pull from) to send out the "Please pull from" message (I presume this would be a no-go as there is not much room for you to customize the message).

Quoted 4 lines

Alternatively, we may want to give an option to git-request-pull to actually run "git push" to the destination.

Thoughts? Is it "none of Git's business"?

In this case, it was just my fault. I just forgot to push the tree. I have my own scripts that I use to create my "please pull" message, that don't really tie into git's infrastructure and I don't know if I would want them to either.

thanks,

greg k-h

A message that is not in the archive (sent off-list or not yet received): 20081125042051.GA17345__32159.7253824168$1227588787$gmane$org@suse.de

#6 lore raw
Quoted 10 lines · Greg KH
Quoted 9 lines · Junio C Hamano
Quoted 6 lines · Greg KH
Quoted 4 lines · Linus Torvalds

...
"Already up-to-date".

I think you forgot to actually push them out.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Crap, you're right, they are now there, sorry about that.

I've been wondering if git can do something to avoid things like this.
...

In this case, it was just my fault. I just forgot to push the tree. I have my own scripts that I use to create my "please pull" message, that don't really tie into git's infrastructure and I don't know if I would want them to either.

Oh, I wouldn't question that it was ultimately _your_ fault, but:

(1) I see Linus mention "did you forget to push" every once in a while on this list (e.g. http://tinyurl.com/forgot-to-push); and

(2) You are not the only person who sends "please pull" request and pushes out what needs to be pulled, and forgets to push. Everybody who asks Linus to pull either needs to roll his own scripts. This is wasteful, but this is partly git's fault, and something we could improve, because I do not think there is no usable canned tools that come with git that allows you to prepare a custom "please pull" message and helps you not to forget pushing out; and

(3) As an early adopter who has his own wrappers around git that are tailored to match his own needs in this part of the workflow, you'd be an ideal source of requirements _if_ we would want to provide a usable canned tool for doing this.

Hence my comments.