Skip to contentSkip to conversation

patch hwmon-applesmc-add-support-for-macbook-air.patch added to 2.6.27-stable tree

stable Chuck Ebbert 2 participants 2 messages Nov 21, 2008 – Nov 22, 2008 10 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#10 lore raw
Quoted 43 lines · On Fri, 21 Nov 2008 11:01:42 -0800 Greg KH <[email protected]> wrote:
Quoted 42 lines · Jean Delvare
Quoted 41 lines · Henrik Rydberg
Quoted 12 lines · Greg KH
Quoted 11 lines · Henrik Rydberg

Greg KH wrote:
[...]

Quoted 9 lines
Quoted 8 lines
Quoted 5 lines

Heh, ok, then it really doesn't make sense to include any of these in the 2.6.27-stable tree, as it isn't just a simple "add a new device id to a table" type of thing.

Should I drop them all?

Either that, or add all the patches. From this end, with an eye at the Ubuntu user community, none of the patches has caused troubles, but a stable release is a stable release... I say drop them all.

Ok, consider them dropped :)

Quoted 8 lines
Quoted 5 lines

On second thought, why not add all applesmc patches to -stable? I put together a small table, showing what machines work in the stable version and which ones, by testimony, work in either Ubuntu 8.10, which includes all patches but a few trival ones, or in a fully patched dkms version. I have left out machines that have not been fully tested.

Ok, care to send us patches to add all of this to the tree so we can see what this entails?

Absolutely. However, since the commits are all in Linus' tree, cherry-picking sounds like the easiest thing, does it not? Here are the commits to applesmc, in reverse chronological order, since the 2.6.27 release:

468cc0320ed083e26364d9febde2679d981ed6a6 hwmon: applesmc: add support for Macbook 4 eefc488f96cdde6e152b45675b50bf380b95d99f hwmon: applesmc: add support for iMac 8 a66603257bf88bbe2c9fd6a97ee5dc24de15d196 hwmon: applesmc: add support for Macbook Pro 5 181209a1d91756bfd83b1d6ce2008cea3ca225b6 hwmon: applesmc: add support for Macbook 5 6e3530fa241ae759313496f67295c9252691ed04 hwmon: applesmc: add support for iMac 5 8c9398d1e9766e3659e277acb2e8ca1c17684139 hwmon: applesmc: lighter wait mechanism, drastic improvement 07e8dbd3ebbdedc71335049dd4b0d542cb038d7d hwmon: applesmc: Add support for Macbook Pro 3 d7549905f157f217b888edb0f2055f5090eaf1d8 hwmon: applesmc: Add support for Macbook Pro 4 7b5e3cb28f52f42d8cf2b36771be580f33bbc7ae drivers/hwmon/applesmc.c: remove unneeded casts f5274c972bac2d14c092a9c634e03f51785c7b76 hwmon: applesmc: add support for Macbook Air 8bd1a12a51871f0c870612d8220b1485d6aefc73 hwmon: applesmc: allow for variable ALV0 and ALV1 package length 02fcbd144d684167aa67b1d3ad68f18d265f2d08 hwmon: applesmc: prolong status wait 84d2d7f2ee98dc9bd799790c89b5eb8280af2d37 hwmon: applesmc: fix the 'wait status failed: c != 8' problem 05224091af06177c0ce7c1fae1f498455b47a6be hwmon: applesmc: specified number of bytes to read should match actual

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

The non-trivial ones are 8c9398, 8bd1a1 and 84d2d7.

This is too much for -stable IMHO.

In looking at the non-trivial ones, I agree, it's not just a "simple" addition, sorry.

OTOH the driver is basically broken without all those patches.

#11 lore raw
Quoted 24 lines · Chuck Ebbert
Quoted 21 lines · On Fri, 21 Nov 2008 11:01:42 -0800 Greg KH <[email protected]> wrote:
Quoted 20 lines · Jean Delvare
Quoted 19 lines · Henrik Rydberg

Absolutely. However, since the commits are all in Linus' tree, cherry-picking sounds like the easiest thing, does it not? Here are the commits to applesmc, in reverse chronological order, since the 2.6.27 release:

468cc0320ed083e26364d9febde2679d981ed6a6 hwmon: applesmc: add support for Macbook 4 eefc488f96cdde6e152b45675b50bf380b95d99f hwmon: applesmc: add support for iMac 8 a66603257bf88bbe2c9fd6a97ee5dc24de15d196 hwmon: applesmc: add support for Macbook Pro 5 181209a1d91756bfd83b1d6ce2008cea3ca225b6 hwmon: applesmc: add support for Macbook 5 6e3530fa241ae759313496f67295c9252691ed04 hwmon: applesmc: add support for iMac 5 8c9398d1e9766e3659e277acb2e8ca1c17684139 hwmon: applesmc: lighter wait mechanism, drastic improvement 07e8dbd3ebbdedc71335049dd4b0d542cb038d7d hwmon: applesmc: Add support for Macbook Pro 3 d7549905f157f217b888edb0f2055f5090eaf1d8 hwmon: applesmc: Add support for Macbook Pro 4 7b5e3cb28f52f42d8cf2b36771be580f33bbc7ae drivers/hwmon/applesmc.c: remove unneeded casts f5274c972bac2d14c092a9c634e03f51785c7b76 hwmon: applesmc: add support for Macbook Air 8bd1a12a51871f0c870612d8220b1485d6aefc73 hwmon: applesmc: allow for variable ALV0 and ALV1 package length 02fcbd144d684167aa67b1d3ad68f18d265f2d08 hwmon: applesmc: prolong status wait 84d2d7f2ee98dc9bd799790c89b5eb8280af2d37 hwmon: applesmc: fix the 'wait status failed: c != 8' problem 05224091af06177c0ce7c1fae1f498455b47a6be hwmon: applesmc: specified number of bytes to read should match actual

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

The non-trivial ones are 8c9398, 8bd1a1 and 84d2d7.

This is too much for -stable IMHO.

In looking at the non-trivial ones, I agree, it's not just a "simple" addition, sorry.

OTOH the driver is basically broken without all those patches.

Feel free to send a single patch disabling the driver altogether in -stable if this is really the case.

Signature · 1 line
Jean Delvare