Skip to contentSkip to conversation

cpumask: sparc: Introduce cpumask_of_{node,pcibus} to replace {node,pcibus}_to_cpumask

PATCH In review Rusty Russell 2 participants 2 messages Nov 21, 2008 SPARC + UltraSPARC (sparc/sparc64)

lore
Share & tools
lore

Rusty Russell

author
#0 lore raw

PATCH 7/8 cpumask: sparc: Introduce cpumask_of_{node,pcibus} to replace {node,pcibus}_to_cpumask

Impact: New APIs

The old node_to_cpumask/node_to_pcibus returned a cpumask_t: these return a pointer to a struct cpumask. Part of removing cpumasks from the stack.

Signed-off-by Rusty Russell <[email protected]>
Cc David S. Miller <[email protected]>
---
 arch/sparc/include/asm/topology_64.h |   10 ++++++----
 arch/sparc64/kernel/of_device.c      |    2 +-
 arch/sparc64/kernel/pci_msi.c        |    2 +-
 3 files changed, 8 insertions(+), 6 deletions(-)
arch/sparc/include/asm/topology_64.h +6 -4
@@ -16,8 +16,12 @@ static inline cpumask_t node_to_cpumask(
 {
 	return numa_cpumask_lookup_table[node];
 }
+#define cpumask_of_node(node) (&numa_cpumask_lookup_table[node])
 
-/* Returns a pointer to the cpumask of CPUs on Node 'node'. */
+/*
+ * Returns a pointer to the cpumask of CPUs on Node 'node'.
+ * Deprecated: use "const struct cpumask *mask = cpumask_of_node(node)"
+ */
 #define node_to_cpumask_ptr(v, node)		\
 		cpumask_t *v = &(numa_cpumask_lookup_table[node])
 

@@ -26,9 +30,7 @@ static inline cpumask_t node_to_cpumask(
 
 static inline int node_to_first_cpu(int node)
 {
-	cpumask_t tmp;
-	tmp = node_to_cpumask(node);
-	return first_cpu(tmp);
+	return cpumask_first(cpumask_of_node(node));
 }
 
 struct pci_bus;
arch/sparc64/kernel/of_device.c +1 -1
@@ -778,7 +778,7 @@ static unsigned int __init build_one_dev
 out:
 	nid = of_node_to_nid(dp);
 	if (nid != -1) {
-		cpumask_t numa_mask = node_to_cpumask(nid);
+		cpumask_t numa_mask = *cpumask_of_node(nid);
 
 		irq_set_affinity(irq, numa_mask);
 	}
arch/sparc64/kernel/pci_msi.c +1 -1
@@ -286,7 +286,7 @@ static int bringup_one_msi_queue(struct 
 
 	nid = pbm->numa_node;
 	if (nid != -1) {
-		cpumask_t numa_mask = node_to_cpumask(nid);
+		cpumask_t numa_mask = *cpumask_of_node(nid);
 
 		irq_set_affinity(irq, numa_mask);
 	}