w35und: fix Kconfig
4KSTACK dependency was needed when driver carried its own softmac layer. That layer is gone, and functions have reasonably small stack footprint -> dependency can be removed.
Add better description of hardware this driver is targetted at.
drivers/staging/winbond/Kconfig +8 -4
@@ -1,7 +1,11 @@ config W35UND - tristate "Winbond driver" - depends on MAC80211 && WLAN_80211 && USB && EXPERIMENTAL && !4KSTACKS + tristate "IS89C35 WLAN USB driver" + depends on MAC80211 && WLAN_80211 && USB && EXPERIMENTAL default n ---help--- - This is highly experimental driver for winbond wifi card on some Kohjinsha notebooks - Check http://code.google.com/p/winbondport/ for new version + This is highly experimental driver for Winbond WIFI card. + + HW is present in some Kohjinsha subnotebooks, and in some + stand-alone USB modules. Chipset name seems to be w89c35d. + + Check http://code.google.com/p/winbondport/ for new version.
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Pekka Enberg
Acked-byQuoted 7 lines · Pavel Machek
4KSTACK dependency was needed when driver carried its own softmac layer. That layer is gone, and functions have reasonably small stack footprint -> dependency can be removed.
Add better description of hardware this driver is targetted at.
Signed-off-by Pavel Machek <[email protected]>
While I don't have the hardware to test this, I haven't seen anything in the driver code either that abuses the kernel stack too badly.
Quoted 20 lines
drivers/staging/winbond/Kconfig +8
-4@@ -1,7 +1,11 @@ config W35UND - tristate "Winbond driver" - depends on MAC80211 && WLAN_80211 && USB && EXPERIMENTAL && !4KSTACKS + tristate "IS89C35 WLAN USB driver" + depends on MAC80211 && WLAN_80211 && USB && EXPERIMENTAL default n ---help--- - This is highly experimental driver for winbond wifi card on some Kohjinsha notebooks - Check http://code.google.com/p/winbondport/ for new version + This is highly experimental driver for Winbond WIFI card. + + HW is present in some Kohjinsha subnotebooks, and in some + stand-alone USB modules. Chipset name seems to be w89c35d. + + Check http://code.google.com/p/winbondport/ for new version.
Quoted 13 lines · Pavel Machek
4KSTACK dependency was needed when driver carried its own softmac layer. That layer is gone, and functions have reasonably small stack footprint -> dependency can be removed.
Add better description of hardware this driver is targetted at.
Signed-off-by Pavel Machek <[email protected]>drivers/staging/winbond/Kconfig +0
-1@@ -1,7 +1,11 @@ config W35UND - tristate "Winbond driver"
drivers/staging/winbond/Kconfig line 8
Quoted 10 lines
drivers/staging/winbond/Kconfig +5
-3- depends on MAC80211 && WLAN_80211 && USB && EXPERIMENTAL && !4KSTACKS + tristate "IS89C35 WLAN USB driver" + depends on MAC80211 && WLAN_80211 && USB && EXPERIMENTAL default n ---help--- - This is highly experimental driver for winbond wifi card on some Kohjinsha notebooks - Check http://code.google.com/p/winbondport/ for new version + This is highly experimental driver for Winbond WIFI card. + + HW is present in some Kohjinsha subnotebooks, and in some
Please spell out "Hardware".
And check for whitespace at ends of lines.
Quoted 3 lines
drivers/staging/winbond/Kconfig +3
-0+ stand-alone USB modules. Chipset name seems to be w89c35d. + + Check http://code.google.com/p/winbondport/ for new version.
Signature · 1 line
~Randy
Pavel Machek
Acked-by Pekka Enberg4KSTACK dependency was needed when driver carried its own softmac layer. That layer is gone, and functions have reasonably small stack footprint -> dependency can be removed.
Add better description of hardware this driver is targetted at (now with fixed whitespace)
drivers/staging/winbond/Kconfig +8 -4
@@ -1,7 +1,11 @@ config W35UND - tristate "Winbond driver" - depends on MAC80211 && WLAN_80211 && USB && EXPERIMENTAL && !4KSTACKS + tristate "IS89C35 WLAN USB driver" + depends on MAC80211 && WLAN_80211 && USB && EXPERIMENTAL default n ---help--- - This is highly experimental driver for winbond wifi card on some Kohjinsha notebooks - Check http://code.google.com/p/winbondport/ for new version + This is highly experimental driver for Winbond WIFI card. + + Hardware is present in some Kohjinsha subnotebooks, and in some + stand-alone USB modules. Chipset name seems to be w89c35d. + + Check http://code.google.com/p/winbondport/ for new version.
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 7 lines · Pavel Machek
4KSTACK dependency was needed when driver carried its own softmac layer. That layer is gone, and functions have reasonably small stack footprint -> dependency can be removed.
Add better description of hardware this driver is targetted at (now with fixed whitespace)
My scripts automatically strip off trailing whitespace (well, quilt does), so this wasn't that necessary. But I've now replaced the version of this patch in my tree with your new one.
thanks,
greg k-h