Skip to contentSkip to conversation

ethtool: Make possible speeds known

PATCH New Rick Jones 1 participant 1 message Nov 25, 2008

Subsystems (2)
lore
Share & tools
lore

Rick Jones

author
#0 lore raw

PATCH 1/1 ethtool: Make possible speeds known

Certain Broadcom 10Gb Ethernet solutions (e.g. the 57711E) can have a 10Gb port split into multiple virtual NICs each with an instance of the bnx2x driver. These virtual NICs can be configured for any speed which is an integer multiple of 100 Mb/s from 100 to 10,000 Mbit/s inclusive. Since this is "normal" for such systems an "Unknown!" is not indicated.

---

Rather than make a wholesale change to the existing "speed vetting" code, it seemed least invasive to escape-out to a new routine in the default case. Should other "unfamiliar" speeds surface in the future the checks can be put there.

Where the original would say this:

	Speed: Unknown! (1600)

for a FlexNIC link set to 1600 Mbit/s the changed version will say:

	Speed: 1600Mb/s

There is presently no way to alter this speed setting from within the host, so there is no need/point to altering the ethtool "set" path.

ethtool.c renamed from ethtool.c.orig +9 -1
@@ -806,6 +806,14 @@ static void dump_advertised(struct ethto
 		fprintf(stdout, "No\n");
 }
 
+static void vet_unfamiliar_speed(struct ethtool_cmd *ep)
+{
+	if ((!ep->speed) || (ep->speed % 100))
+		fprintf(stdout, "Unknown! (%i)\n", ep->speed);
+	else
+		fprintf(stdout,"%dMb/s\n",ep->speed); 
+}
+
 static int dump_ecmd(struct ethtool_cmd *ep)
 {
 	dump_supported(ep);
@@ -829,7 +837,7 @@ static int dump_ecmd(struct ethtool_cmd 
 		fprintf(stdout, "10000Mb/s\n");
 		break;
 	default:
-		fprintf(stdout, "Unknown! (%i)\n", ep->speed);
+		vet_unfamiliar_speed(ep);
 		break;
 	};