Skip to contentSkip to conversation

i2c-parport: Fix misplaced parport_release call

PATCH New Jean Delvare 1 participant 1 message Nov 25, 2008

Subsystems (2)
I2C subsystem host drivers I2C over parallel port
lore
Share & tools
lore

Jean Delvare

author
#0 lore raw

PATCH 1/1 i2c-parport: Fix misplaced parport_release call

We shouldn't release the parallel port until we are actually done with it.

Signed-off-by Jean Delvare <[email protected]>
---
 drivers/i2c/busses/i2c-parport.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/busses/i2c-parport.c +2 -2
@@ -189,8 +189,6 @@ static void i2c_parport_attach (struct p
 	if (adapter_parm[type].init.val)
 		line_set(port, 1, &adapter_parm[type].init);
 
-	parport_release(adapter->pdev);
-
 	if (i2c_bit_add_bus(&adapter->adapter) < 0) {
 		printk(KERN_ERR "i2c-parport: Unable to register with I2C\n");
 		goto ERROR1;

@@ -202,6 +200,7 @@ static void i2c_parport_attach (struct p
         return;
 
 ERROR1:
+	parport_release(adapter->pdev);
 	parport_unregister_device(adapter->pdev);
 ERROR0:
 	kfree(adapter);

@@ -221,6 +220,7 @@ static void i2c_parport_detach (struct p
 			if (adapter_parm[type].init.val)
 				line_set(port, 0, &adapter_parm[type].init);
 				
+			parport_release(adapter->pdev);
 			parport_unregister_device(adapter->pdev);
 			if (prev)
 				prev->next = adapter->next;
Signature · 1 line
Jean Delvare