Skip to contentSkip to conversation

Update for constraint fix

PATCH In review Steven Rostedt 2 participants 3 messages Nov 25, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Update for constraint fix

Ingo and Stephen,

Please use this patch instead. Uros Bizjak suggested using 'q' over 'Q'.

The following patches are in:

git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git

branch: urgent

Steven Rostedt (1):
use limited register constraint for setnz

----

 arch/x86/boot/tty.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
#1 lore raw

PATCH 1/1 use limited register constraint for setnz

From: Steven Rostedt <[email protected]>

Impact: fix in compiling

GCC can decide to use %dil when "r" is used, which is not valid for setnz.

This bug was brought out by Stephen Rothwell's merging of the branch tracer into linux-next.

[ Thanks to Uros Bizjak for recommending 'q' over 'Q' ]

---
 arch/x86/boot/tty.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/boot/tty.c +1 -1
index 0be77b3..7e8e8b2 100644
@@ -74,7 +74,7 @@ static int kbd_pending(void)
 {
 	u8 pending;
 	asm volatile("int $0x16; setnz %0"
-		     : "=rm" (pending)
+		     : "=qm" (pending)
 		     : "a" (0x0100));
 	return pending;
 }
Signature · 3 lines
1.5.6.5

-- 
#2 lore raw
In reply to Steven Rostedt
Quoted 8 lines · Steven Rostedt

Ingo and Stephen,

Please use this patch instead. Uros Bizjak suggested using 'q' over 'Q'.

The following patches are in:

git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git

applied and pushed out into x86-next, thanks Steve!

Ingo