Skip to contentSkip to conversation

x86: uv bau interrupt -- use proper interrupt number

PATCH Applied Cyrill Gorcunov 3 participants 3 messages Nov 26, 2008 – Nov 28, 2008 x86

lore
Share & tools
lore

Cyrill Gorcunov

author
#0 lore raw

PATCH 1/1 x86: uv bau interrupt -- use proper interrupt number

Signed-off-by Cyrill Gorcunov <[email protected]>
CC Andi Kleen <[email protected]>
---
 arch/x86/kernel/entry_64.S |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/entry_64.S +1 -1
Index: linux-2.6.git/arch/x86/kernel/entry_64.S
===================================================================
@@ -945,7 +945,7 @@ apicinterrupt IRQ_MOVE_CLEANUP_VECTOR \
 	irq_move_cleanup_interrupt smp_irq_move_cleanup_interrupt
 #endif
 
-apicinterrupt 220 \
+apicinterrupt UV_BAU_MESSAGE \
 	uv_bau_message_intr1 uv_bau_message_interrupt
 apicinterrupt LOCAL_TIMER_VECTOR \
 	apic_timer_interrupt smp_apic_timer_interrupt
#1 lore raw
Quoted 11 lines · Cyrill Gorcunov
Signed-off-by Cyrill Gorcunov <[email protected]>
CC Andi Kleen <[email protected]>
---
 arch/x86/kernel/entry_64.S |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.git/arch/x86/kernel/entry_64.S
===================================================================

arch/x86/kernel/entry_64.S apicinterrupt IRQ_MOVE_CLEANUP_VECTOR \

Quoted 9 lines
arch/x86/kernel/entry_64.S +1 -2
@@ -945,7 +945,7 @@ apicinterrupt IRQ_MOVE_CLEANUP_VECTOR \
 	irq_move_cleanup_interrupt smp_irq_move_cleanup_interrupt
 #endif
 
-apicinterrupt 220 \
+apicinterrupt UV_BAU_MESSAGE \
 	uv_bau_message_intr1 uv_bau_message_interrupt
 apicinterrupt LOCAL_TIMER_VECTOR \
 	apic_timer_interrupt smp_apic_timer_interrupt
--

The interrupt handler does not use the hardcoded 220, but the declaration should indeed be fixed as above.
(such a fix was once submitted
http://marc.info/?l=linux-kernel&m=122350309029050&w=2 but didn't go anywhere)
Thanks for the follow-up.

-Cliff

Signature · 4 lines
Cliff Wickman
Silicon Graphics, Inc.
[email protected]
(651) 683-3824
Applied
#2 lore raw
Quoted 15 lines · Cliff Wickman
Quoted 14 lines · Cyrill Gorcunov
Signed-off-by Cyrill Gorcunov <[email protected]>
CC Andi Kleen <[email protected]>
---
 arch/x86/kernel/entry_64.S |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.git/arch/x86/kernel/entry_64.S
===================================================================

arch/x86/kernel/entry_64.S +0 -0
@@ -945,7 +945,7 @@ apicinterrupt IRQ_MOVE_CLEANUP_VECTOR \
 	irq_move_cleanup_interrupt smp_irq_move_cleanup_interrupt
 #endif
Quoted 13 lines

arch/x86/kernel/entry_64.S apicinterrupt IRQ_MOVE_CLEANUP_VECTOR \

Quoted 6 lines
arch/x86/kernel/entry_64.S +1 -2
-apicinterrupt 220 \
+apicinterrupt UV_BAU_MESSAGE \
 	uv_bau_message_intr1 uv_bau_message_interrupt
 apicinterrupt LOCAL_TIMER_VECTOR \
 	apic_timer_interrupt smp_apic_timer_interrupt
--

The interrupt handler does not use the hardcoded 220, but the declaration should indeed be fixed as above.
(such a fix was once submitted
http://marc.info/?l=linux-kernel&m=122350309029050&w=2 but didn't go anywhere)
Thanks for the follow-up.

applied to tip/x86/irq, thanks guys!

Ingo