Skip to contentSkip to conversation

move drivers/i2c/chips/twl4030-usb.c

PATCH In review David Brownell 2 participants 3 messages Dec 1, 2008 – Dec 2, 2008 USB

lore
Share & tools
lore
#0 lore raw

PATCH 5/5 move drivers/i2c/chips/twl4030-usb.c

From: David Brownell <[email protected]>

Move one more OMAP-specific driver out of the drivers/i2c/chips directory ... in this case, a driver that's not yet upstream, but is verging on being mainline-ready once it moves.

---
 drivers/i2c/chips/Kconfig       |    4 
 drivers/i2c/chips/Makefile      |    1 
 drivers/i2c/chips/twl4030-usb.c |  721 --------------------------------------
 drivers/usb/otg/Kconfig         |   10 
 drivers/usb/otg/Makefile        |    1 
 drivers/usb/otg/twl4030-usb.c   |  721 ++++++++++++++++++++++++++++++++++++++
 6 files changed, 732 insertions(+), 726 deletions(-)
drivers/i2c/chips/Kconfig +0 -4
@@ -155,10 +155,6 @@ config TWL4030_MADC
 	  to build it as a dinamically loadable module. The module will be
 	  called twl4030-madc.ko
 
-config TWL4030_USB
-	tristate "TWL4030 USB Transceiver Driver"
-	depends on TWL4030_CORE
-
 config TWL4030_PWRBUTTON
 	tristate "TWL4030 Power button Driver"
 	depends on TWL4030_CORE
drivers/i2c/chips/Makefile +0 -1
@@ -23,7 +23,6 @@ obj-$(CONFIG_SENSORS_TLV320AIC23) += tlv
 obj-$(CONFIG_MENELAUS)		+= menelaus.o
 obj-$(CONFIG_SENSORS_TSL2550)	+= tsl2550.o
 obj-$(CONFIG_MCU_MPC8349EMITX)	+= mcu_mpc8349emitx.o
-obj-$(CONFIG_TWL4030_USB)	+= twl4030-usb.o
 obj-$(CONFIG_TWL4030_POWEROFF)	+= twl4030-poweroff.o
 obj-$(CONFIG_TWL4030_PWRBUTTON)	+= twl4030-pwrbutton.o
 obj-$(CONFIG_TWL4030_MADC)	+= twl4030-madc.o
drivers/i2c/chips/twl4030-usb.c deleted +0 -721

721 lines not on this page · raw message

drivers/usb/otg/Kconfig +10 -0
@@ -41,4 +41,14 @@ config ISP1301_OMAP
 	  This driver can also be built as a module.  If so, the module
 	  will be called isp1301_omap.
 
+config TWL4030_USB
+	tristate "TWL4030 USB Transceiver Driver"
+	depends on TWL4030_CORE
+	select USB_OTG_UTILS
+	help
+	  Enable this to support the USB OTG transceiver on TWL4030
+	  family chips (including the TWL5030 and TPS659x0 devices).
+	  This is transceiver supports high and full speed devices
+	  plus, in host mode, low speed.
+
 endif # USB || OTG
drivers/usb/otg/Makefile +1 -0
@@ -8,6 +8,7 @@ obj-$(CONFIG_USB_OTG_UTILS)	+= otg.o
 # transceiver drivers
 obj-$(CONFIG_USB_GPIO_VBUS)	+= gpio_vbus.o
 obj-$(CONFIG_ISP1301_OMAP)	+= isp1301_omap.o
+obj-$(CONFIG_TWL4030_USB)	+= twl4030-usb.o
 
 ccflags-$(CONFIG_USB_DEBUG)	+= -DDEBUG
 ccflags-$(CONFIG_USB_GADGET_DEBUG) += -DDEBUG
drivers/usb/otg/twl4030-usb.c new file +721 -0

721 lines not on this page · raw message

#1 lore raw

Hi David,

Any plan of moving menelaus.c from i2c/chips directory? I think we can move this driver under regulator framework too.

Signature · 3 lines
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
#2 lore raw
Quoted 2 lines · Trilok Soni

Any plan of moving menelaus.c from i2c/chips directory? I think we can move this driver under regulator framework too.

Whoever makes time to move that, and tps65010.c, to drivers/mfd will earn Official Karma Points. :)

Further updating those drivers to use the regulator framework, and maybe even partitioning them a bit more (rtc-menelaus.c etc) would be a Fine Thing too. But I know that from at least Jean's perspective, just emptying stuff out of i2c/chips is good.

- Dave