Skip to contentSkip to conversation

LSI53C895A: Remove current_dma_len hack

PATCH In review Justin Chevrier 4 participants 4 messages Dec 2, 2008 – Dec 10, 2008

lore
Share & tools
lore

Justin Chevrier

author
#0 lore raw

PATCH 1/2 LSI53C895A: Remove current_dma_len hack

I've sorted out the problem with Openserver that this hack covered up. As such this hack can be removed. It currently is causing boot problems with Debian ARM and Windows XP SP3.

Changelog:

Remove current_dma_len update hack

Signed-off-by Justin Chevrier <address@hidden>
lsi53c895a.c (working copy) renamed from lsi53c895a.c (revision 5852) +0 -1
@@ -920,7 +920,6 @@
             break;
         case PHASE_DI:
             s->waiting = 2;
-            s->current_dma_len = s->dbc;
             lsi_do_dma(s, 0);
             if (s->waiting)
                 s->waiting = 3;
Acked-by on v1 1/2
#1 lore raw
Quoted 7 lines · Justin Chevrier

I've sorted out the problem with Openserver that this hack covered up. As such this hack can be removed. It currently is causing boot problems with Debian ARM and Windows XP SP3.

Changelog:

Remove current_dma_len update hack

Signed-off-by Justin Chevrier <address@hidden>
Acked-by Ryan Harper <[email protected]>
Quoted 16 lines
lsi53c895a.c (working copy) renamed from lsi53c895a.c (revision 5852) +0 -1
@@ -920,7 +920,6 @@
             break;
         case PHASE_DI:
             s->waiting = 2;
-            s->current_dma_len = s->dbc;
             lsi_do_dma(s, 0);
             if (s->waiting)
                 s->waiting = 3;
Signature · 4 lines
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
[email protected]
#2 lore raw
Quoted 2 lines · * Ryan Harper ([email protected]) wrote:
Quoted 1 line · Justin Chevrier

I've sorted out the problem with Openserver that this hack covered up. As such this hack can be removed. It currently is causing boot problems with Debian ARM and Windows XP SP3.

And x86 Linux as well...

Quoted 7 lines
Quoted 5 lines

Changelog:

Remove current_dma_len update hack

Signed-off-by Justin Chevrier <address@hidden>
Acked-by Ryan Harper <[email protected]>

Ack

Came to the same conclusion last night:

Reverting the single line (essentially the primary purpose of the original change):

        s->current_dma_len = s->dbc;

Is enough to get my Linux guests working again.

lsi_scsi: SCRIPTS dsp=f2002210 opcode 90080000 arg 00000000
lsi_scsi: Return to 0xf20027e8
lsi_scsi: SCRIPTS dsp=f20027e8 opcode 11000000 arg 00000350
-lsi_scsi: DMA addr=0x000000001e0b8000 len=16 +lsi_scsi: DMA addr=0x000000001e0b0000 len=4096

thanks,
-chris

#3 lore raw
In reply to Justin Chevrier
Quoted 8 lines · Justin Chevrier

I've sorted out the problem with Openserver that this hack covered up. As such this hack can be removed. It currently is causing boot problems with Debian ARM and Windows XP SP3.

Changelog:

Remove current_dma_len update hack

Signed-off-by Justin Chevrier <address@hidden>

I'd like to apply this, but <address@hidden> is not a valid email address.

Regards,

Anthony Liguori

Quoted 17 lines
lsi53c895a.c (working copy) renamed from lsi53c895a.c (revision 5852) +0 -1
@@ -920,7 +920,6 @@
             break;
         case PHASE_DI:
             s->waiting = 2;
-            s->current_dma_len = s->dbc;
             lsi_do_dma(s, 0);
             if (s->waiting)
                 s->waiting = 3;