Skip to contentSkip to conversation

fix for tty-serial-move-port

PATCH New Alexander Beregalov 1 participant 1 message Dec 4, 2008 Linux-next tree

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix for tty-serial-move-port

Hi Alan

next-20081204 crashes with the following message:

BUG: unable to handle kernel paging request at ffff88007d320248
IP: [<ffffffff803de934>] uart_remove_one_port+0xef/0x111
                kfree(info);
     393:       49 8d 7d 10             lea    0x10(%r13),%rdi
     397:       e8 00 00 00 00          callq  39c <uart_remove_one_port+0xef>

---

 drivers/serial/serial_core.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
drivers/serial/serial_core.c +1 -3
index e99a269..4fc25e4 100644
@@ -2530,10 +2530,8 @@ int uart_remove_one_port(struct uart_driver *drv, struct uart_port *port)
 	/*
 	 * Kill the tasklet, and free resources.
 	 */
-	if (info) {
+	if (info)
 		tasklet_kill(&info->tlet);
-		kfree(info);
-	}
 
 	state->port = NULL;
 	mutex_unlock(&port_mutex);