pata_sis: Remove bogus cable match
PATCH 1/1 pata_sis: Remove bogus cable match
From: Alan Cox <[email protected]>
Some systems report SIS 5513 as both vendor/id and subvendor/id string. In that case we can't distinguish the system by the id svid/sdid and in fact the entry here breaks some boxes. At some point we need to find another way to detect the Targa Visionary 1000, until then this a hang for some users with lower performance for others.
---
drivers/ata/pata_sis.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/ata/pata_sis.c +0 -1
@@ -56,7 +56,6 @@ static const struct sis_laptop sis_laptop[] = { { 0x5513, 0x1043, 0x1107 }, /* ASUS A6K */ { 0x5513, 0x1734, 0x105F }, /* FSC Amilo A1630 */ { 0x5513, 0x1071, 0x8640 }, /* EasyNote K5305 */ - { 0x5513, 0x1039, 0x5513 }, /* Targa Visionary 1000 *//* end marker */ { 0, } };
Quoted 11 lines · Alan Cox
From: Alan Cox <[email protected]>
Some systems report SIS 5513 as both vendor/id and subvendor/id string. In that case we can't distinguish the system by the id svid/sdid and in fact the entry here breaks some boxes. At some point we need to find another way to detect the Targa Visionary 1000, until then this a hang for some users with lower performance for others.
Closes #12092Signed-off-by Alan Cox <[email protected]>
Should that last sentence be "this SOLVES a hang"?
As it is currently worded, it is unclear what we are trading off with this patch...
Thanks,
Jeff
Quoted 9 lines · On Fri, 05 Dec 2008 15:31:40 -0500 Jeff Garzik <[email protected]> wrote:
Quoted 8 lines · Alan Cox
From: Alan Cox <[email protected]>
Some systems report SIS 5513 as both vendor/id and subvendor/id string. In that case we can't distinguish the system by the id svid/sdid and in fact the entry here breaks some boxes. At some point we need to find another way to detect the Targa Visionary 1000, until then this a hang for some users with lower performance for others.
Quoted 8 lines
Quoted 3 lines
Closes #12092Signed-off-by Alan Cox <[email protected]>Should that last sentence be "this SOLVES a hang"?
As it is currently worded, it is unclear what we are trading off with this patch...
I missed out the word "trades" ...
Am Samstag, 06. Dezember 2008 schrieb Alan Cox:
Quoted 14 lines
On Fri, 05 Dec 2008 15:31:40 -0500
Quoted 11 lines · Jeff Garzik
Quoted 10 lines · Alan Cox
From: Alan Cox <[email protected]>
Some systems report SIS 5513 as both vendor/id and subvendor/id string. In that case we can't distinguish the system by the id svid/sdid and in fact the entry here breaks some boxes. At some point we need to find another way to detect the Targa Visionary 1000, until then this a hang for some users with lower performance for others.
Closes #12092
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Signed-off-by Alan Cox <[email protected]>Should that last sentence be "this SOLVES a hang"?
As it is currently worded, it is unclear what we are trading off with this patch...
I missed out the word "trades" ...
Is there away to bypass this bogus-detection and force the driver into using high-speed mode on the short 40-wire cable? Maybe by introducing a kernel/module parameter? Or is it there? I found nothing in the docs.
Can I provide any information you need to properly detect the Targa Visionary 1000?
Thanks,
Kai
Quoted 6 lines
Is there away to bypass this bogus-detection and force the driver into using high-speed mode on the short 40-wire cable? Maybe by introducing a kernel/module parameter? Or is it there? I found nothing in the docs.
Can I provide any information you need to properly detect the Targa Visionary 1000?
Thats why I cc'd you on the changes. I am sure we can find something to identify this machine.
Can you send the output of dmidecode ?
Alan
Quoted 22 lines · Alan Cox
From: Alan Cox <[email protected]>
Some systems report SIS 5513 as both vendor/id and subvendor/id string. In that case we can't distinguish the system by the id svid/sdid and in fact the entry here breaks some boxes. At some point we need to find another way to detect the Targa Visionary 1000, until then this a hang for some users with lower performance for others.
Closes #12092Signed-off-by Alan Cox <[email protected]>---
drivers/ata/pata_sis.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)drivers/ata/pata_sis.c +0
-0
drivers/ata/pata_sis.c static const struct sis_laptop sis_laptop[] = { · line 59
Quoted 5 lines
drivers/ata/pata_sis.c +0
-1@@ -56,7 +56,6 @@ static const struct sis_laptop sis_laptop[] = { { 0x5513, 0x1043, 0x1107 }, /* ASUS A6K */ { 0x5513, 0x1734, 0x105F }, /* FSC Amilo A1630 */ { 0x5513, 0x1071, 0x8640 }, /* EasyNote K5305 */ - { 0x5513, 0x1039, 0x5513 }, /* Targa Visionary 1000 */ /* end marker */
applied #upstream-fixes