make hello world example work for at91sam9261ek and make readme clearer about this
PATCH 1/1 make hello world example work for at91sam9261ek and make readme clearer about this
An embedded and charset-unspecified text was scrubbed...
Name: make_hello_world_example_work.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20081204/250af59f/attachment.txt
PATCH 1/1 make hello world example work for at91sam9261ek and make readme clearer about this
Quoted 14 lines · Remy Bohmer
This patch fixes the
hello_worldexample to be able to run it on a AT91SAM9261-EK board.Signed-off-by Remy Bohmer <[email protected]>--- README | 4 +++- examples/Makefile | 4 ++++ 2 files changed, 7 insertions(+), 1 deletion(-)Index: u-boot-usb.new/examples/Makefile
===================================================================
examples/Makefile ifeq ($(ARCH),arm) · line 42
Quoted 10 lines
examples/Makefile +4
-0@@ -33,9 +33,13 @@ ifeq ($(ARCH),arm) ifeq ($(BOARD),omap2420h4) LOAD_ADDR = 0x80300000 else +ifeq ($(BOARD),at91sam9261ek) +LOAD_ADDR = 0x21400000 +else LOAD_ADDR = 0xc100000 endif endif +endif
Honestly I'll prefer to remove all arch and board ifdef
and let the board ovewrite it or the arch if the board do not not already define it and do hereLOAD_ADDR ?= <default addr>
Best Regards,
J.
PATCH 1/1 make hello world example work for at91sam9261ek and make readme clearer about this
Hello Jean-Christophe,
Quoted 7 lines
Quoted 7 lines
(quoted diff) +3
-0@@ -33,9 +33,13 @@ ifeq ($(ARCH),arm) ifeq ($(BOARD),omap2420h4) LOAD_ADDR = 0x80300000 else +ifeq ($(BOARD),at91sam9261ek) +LOAD_ADDR = 0x21400000 +else
Quoted 8 lines
Review ifeq ($(ARCH),arm) · line 42
Quoted 4 lines
(quoted diff) +1
-0LOAD_ADDR = 0xc100000 endif endif +endifHonestly I'll prefer to remove all arch and board ifdef
and let the board ovewrite it or the arch if the board do not not already define it and do hereLOAD_ADDR?= <default addr>
I completely agree about this.
This was just a minor patch I had on the stack for months and yesterday I just put them all out.
The most important part of this patch was the comment about the load-addr in the readme file.
Frequently questions misunderstandings about the examples appear on the ML, and the readme change would help there.
I can look into it later on to improve it and find a more generic solution. In the mean time, I do not think this patch hurts anyone ;-)
Remy
Quoted 4 lines
Best Regards,
J.
PATCH 1/1 make hello world example work for at91sam9261ek and make readme clearer about this
Quoted 26 lines · Remy Bohmer
Hello Jean-Christophe,
Quoted 7 lines
Quoted 7 lines
(quoted diff) +3
-0@@ -33,9 +33,13 @@ ifeq ($(ARCH),arm) ifeq ($(BOARD),omap2420h4) LOAD_ADDR = 0x80300000 else +ifeq ($(BOARD),at91sam9261ek) +LOAD_ADDR = 0x21400000 +elseQuoted 8 lines
Review ifeq ($(ARCH),arm) · line 42
Quoted 4 lines
(quoted diff) +1
-0LOAD_ADDR = 0xc100000 endif endif +endifHonestly I'll prefer to remove all arch and board ifdef
and let the board ovewrite it or the arch if the board do not not already define it and do hereLOAD_ADDR?= <default addr>I completely agree about this.
This was just a minor patch I had on the stack for months and yesterday I just put them all out.
The most important part of this patch was the comment about the load-addr in the readme file.
Frequently questions misunderstandings about the examples appear on the ML, and the readme change would help there.
Quoted 2 lines
I can look into it later on to improve it and find a more generic solution. In the mean time, I do not think this patch hurts anyone ;-)
I'll prefer to wait because I've other patch in queued that will do the samethink
Best Regards,
J.
PATCH 1/1 make hello world example work for at91sam9261ek and make readme clearer about this
In reply to Remy BohmerDear "Remy Bohmer",
Quoted 7 lines · In message <[email protected]> you…
This was just a minor patch I had on the stack for months and yesterday I just put them all out.
The most important part of this patch was the comment about the load-addr in the readme file.
Frequently questions misunderstandings about the examples appear on the ML, and the readme change would help there.
We should take greater care than to really make this right - you probably want to copy & paste from the FAQ.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Everyting looks interesting until you do it. Then you find it's just another job. - Terry Pratchett, _Moving Pictures_
PATCH 1/1 make hello world example work for at91sam9261ek and make readme clearer about this
In reply to Remy BohmerDear Remy Bohmer,
Review
Quoted 8 lines · In message <[email protected]> you wrote:
'
examples/hello_world.c' contains a small "Hello World" Demo application; it is automatically compiled when you build U-Boot.(quoted diff) +3
-1-It's configured to run at address 0x00040004, so you can play with it +The address it will run on is determined by the LOAD_ADDR for +your board in examples/Makefile. +If it's configured to run at address 0x00040004, you can play with it like that:
Um... the new text is as misleading as the old one was. LOAD_ADDR obviously plays a role for the entry point address, abut it's not a 1:1 relation. Probablky nobody would set LOAD_ADDR to 0x00040004 ...
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The universe, they said, depended for its operation on the balance of four forces which they identified as charm, persuasion, uncertainty and bloody-mindedness. -- Terry Pratchett, "The Light Fantastic"