alsa-utils fix for intl support
PATCH 1/1 alsa-utils fix for intl support
Hi,
Feel free to comment on the included patch. I had to add it because aseqnet would not link without -lintl.
Signature · 2 lines
Best regards, Hans-Christian Egtvedt
seq/aseqnet/Makefile.in +1 -1
@@ -252,7 +252,7 @@ clean-binPROGRAMS: -test -z "$(bin_PROGRAMS)" || rm -f $(bin_PROGRAMS) aseqnet$(EXEEXT): $(aseqnet_OBJECTS) $(aseqnet_DEPENDENCIES) @rm -f aseqnet$(EXEEXT) - $(LINK) $(aseqnet_LDFLAGS) $(aseqnet_OBJECTS) $(aseqnet_LDADD) $(LIBS) + $(LINK) $(aseqnet_LDFLAGS) $(aseqnet_OBJECTS) $(aseqnet_LDADD) $(LIBS) $(INTLLIBS) mostlyclean-compile: -rm -f *.$(OBJEXT)
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
At Thu, 4 Dec 2008 15:29:47 +0100,
Quoted 5 lines · Hans-Christian Egtvedt
Hi,
Feel free to comment on the included patch. I had to add it because aseqnet would not link without -lintl.
Patching Makefile.in doesn't make any sense.
Does the patch below work instead?
thanks,
Takashi
seq/aseqnet/Makefile.am +1 -0
@@ -3,4 +3,5 @@ EXTRA_DIST = README.aseqnet aseqnet.1 bin_PROGRAMS = aseqnet aseqnet_SOURCES = aseqnet.c +LIBADD = $(INTLLIBS) man_MANS = aseqnet.1
Quoted 10 lines · On Mon, 08 Dec 2008 08:32:42 +0100 Takashi Iwai <[email protected]> wrote:
At Thu, 4 Dec 2008 15:29:47 +0100,
Quoted 5 lines · Hans-Christian Egtvedt
Hi,
Feel free to comment on the included patch. I had to add it because aseqnet would not link without -lintl.
Patching Makefile.in doesn't make any sense.
I have quite low fu with autoconf, but sure Makefile.in does not need a patch as well? There are no users of LIBADD in seq/aseqnet/Makefile.in.
Quoted 2 lines
Does the patch below work instead?
Nope, still not able to find libintl.
What is the correct way of testing this? From a fresh 1.0.18 source I changed seq/aseqnet/Makefile.am and then ran autoreconf before ./configure + make. Should I have used more/other autotools?
<snipp Makefile.am patch>
Signature · 2 lines
Best regards, Hans-Christian Egtvedt
At Mon, 8 Dec 2008 10:29:05 +0100,
Quoted 9 lines · Hans-Christian Egtvedt
Quoted 5 lines · On Mon, 08 Dec 2008 08:32:42 +0100 Takashi Iwai <[email protected]> wrote:
At Thu, 4 Dec 2008 15:29:47 +0100,
Quoted 3 lines · Hans-Christian Egtvedt
Hi,
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Feel free to comment on the included patch. I had to add it because aseqnet would not link without -lintl.
Patching Makefile.in doesn't make any sense.
I have quite low fu with autoconf, but sure Makefile.in does not need a patch as well? There are no users of LIBADD in seq/aseqnet/Makefile.in.
No, Makefile.in is created by Makefile.am.
Quoted 4 lines
Quoted 2 lines
Does the patch below work instead?
Nope, still not able to find libintl.
Then something other is missing.
Quoted 3 lines
What is the correct way of testing this? From a fresh 1.0.18 source I changed seq/aseqnet/Makefile.am and then ran autoreconf before ./configure + make. Should I have used more/other autotools?
No, it should work. Even without autoreconf, configure itself should check the change of Makefile.am.
Takashi
At Mon, 08 Dec 2008 10:42:24 +0100,
Quoted 21 lines · I wrote:
At Mon, 8 Dec 2008 10:29:05 +0100,
Quoted 9 lines · Hans-Christian Egtvedt
Quoted 5 lines · On Mon, 08 Dec 2008 08:32:42 +0100 Takashi Iwai <[email protected]> wrote:
At Thu, 4 Dec 2008 15:29:47 +0100,
Quoted 3 lines · Hans-Christian Egtvedt
Hi,
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Feel free to comment on the included patch. I had to add it because aseqnet would not link without -lintl.
Patching Makefile.in doesn't make any sense.
I have quite low fu with autoconf, but sure Makefile.in does not need a patch as well? There are no users of LIBADD in seq/aseqnet/Makefile.in.
Quoted 8 lines
No, Makefile.in is created by Makefile.am.
Quoted 4 lines
Quoted 2 lines
Does the patch below work instead?
Nope, still not able to find libintl.
Then something other is missing.
It was a typo. Must be LDADD, not LIBADD.
Fixed on git now.
thanks,
Takashi
Quoted 3 lines · On Mon, 08 Dec 2008 12:01:15 +0100 Takashi Iwai <[email protected]> wrote:
At Mon, 08 Dec 2008 10:42:24 +0100,
Quoted 1 line · I wrote:
<snipp>
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Nope, still not able to find libintl.
Then something other is missing.
It was a typo. Must be LDADD, not LIBADD.
Fixed on git now.
Ah, great, then I can understand that it will work :)
Just tested an updated patch (with LDADD instead of LIBADD), and it works fine on my system.
Thanks for your help on my two patches.
Signature · 2 lines
Best regards, Hans-Christian Egtvedt