Skip to contentSkip to conversation

parisc: remove gratuitous cpu_online_map declaration.

PATCH In review Rusty Russell 4 participants 5 messages Dec 3, 2008 – Dec 9, 2008 PA-RISC architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 parisc: remove gratuitous cpu_online_map declaration.

This is defined in linux/cpumask.h (included in this file already), and this will break when the definition changes (in a following patch).

---
 arch/parisc/include/asm/smp.h |    2 --
 1 file changed, 2 deletions(-)
arch/parisc/include/asm/smp.h +0 -2
@@ -15,8 +15,6 @@
 #include <linux/threads.h>	/* for NR_CPUS */
 #include <linux/cpumask.h>
 typedef unsigned long address_t;
-
-extern cpumask_t cpu_online_map;
 
 
 /*
#1 lore raw
Quoted 4 lines · Rusty Russell

This is defined in linux/cpumask.h (included in this file already), and this will break when the definition changes (in a following patch).

Accepted, though it would have been nice if it had either hit all the maintainers, or hit the list too...

cheers, Kyle

Quoted 24 lines
---
 arch/parisc/include/asm/smp.h |    2 --
 1 file changed, 2 deletions(-)
arch/parisc/include/asm/smp.h +0 -3
@@ -15,8 +15,6 @@
 #include <linux/threads.h>	/* for NR_CPUS */
 #include <linux/cpumask.h>
 typedef unsigned long address_t;
-
-extern cpumask_t cpu_online_map;
 
 
 /*
 
 
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw
Quoted 8 lines · On Tuesday 09 December 2008 14:24:07 Kyle McMartin wrote:
Quoted 4 lines · Rusty Russell

This is defined in linux/cpumask.h (included in this file already), and this will break when the definition changes (in a following patch).

Accepted, though it would have been nice if it had either hit all the maintainers, or hit the list too...

OK, I picked one maintainer at semi-random. I've added you and Willy
to my annoy-maintainers script.

Thanks,
Rusty.

#3 lore raw
Quoted 5 lines · Rusty Russell
Quoted 4 lines · On Tuesday 09 December 2008 14:24:07 Kyle McMartin wrote:
Quoted 3 lines · Rusty Russell

This is defined in linux/cpumask.h (included in this file already), and this will break when the definition changes (in a following patch).

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Accepted, though it would have been nice if it had either hit all the maintainers, or hit the list too...

OK, I picked one maintainer at semi-random. I've added you and Willy
to my annoy-maintainers script.

Rusty,
willy and I should be dropped as parisc-linux maintainers. (We can review parisc patches, just not listed as maintainers.)

Please add Helge Deller <[email protected]> (IIRC).

Patch to MAINTAINERS was submitted just a week ago or so.

cheers,
grant

Quoted 7 lines

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#4 lore raw
Quoted 9 lines · Grant Grundler
Quoted 8 lines · Rusty Russell
Quoted 7 lines · On Tuesday 09 December 2008 14:24:07 Kyle McMartin wrote:
Quoted 4 lines · Rusty Russell

This is defined in linux/cpumask.h (included in this file already), and this will break when the definition changes (in a following patch).

Accepted, though it would have been nice if it had either hit all the maintainers, or hit the list too...

Quoted 8 lines
Quoted 2 lines

OK, I picked one maintainer at semi-random. I've added you and Willy
to my annoy-maintainers script.

Rusty,
willy and I should be dropped as parisc-linux maintainers. (We can review parisc patches, just not listed as maintainers.)

Please add Helge Deller <[email protected]> (IIRC).

Rusty,

Please use: Helge Deller <[email protected]>

Thanks,
Helge