Skip to contentSkip to conversation

hwmon: (k8temp) warn about erratum #141

PATCH In review Andreas Herrmann 2 participants 3 messages Dec 5, 2008 – Dec 10, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 3/4 hwmon: (k8temp) warn about erratum #141

---
 drivers/hwmon/k8temp.c |   15 +++++++--------
 1 files changed, 7 insertions(+), 8 deletions(-)
drivers/hwmon/k8temp.c +7 -8
index 894a929..102f3ad 100644
@@ -167,15 +167,14 @@ static int __devinit k8temp_probe(struct pci_dev *pdev,
 			goto exit;
 		}
 
-		dev_warn(&pdev->dev, "Temperature readouts might be wrong"
-			 " - check erratum #141\n");
-
-		/*
-		 * AMD NPT familys 0fh, i.e. RevF and RevG:
-		 * meaning of SEL_CORE bit is inverted
-		 */
-		if (model >= 0x40)
+		/* AMD NPT familys 0fh, i.e. RevF and RevG */
+		if (model >= 0x40) {
+			/* meaning of SEL_CORE bit is inverted */
 			data->swap_core_select = 1;
+			dev_warn(&pdev->dev, "Temperature readouts might be "
+				 "wrong - check erratum #141\n");
+		}
+
 
 		break;
 	}
Signature · 9 lines
1.6.0.4




_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
maintainer
#1 lore raw

Re: [lm-sensors] [PATCH 3/4] hwmon: (k8temp) warn about erratum

Hello again,

This is OK lets merge it with 2/4 it belongs there.

Rudolf

Andreas Herrmann napsal(a):

Quoted 22 lines
---
 drivers/hwmon/k8temp.c |   15 +++++++--------
 1 files changed, 7 insertions(+), 8 deletions(-)
drivers/hwmon/k8temp.c +1 -8
index 894a929..102f3ad 100644
@@ -167,15 +167,14 @@ static int __devinit k8temp_probe(struct pci_dev *pdev,
 			goto exit;
 		}
 
-		dev_warn(&pdev->dev, "Temperature readouts might be wrong"
-			 " - check erratum #141\n");
-
-		/*
-		 * AMD NPT familys 0fh, i.e. RevF and RevG:
-		 * meaning of SEL_CORE bit is inverted
-		 */
-		if (model >= 0x40)
+		/* AMD NPT familys 0fh, i.e. RevF and RevG */

drivers/hwmon/k8temp.c static int __devinit k8temp_probe(struct pci_dev *pdev, · line 180

Quoted 10 lines
drivers/hwmon/k8temp.c +6 -0
+		if (model >= 0x40) {
+			/* meaning of SEL_CORE bit is inverted */
 			data->swap_core_select = 1;
+			dev_warn(&pdev->dev, "Temperature readouts might be "
+				 "wrong - check erratum #141\n");
+		}
+
 
 		break;
 	}

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors