CPCI405 doesn't build anymore

U-Boot Superseded Stefan Roese 2 participants 4 messages Dec 9, 2008 – Dec 10, 2008 Kbuild

Share & tools

Stefan Roese

author

2008-12-09 16:12 UTC #0 lore raw

Hi Matthias,

the CPCI405 U-Boot Image doesn't build anymore. Most likely too big (again). Could you please submit a patch to fix this?

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

Matthias Fuchs

2008-12-10 12:29 UTC #1 lore raw

PATCH 1/1 ppc4xx: Update TEXT_BASE for CPCI405 boards

This patch fixes building U-Boot for CPCI405 boards.

Signed-off-by Matthias Fuchs <[email protected]>

---
 Makefile                    |    5 +----
 board/esd/cpci405/config.mk |    6 +-----
 include/configs/CPCI405.h   |    4 ++--
 3 files changed, 4 insertions(+), 11 deletions(-)

Makefile +1 -4

index f8fe29c..2f07657 100644
@@ -1261,14 +1261,11 @@ CMS700_config:	unconfig
 CPCI2DP_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc ppc4xx cpci2dp esd
 
-CPCI405_config:		unconfig
-	@$(MKCONFIG) $(@:_config=) ppc ppc4xx cpci405 esd
-
+CPCI405_config		\
 CPCI4052_config		\
 CPCI405DT_config	\
 CPCI405AB_config:	unconfig
 	@mkdir -p $(obj)board/esd/cpci405
-	@echo "TEXT_BASE = 0xFFFC0000" > $(obj)board/esd/cpci405/config.tmp
 	@$(MKCONFIG) $(@:_config=) ppc ppc4xx cpci405 esd
 
 CPCIISER4_config:	unconfig

board/esd/cpci405/config.mk +1 -5

index 6cfb891..1bdf5e4 100644
@@ -21,8 +21,4 @@
 # MA 02111-1307 USA
 #
 
-sinclude $(OBJTREE)/board/$(BOARDDIR)/config.tmp
-
-ifndef TEXT_BASE
-TEXT_BASE = 0xFFFD0000
-endif
+TEXT_BASE = 0xFFFC0000

include/configs/CPCI405.h +2 -2

index 1a2bc1c..eb90620 100644
@@ -196,9 +196,9 @@
  * Please note that CONFIG_SYS_SDRAM_BASE _must_ start at 0
  */
 #define CONFIG_SYS_SDRAM_BASE		0x00000000
-#define CONFIG_SYS_FLASH_BASE		0xFFFD0000
+#define CONFIG_SYS_FLASH_BASE		0xFFFC0000
 #define CONFIG_SYS_MONITOR_BASE	CONFIG_SYS_FLASH_BASE
-#define CONFIG_SYS_MONITOR_LEN		(192 * 1024)	/* Reserve 196 kB for Monitor	*/
+#define CONFIG_SYS_MONITOR_LEN		(256 * 1024)	/* Reserve 196 kB for Monitor	*/
 #define CONFIG_SYS_MALLOC_LEN		(128 * 1024)	/* Reserve 128 kB for malloc()	*/
 
 /*

Signature · 1 line

1.5.3

Stefan Roese

author

2008-12-10 13:04 UTC #2 lore raw

PATCH 1/1 ppc4xx: Update TEXT_BASE for CPCI405 boards

Hi Matthias,

Quoted 1 line · Matthias Fuchs

This patch fixes building U-Boot for CPCI405 boards.

I have a small improvement suggestion below:

Quoted 46 lines

Signed-off-by Matthias Fuchs <[email protected]>

---
 Makefile                    |    5 +----
 board/esd/cpci405/config.mk |    6 +-----
 include/configs/CPCI405.h   |    4 ++--
 3 files changed, 4 insertions(+), 11 deletions(-)

Makefile +1 -4

index f8fe29c..2f07657 100644
@@ -1261,14 +1261,11 @@ CMS700_config:	unconfig
 CPCI2DP_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc ppc4xx cpci2dp esd
 
-CPCI405_config:		unconfig
-	@$(MKCONFIG) $(@:_config=) ppc ppc4xx cpci405 esd
-
+CPCI405_config		\
 CPCI4052_config		\
 CPCI405DT_config	\
 CPCI405AB_config:	unconfig
 	@mkdir -p $(obj)board/esd/cpci405
-	@echo "TEXT_BASE = 0xFFFC0000" > $(obj)board/esd/cpci405/config.tmp
 	@$(MKCONFIG) $(@:_config=) ppc ppc4xx cpci405 esd
 
 CPCIISER4_config:	unconfig

board/esd/cpci405/config.mk +1 -5

index 6cfb891..1bdf5e4 100644
@@ -21,8 +21,4 @@
 # MA 02111-1307 USA
 #
 
-sinclude $(OBJTREE)/board/$(BOARDDIR)/config.tmp
-
-ifndef TEXT_BASE
-TEXT_BASE = 0xFFFD0000
-endif
+TEXT_BASE = 0xFFFC0000

include/configs/CPCI405.h +0 -0

index 1a2bc1c..eb90620 100644

include/configs/CPCI405.h line 201

Quoted 8 lines

include/configs/CPCI405.h +2 -2

@@ -196,9 +196,9 @@
  * Please note that CONFIG_SYS_SDRAM_BASE _must_ start at 0
  */
 #define CONFIG_SYS_SDRAM_BASE		0x00000000
-#define CONFIG_SYS_FLASH_BASE		0xFFFD0000
+#define CONFIG_SYS_FLASH_BASE		0xFFFC0000
 #define CONFIG_SYS_MONITOR_BASE	CONFIG_SYS_FLASH_BASE
-#define CONFIG_SYS_MONITOR_LEN		(192 * 1024)	/* Reserve 196 kB for Monitor	*/
+#define CONFIG_SYS_MONITOR_LEN		(256 * 1024)	/* Reserve 196 kB for Monitor	*/

How about this:

#define CONFIG_SYS_MONITOR_BASE TEXT_BASE /* Start of U-Boot */
#define CONFIG_SYS_MONITOR_LEN (0xFFFFFFFF - CONFIG_SYS_MONITOR_BASE + 1)

You only need to change TEXT_BASE this way.

Best regards,
Stefan

Matthias Fuchs

2008-12-10 13:41 UTC #3 lore raw

PATCH v2 1/1 ppc4xx: Update TEXT_BASE for CPCI405 boards

This patch fixes building U-Boot for CPCI405 boards.

Signed-off-by Matthias Fuchs <[email protected]>

---
 Makefile                    |    5 +----
 board/esd/cpci405/config.mk |    6 +-----
 include/configs/CPCI405.h   |    6 +++---
 3 files changed, 5 insertions(+), 12 deletions(-)

Makefile +1 -4

index f8fe29c..2f07657 100644
@@ -1261,14 +1261,11 @@ CMS700_config:	unconfig
 CPCI2DP_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc ppc4xx cpci2dp esd
 
-CPCI405_config:		unconfig
-	@$(MKCONFIG) $(@:_config=) ppc ppc4xx cpci405 esd
-
+CPCI405_config		\
 CPCI4052_config		\
 CPCI405DT_config	\
 CPCI405AB_config:	unconfig
 	@mkdir -p $(obj)board/esd/cpci405
-	@echo "TEXT_BASE = 0xFFFC0000" > $(obj)board/esd/cpci405/config.tmp
 	@$(MKCONFIG) $(@:_config=) ppc ppc4xx cpci405 esd
 
 CPCIISER4_config:	unconfig

board/esd/cpci405/config.mk +1 -5

index 6cfb891..1bdf5e4 100644
@@ -21,8 +21,4 @@
 # MA 02111-1307 USA
 #
 
-sinclude $(OBJTREE)/board/$(BOARDDIR)/config.tmp
-
-ifndef TEXT_BASE
-TEXT_BASE = 0xFFFD0000
-endif
+TEXT_BASE = 0xFFFC0000

include/configs/CPCI405.h +3 -3

index 1a2bc1c..89ba139 100644
@@ -196,9 +196,9 @@
  * Please note that CONFIG_SYS_SDRAM_BASE _must_ start at 0
  */
 #define CONFIG_SYS_SDRAM_BASE		0x00000000
-#define CONFIG_SYS_FLASH_BASE		0xFFFD0000
-#define CONFIG_SYS_MONITOR_BASE	CONFIG_SYS_FLASH_BASE
-#define CONFIG_SYS_MONITOR_LEN		(192 * 1024)	/* Reserve 196 kB for Monitor	*/
+#define CONFIG_SYS_FLASH_BASE		TEXT_BASE
+#define CONFIG_SYS_MONITOR_BASE		TEXT_BASE
+#define CONFIG_SYS_MONITOR_LEN		(~(TEXT_BASE) + 1)
 #define CONFIG_SYS_MALLOC_LEN		(128 * 1024)	/* Reserve 128 kB for malloc()	*/
 
 /*

Signature · 1 line

1.5.3