Skip to contentSkip to conversation

mISDN: fix sparse warning: symbol 'nskb' shadows an earlier one

PATCH Applied Hannes Eder 2 participants 2 messages Dec 11, 2008 – Dec 13, 2008

Subsystems (3)
Networking Network drivers Kernel janitors
lore
Share & tools
lore

Hannes Eder

author
#0 lore raw

PATCH v2 5/9 mISDN: fix sparse warning: symbol 'nskb' shadows an earlier one

Impact: define first occurence of variable 'nskb' in inner most possible scope

Fix this sparse warning:

drivers/isdn/mISDN/dsp_core.c:746:20: warning: symbol 'nskb' shadows an earlier one drivers/isdn/mISDN/dsp_core.c:634:19: originally declared here

Signed-off-by Hannes Eder <[email protected]>
Acked-by Karsten Keil <[email protected]>
---
 drivers/isdn/mISDN/dsp_core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/isdn/mISDN/dsp_core.c +1 -1
index 41af063..1dc21d8 100644
@@ -631,7 +631,6 @@ dsp_function(struct mISDNchannel *ch,  struct sk_buff *skb)
 	int			ret = 0;
 	u8			*digits;
 	int			cont;
-	struct			sk_buff *nskb;
 	u_long			flags;
 
 	hh = mISDN_HEAD_P(skb);

@@ -690,6 +689,7 @@ dsp_function(struct mISDNchannel *ch,  struct sk_buff *skb)
 			digits = dsp_dtmf_goertzel_decode(dsp, skb->data,
 				skb->len, (dsp_options&DSP_OPT_ULAW)?1:0);
 			while (*digits) {
+				struct sk_buff *nskb;
 				if (dsp_debug & DEBUG_DSP_DTMF)
 					printk(KERN_DEBUG "%s: digit"
 					    "(%c) to layer %s\n",
Signature · 1 line
1.5.6.3
maintainer Applied
#1 lore raw

From: Hannes Eder <[email protected]>
Date: Thu, 11 Dec 2008 22:36:00 +0100

Quoted 9 lines

Impact: define first occurence of variable 'nskb' in inner most possible scope

Fix this sparse warning:

drivers/isdn/mISDN/dsp_core.c:746:20: warning: symbol 'nskb' shadows an earlier one drivers/isdn/mISDN/dsp_core.c:634:19: originally declared here

Signed-off-by Hannes Eder <[email protected]>
Acked-by Karsten Keil <[email protected]>

Applied.