nohz: no softirq pending warnings for offline cpus
PATCH 1/1 nohz: no softirq pending warnings for offline cpus
From: Heiko Carstens <[email protected]>
After a cpu was taken down during cpu hotplug (read: disabled for interrupts) it still might have pending softirqs. However take_cpu_down makes sure that the idle task will run next instead of ksoftirqd on the taken down cpu. The idle task will call tick_nohz_stop_sched_tick which might warn about pending softirqs just before the cpu kills itself completely. However the pending softirqs on the dead cpu aren't a problem because they will be moved to an online cpu during CPU_DEAD handling.
So make sure we warn only for online cpus.
--- kernel/time/tick-sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/time/tick-sched.c +1 -1
@@ -247,7 +247,7 @@ void tick_nohz_stop_sched_tick(int inidlif (need_resched ()) goto end; -if (unlikely (local_softirq_pending ())) { +if (unlikely (local_softirq_pending () &&cpu_online (cpu))) {static int ratelimit;if (ratelimit <10 ) {
Ingo Molnar
AppliedQuoted 10 lines · Heiko Carstens
From: Heiko Carstens <[email protected]>
After a cpu was taken down during cpu hotplug (read: disabled for interrupts) it still might have pending softirqs. However
take_cpu_downmakes sure that the idle task will run next instead of ksoftirqd on the taken down cpu. The idle task will calltick_nohz_stop_sched_tickwhich might warn about pending softirqs just before the cpu kills itself completely. However the pending softirqs on the dead cpu aren't a problem because they will be moved to an online cpu duringCPU_DEADhandling.
Quoted 6 lines
So make sure we warn only for online cpus.
Signed-off-by Heiko Carstens <[email protected]>--- kernel/time/tick-sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
applied to tip/timers/nohz, thanks Heiko!
Ingo