Use float_relation_* constants
PATCH 1/1 Use float_relation_* constants
(Apologies if this patch comes through multiple times; I've tried twice already and haven't seen it come through on my end or in the list archives.)
Use float_relation_* constants rather than magic numbers in softfloat-native comparison routines.
Signed-off-by Nathan Froyd <[email protected]>
--- fpu/softfloat-native.c | 48 ++++++++++++++++++++++++------------------------ 1 files changed, 24 insertions(+), 24 deletions(-)
fpu/softfloat-native.c +24 -24
@@ -220,25 +220,25 @@ float32 float32_sqrt( float32 a STATUS_PARAM) int float32_compare( float32 a, float32 b STATUS_PARAM ) {if (a < b) { -return -1 ; +return float_relation_less; }else if (a == b) { -return 0 ; +return float_relation_equal; }else if (a > b) { -return 1 ; +return float_relation_greater; }else { -return 2 ; +return float_relation_unordered; } } int float32_compare_quiet( float32 a, float32 b STATUS_PARAM ) {if (isless (a, b)) { -return -1 ; +return float_relation_less; }else if (a == b) { -return 0 ; +return float_relation_equal; }else if (isgreater (a, b)) { -return 1 ; +return float_relation_greater; }else { -return 2 ; +return float_relation_unordered; } }int float32_is_signaling_nan (float32 a1)
@@ -391,25 +391,25 @@ float64 float64_sqrt( float64 a STATUS_PARAM) int float64_compare( float64 a, float64 b STATUS_PARAM ) {if (a < b) { -return -1 ; +return float_relation_less; }else if (a == b) { -return 0 ; +return float_relation_equal; }else if (a > b) { -return 1 ; +return float_relation_greater; }else { -return 2 ; +return float_relation_unordered; } } int float64_compare_quiet( float64 a, float64 b STATUS_PARAM ) {if (isless (a, b)) { -return -1 ; +return float_relation_less; }else if (a == b) { -return 0 ; +return float_relation_equal; }else if (isgreater (a, b)) { -return 1 ; +return float_relation_greater; }else { -return 2 ; +return float_relation_unordered; } }int float64_is_signaling_nan (float64 a1)
@@ -483,25 +483,25 @@ floatx80 floatx80_sqrt( floatx80 a STATUS_PARAM) int floatx80_compare( floatx80 a, floatx80 b STATUS_PARAM ) {if (a < b) { -return -1 ; +return float_relation_less; }else if (a == b) { -return 0 ; +return float_relation_equal; }else if (a > b) { -return 1 ; +return float_relation_greater; }else { -return 2 ; +return float_relation_unordered; } } int floatx80_compare_quiet( floatx80 a, floatx80 b STATUS_PARAM ) {if (isless (a, b)) { -return -1 ; +return float_relation_less; }else if (a == b) { -return 0 ; +return float_relation_equal; }else if (isgreater (a, b)) { -return 1 ; +return float_relation_greater; }else { -return 2 ; +return float_relation_unordered; } }int floatx80_is_signaling_nan (floatx80 a1)
Signature · 1 line
1.6.0.5
Aurelien Jarno
AppliedQuoted 8 lines · Nathan Froyd
(Apologies if this patch comes through multiple times; I've tried twice already and haven't seen it come through on my end or in the list archives.)
Use float_relation_* constants rather than magic numbers in softfloat-native comparison routines.
Signed-off-by Nathan Froyd <[email protected]>
Thanks, applied.
Quoted 116 lines
--- fpu/softfloat-native.c | 48 ++++++++++++++++++++++++------------------------ 1 files changed, 24 insertions(+), 24 deletions(-)fpu/softfloat-native.c +24
-24@@ -220,25 +220,25 @@ float32 float32_sqrt( float32 a STATUS_PARAM) int float32_compare( float32 a, float32 b STATUS_PARAM ) {if (a < b) { -return -1 ; +return float_relation_less; }else if (a == b) { -return 0 ; +return float_relation_equal; }else if (a > b) { -return 1 ; +return float_relation_greater; }else { -return 2 ; +return float_relation_unordered; } } int float32_compare_quiet( float32 a, float32 b STATUS_PARAM ) {if (isless (a, b)) { -return -1 ; +return float_relation_less; }else if (a == b) { -return 0 ; +return float_relation_equal; }else if (isgreater (a, b)) { -return 1 ; +return float_relation_greater; }else { -return 2 ; +return float_relation_unordered; } }int float32_is_signaling_nan (float32 a1)@@ -391,25 +391,25 @@ float64 float64_sqrt( float64 a STATUS_PARAM) int float64_compare( float64 a, float64 b STATUS_PARAM ) {if (a < b) { -return -1 ; +return float_relation_less; }else if (a == b) { -return 0 ; +return float_relation_equal; }else if (a > b) { -return 1 ; +return float_relation_greater; }else { -return 2 ; +return float_relation_unordered; } } int float64_compare_quiet( float64 a, float64 b STATUS_PARAM ) {if (isless (a, b)) { -return -1 ; +return float_relation_less; }else if (a == b) { -return 0 ; +return float_relation_equal; }else if (isgreater (a, b)) { -return 1 ; +return float_relation_greater; }else { -return 2 ; +return float_relation_unordered; } }int float64_is_signaling_nan (float64 a1)@@ -483,25 +483,25 @@ floatx80 floatx80_sqrt( floatx80 a STATUS_PARAM) int floatx80_compare( floatx80 a, floatx80 b STATUS_PARAM ) {if (a < b) { -return -1 ; +return float_relation_less; }else if (a == b) { -return 0 ; +return float_relation_equal; }else if (a > b) { -return 1 ; +return float_relation_greater; }else { -return 2 ; +return float_relation_unordered; } } int floatx80_compare_quiet( floatx80 a, floatx80 b STATUS_PARAM ) {if (isless (a, b)) { -return -1 ; +return float_relation_less; }else if (a == b) { -return 0 ; +return float_relation_equal; }else if (isgreater (a, b)) { -return 1 ; +return float_relation_greater; }else { -return 2 ; +return float_relation_unordered; } }int floatx80_is_signaling_nan (floatx80 a1)Signature · 1 line
1.6.0.5
Signature · 4 lines
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73 : :' : Debian developer | Electrical Engineer `. `' [email protected] | [email protected] `- people.debian.org/~aurel32 | www.aurel32.net