isdn: eicon: fix sparse warning: make global functions static
Subsystems (3)
PATCH v2 1/1 isdn: eicon: fix sparse warning: make global functions static
Fix this sparse warnings by making the functions static:
drivers/isdn/hardware/eicon/di.c:356:6: warning: symbol 'isdn_rc' was not declared. Should it be static? drivers/isdn/hardware/eicon/di.c:558:6: warning: symbol 'isdn_ind' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:595:6: warning: symbol 'api_parse' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:634:6: warning: symbol 'api_save_msg' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:666:6: warning: symbol 'api_load_msg' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:3417:6: warning: symbol 'manufacturer_req' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:3745:6: warning: symbol 'manufacturer_res' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:4077:6: warning: symbol 'control_rc' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:4743:6: warning: symbol 'data_rc' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:4779:6: warning: symbol 'data_ack' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:4805:6: warning: symbol 'sig_ind' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:6173:6: warning: symbol 'SendInfo' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:6349:6: warning: symbol 'SendMultiIE' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:6468:6: warning: symbol 'nl_ind' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:7250:6: warning: symbol 'get_plci' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:7409:6: warning: symbol 'add_d' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:7427:6: warning: symbol 'add_ai' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:7448:6: warning: symbol 'add_b1' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:7912:6: warning: symbol 'add_b23' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:8709:6: warning: symbol 'nl_req_ncci' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:8731:6: warning: symbol 'send_req' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:8866:6: warning: symbol 'listen_check' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:8909:6: warning: symbol 'IndParse' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:8994:6: warning: symbol 'ie_compare' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:9003:6: warning: symbol 'find_cip' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:9071:6: warning: symbol 'SetVoiceChannel' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:9089:6: warning: symbol 'VoiceChannelOff' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:9102:6: warning: symbol 'AdvCodecSupport' was not declared. Should it be static? drivers/isdn/hardware/eicon/message.c:9198:6: warning: symbol 'CodecIdCheck' was not declared. Should it be static?
---
The formatting errors and warnings reported by checkpatch.pl have been fixed. Most parts of 'di.c' and 'message.c' do not comply with Documenation/CodingStyle, nevertheless I left it unchanged and make at least this patch comply with the kernel coding style.
drivers/isdn/hardware/eicon/di.c | 28 ++++++++-------- drivers/isdn/hardware/eicon/message.c | 60 ++++++++++++++++++--------------- 2 files changed, 47 insertions(+), 41 deletions(-)
drivers/isdn/hardware/eicon/di.c +14 -14
@@ -353,13 +353,13 @@ void scom_clear_int(ADAPTER * a)/*------------------------------------------------------------------*/ /* return code handler */ /*------------------------------------------------------------------*/ -byte isdn_rc (ADAPTER * a, -byte Rc, -byte Id, -byte Ch, -word Ref, -dword extended_info_type, -dword extended_info) +static byte isdn_rc (ADAPTER *a, +byte Rc, +byte Id, +byte Ch, +word Ref, +dword extended_info_type, +dword extended_info) {ENTITY * this;byte e_no;
@@ -555,13 +555,13 @@ byte isdn_rc(ADAPTER * a,/*------------------------------------------------------------------*/ /* indication handler */ /*------------------------------------------------------------------*/ -byte isdn_ind (ADAPTER * a, -byte Ind, -byte Id, -byte Ch, -PBUFFER * RBuffer, -byte MInd, -word MLength) +static byte isdn_ind (ADAPTER *a, +byte Ind, +byte Id, +byte Ch, +PBUFFER *RBuffer, +byte MInd, +word MLength) {ENTITY * this;word clength;
drivers/isdn/hardware/eicon/message.c +33 -27
222 lines not on this page · raw message
Signature · 1 line
1.5.6.3
David Miller
maintainerFrom: Hannes Eder <[email protected]>
Date: Thu, 11 Dec 2008 17:59:14 +0100
Quoted 1 line
Fix this sparse warnings by making the functions static:
Can you please fix the date on your computer, it should have been Dec 14th or 15th when you posted this :-/
This is screwing up the ordering of patches on patchwork, since it sorts them by date, and that's how I prioritize my work as a result.
Thanks!
From: Hannes Eder <[email protected]>
Date: Thu, 11 Dec 2008 17:59:14 +0100
Quoted 1 line
Fix this sparse warnings by making the functions static:
...
Quoted 1 line
Signed-off-by Hannes Eder <[email protected]>
Applied, thanks Hannes.