Skip to contentSkip to conversation

Pass a valid token to rats_call() in phyp-dump code.

RFC PATCH In review Tony Breeds 4 participants 4 messages Dec 16, 2008 – Dec 17, 2008 PowerPC

lore
Share & tools
lore

Tony Breeds

author
#0 lore raw

RFC PATCH 1/1 Pass a valid token to rats_call() in phyp-dump code.

ibm_configure_kernel_dump, is passed as the token to rtas_call() but I cannot see where it is initialised. Set it to something sane?

Signed-off-by Tony Breeds <[email protected]>
---
 arch/powerpc/platforms/pseries/phyp_dump.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/powerpc/platforms/pseries/phyp_dump.c +2 -0
index 16e659a..6cf35cd 100644
@@ -414,6 +414,8 @@ static int __init phyp_dump_setup(void)
 		of_node_put(rtas);
 	}
 
+	ibm_configure_kernel_dump = rtas_token("ibm,configure-kernel-dump");
+
 	print_dump_header(dump_header);
 	dump_area_length = init_dump_header(&phdr);
 	/* align down */
Signature · 7 lines
1.6.0.4


Yours Tony

  linux.conf.au    http://www.marchsouth.org/
  Jan 19 - 24 2009 The Australian Linux Technical Conference!
Acked-by on v1 1/1
#1 lore raw
Quoted 2 lines · Tony Breeds

ibm_configure_kernel_dump, is passed as the token to rtas_call() but I cannot see where it is initialised. Set it to something sane?

Yes, please.

Acked-by Nathan Lynch <[email protected]>

Would be good to know whether the dump area registration and dump retrieval are working with your changes. Doesn't look like they could have worked at all with this bug.

Acked-by on v1 1/1
#2 lore raw
In reply to Tony Breeds

Yes,

That is required. It is in the patches that I sent to Ben, Paul & Brad.

I just waiting to post it with other patches.

Acked-by Manish Ahuja <[email protected]>
Quoted 21 lines · Tony Breeds

ibm_configure_kernel_dump, is passed as the token to rtas_call() but I cannot see where it is initialised. Set it to something sane?

Signed-off-by Tony Breeds <[email protected]>
---
 arch/powerpc/platforms/pseries/phyp_dump.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/powerpc/platforms/pseries/phyp_dump.c +2 -0
index 16e659a..6cf35cd 100644
@@ -414,6 +414,8 @@ static int __init phyp_dump_setup(void)
 		of_node_put(rtas);
 	}
 
+	ibm_configure_kernel_dump = rtas_token("ibm,configure-kernel-dump");
+
 	print_dump_header(dump_header);
 	dump_area_length = init_dump_header(&phdr);
 	/* align down */
Signature · 6 lines
--
Manish Ahuja
Linux RAS Engineer.
IBM Linux Technology Center
[email protected]
512-838-1928, t/l 678-1928.
#3 lore raw
In reply to Tony Breeds
Quoted 4 lines · Tony Breeds

ibm_configure_kernel_dump, is passed as the token to rtas_call() but I cannot see where it is initialised. Set it to something sane?

Signed-off-by Tony Breeds <[email protected]>

Seems sane as a fix, just a note that whoever needs to apply this patch should fix the Subject line to say "rtas" and not "rats".

Though rats is applicable at times :)

josh