startup race in hso driver
Subsystems (4)
PATCH 1/1 startup race in hso driver
The flag marking a device running must be set before the URBs for recption are submitted or they may complete too early and fail to resubmit.
Regards
Oliver
---
drivers/net/usb/hso.c +0 -1
@@ -658,10 +658,9 @@ static int hso_net_open(struct net_device *net) odev->rx_buf_missing =sizeof (struct iphdr );spin_unlock_irqrestore (&odev->net_lock, flags); -hso_start_net_device (odev->parent);
A message that is not in the archive (sent off-list or not yet received): 200812181457.36340.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org
Thanks Oliver,
I'll add it to our internal tree.
Quoted 30 lines · Oliver Neukum
The flag marking a device running must be set before the URBs for recption are submitted or they may complete too early and fail to resubmit.
Signed-off-by Oliver Neukum <[email protected]>Regards
Oliver---
drivers/net/usb/hso.c +1
-3@@ -658,10 +658,9 @@ static int hso_net_open(struct net_device *net) odev->rx_buf_missing =sizeof (struct iphdr );spin_unlock_irqrestore (&odev->net_lock, flags); -hso_start_net_device (odev->parent); -/* We are up and running. */ set_bit (HSO_NET_RUNNING , &odev->flags); +hso_start_net_device (odev->parent);/* Tell the kernel we are ready to start receiving from it */ netif_start_queue (net); --To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 22 lines
best regards, D.J. Barrow Linux Kernel Developer Option NV, Gaston Geenslaan 14, 3001 Leuven, Belgium T: +32 16 311 621 F: +32 16 207 164 Mobile Ireland: +353-86-1715438 Mobile Belgium +32-496-226190 [email protected] barrow_dj-/[email protected] www.option.com www.travelsmart.ie Disclaimer: http://www.option.com/company/disclaimer.shtml RPR Leuven 0429.375.448 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
From: Denis Joseph Barrow <[email protected]>
Date: Thu, 18 Dec 2008 14:59:04 +0100
Quoted 2 lines
Thanks Oliver,
I'll add it to our internal tree.
Ok, I'll pull it out of net-next-2.6 then...
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 20081218.195251.186334055.davem-fT/PcQaiUtIeIZ0/[email protected]
No no no.
Please put it in Dave,
Our internal tree is a completely seperately maintained hso module which is ifdeffed out of existance to compile back to 2.6.11.
It's typically made available at www.pharscape.org, the center of the universe for 3G on linux.
Quoted 7 lines · David Miller
From: Denis Joseph Barrow <[email protected]>
Date: Thu, 18 Dec 2008 14:59:04 +0100Quoted 2 lines
Thanks Oliver,
I'll add it to our internal tree.Ok, I'll pull it out of net-next-2.6 then...
Signature · 22 lines
best regards, D.J. Barrow Linux Kernel Developer Option NV, Gaston Geenslaan 14, 3001 Leuven, Belgium T: +32 16 311 621 F: +32 16 207 164 Mobile Ireland: +353-86-1715438 Mobile Belgium +32-496-226190 [email protected] barrow_dj-/[email protected] www.option.com www.travelsmart.ie Disclaimer: http://www.option.com/company/disclaimer.shtml RPR Leuven 0429.375.448 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
David Miller
maintainerFrom: Denis Joseph Barrow <[email protected]>
Date: Fri, 19 Dec 2008 10:20:54 +0100
Quoted 7 lines
No no no.
Please put it in Dave,
Our internal tree is a completely seperately maintained hso module which is ifdeffed out of existance to compile back to 2.6.11.It's typically made available at www.pharscape.org, the center of the universe for 3G on linux.
Ok, thanks for the clarification, I've put the patch back into net-next-2.6
A message that is not in the archive (sent off-list or not yet received): 20081222.195420.82285555.davem-fT/PcQaiUtIeIZ0/[email protected]
Am Dienstag, 23. Dezember 2008 04:54:20 schrieb David Miller:
Quoted 8 lines
From: Denis Joseph Barrow <[email protected]>
Date: Fri, 19 Dec 2008 10:20:54 +0100Quoted 5 lines
No no no.
Please put it in Dave,
Our internal tree is a completely seperately maintained hso module which is ifdeffed out of existance to compile back to 2.6.11.
Quoted 5 lines
Quoted 2 lines
It's typically made available at www.pharscape.org, the center of the universe for 3G on linux.
Ok, thanks for the clarification, I've put the patch back into net-next-2.6
Perhaps that issue should be documented in MAINTAINERS.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Oliver Neukum <[email protected]>
Date: Thu, 18 Dec 2008 14:57:35 +0100
Quoted 4 lines
The flag marking a device running must be set before the URBs for recption are submitted or they may complete too early and fail to resubmit.
Signed-off-by Oliver Neukum <[email protected]>
Applied to net-next-2.6, thanks Oliver.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Oliver,
Is the patch below now obselete?
I applied it to our internal tree, should I remove it?
I've yet to check the code in the big patch with subject
Re: another race in hso
Does this patch render the small one below obselete?
Quoted 30 lines · Oliver Neukum
The flag marking a device running must be set before the URBs for recption are submitted or they may complete too early and fail to resubmit.
Signed-off-by Oliver Neukum <[email protected]>Regards
Oliver---
drivers/net/usb/hso.c +1
-3@@ -658,10 +658,9 @@ static int hso_net_open(struct net_device *net) odev->rx_buf_missing =sizeof (struct iphdr );spin_unlock_irqrestore (&odev->net_lock, flags); -hso_start_net_device (odev->parent); -/* We are up and running. */ set_bit (HSO_NET_RUNNING , &odev->flags); +hso_start_net_device (odev->parent);/* Tell the kernel we are ready to start receiving from it */ netif_start_queue (net); --To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 17 lines
best regards, D.J. Barrow Linux Kernel Developer Option NV, Gaston Geenslaan 14, 3001 Leuven, Belgium T: +32 16 311 621 F: +32 16 207 164 [email protected] www.option.com Disclaimer: http://www.option.com/company/disclaimer.shtml -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
Am Monday 12 January 2009 11:03:02 schrieb Denis Joseph Barrow:
Quoted 3 lines
Hi Oliver,
Is the patch below now obselete?
I applied it to our internal tree, should I remove it?
Hi,
this patch is still needed. It fixes a completely different issue than the second, large patch I sent later. This patch solves a race between startup and urb completion. The second patch fixes a race between xmit and autosuspend.
Earlier today you wanted your patches broken down by bugs they fix, so you've already gotten what you wanted ;-)
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html