Skip to contentSkip to conversation

drm/i915: fix sparse warnings: declare one-bit bitfield as unsigned

PATCH In review Hannes Eder 2 participants 2 messages Dec 18, 2008

Subsystems (3)
DRM drivers Intel i915 Kernel janitors
lore
Share & tools
lore

Hannes Eder

author
#0 lore raw

PATCH 1/6 drm/i915: fix sparse warnings: declare one-bit bitfield as unsigned

Fix this sparse warnings:

drivers/gpu/drm/i915/i915_drv.h:169:22: error: dubious one-bit signed bitfield drivers/gpu/drm/i915/i915_drv.h:169:22: warning: dubious bitfield without explicit signed' or unsigned' drivers/gpu/drm/i915/i915_drv.h:170:19: error: dubious one-bit signed bitfield drivers/gpu/drm/i915/i915_drv.h:170:19: warning: dubious bitfield without explicit signed' or unsigned' drivers/gpu/drm/i915/i915_drv.h:171:16: error: dubious one-bit signed bitfield drivers/gpu/drm/i915/i915_drv.h:171:16: warning: dubious bitfield without explicit signed' or unsigned' drivers/gpu/drm/i915/i915_drv.h:172:23: error: dubious one-bit signed bitfield drivers/gpu/drm/i915/i915_drv.h:172:23: warning: dubious bitfield without explicit signed' or unsigned'

Signed-off-by Hannes Eder <[email protected]>
---
 drivers/gpu/drm/i915/i915_drv.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +4 -4
index 467572a..a640bcf 100644
@@ -166,10 +166,10 @@ typedef struct drm_i915_private {
 	struct drm_display_mode *vbt_mode; /* if any */
 
 	/* Feature bits from the VBIOS */
-	int int_tv_support:1;
-	int lvds_dither:1;
-	int lvds_vbt:1;
-	int int_crt_support:1;
+	unsigned int int_tv_support:1;
+	unsigned int lvds_dither:1;
+	unsigned int lvds_vbt:1;
+	unsigned int int_crt_support:1;
 
 	struct drm_i915_fence_reg fence_regs[16]; /* assume 965 */
 	int fence_reg_start; /* 4 if userland hasn't ioctl'd us yet */
Signature · 1 line
1.5.6.3
Acked-by on v1 1/6
#1 lore raw
Quoted 29 lines · Hannes Eder

Fix this sparse warnings:

drivers/gpu/drm/i915/i915_drv.h:169:22: error: dubious one-bit signed
bitfield drivers/gpu/drm/i915/i915_drv.h:169:22: warning: dubious bitfield without explicit signed' or unsigned' drivers/gpu/drm/i915/i915_drv.h:170:19: error: dubious one-bit signed bitfield drivers/gpu/drm/i915/i915_drv.h:170:19: warning: dubious bitfield without explicit signed' or unsigned' drivers/gpu/drm/i915/i915_drv.h:171:16: error: dubious one-bit signed bitfield drivers/gpu/drm/i915/i915_drv.h:171:16: warning: dubious bitfield without explicit signed' or unsigned' drivers/gpu/drm/i915/i915_drv.h:172:23: error: dubious one-bit signed bitfield drivers/gpu/drm/i915/i915_drv.h:172:23: warning: dubious bitfield without explicit signed' or unsigned'

Signed-off-by Hannes Eder <[email protected]>
---
 drivers/gpu/drm/i915/i915_drv.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/i915_drv.h index 467572a..a640bcf 100644

drivers/gpu/drm/i915/i915_drv.h +0 -1
@@ -166,10 +166,10 @@ typedef struct drm_i915_private {
 	struct drm_display_mode *vbt_mode; /* if any */
 
 	/* Feature bits from the VBIOS */
-	int int_tv_support:1;

drivers/gpu/drm/i915/i915_drv.h typedef struct drm_i915_private { · line 175

Quoted 10 lines
drivers/gpu/drm/i915/i915_drv.h +4 -3
-	int lvds_dither:1;
-	int lvds_vbt:1;
-	int int_crt_support:1;
+	unsigned int int_tv_support:1;
+	unsigned int lvds_dither:1;
+	unsigned int lvds_vbt:1;
+	unsigned int int_crt_support:1;
 
 	struct drm_i915_fence_reg fence_regs[16]; /* assume 965 */
 	int fence_reg_start; /* 4 if userland hasn't ioctl'd us yet */
Acked-by Jesse Barnes <[email protected]>
Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center