Skip to contentSkip to conversation

fix some code style that line over 80 characters

PATCH NAK Helight.Xu 5 participants 6 messages Dec 10, 2008 – Dec 19, 2008

Subsystems (2)
Arm Samsung Exynos I2C subsystem host drivers
lore
Share & tools
lore

Helight.Xu

author
#0 lore raw

PATCH 1/1 fix some code style that line over 80 characters

Quoted 2 lines

From 449a3ddd01a98aae9122d5199083f45ab9c98469 Mon Sep 17 00:00:00 2001

From: Zhwen Xu <[email protected]>
Date: Wed, 10 Dec 2008 21:29:04 +0800
Subject: [PATCH] fix some code style that line over 80 characters

Signed-off-by ZhenwenXu <[email protected]>
---
 drivers/i2c/busses/i2c-s3c2410.c |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)
drivers/i2c/busses/i2c-s3c2410.c +8 -4
index c772e02..c466870 100644
@@ -109,7 +109,8 @@ static inline int s3c24xx_i2c_is2440(struct s3c24xx_i2c *i2c)
  * the default if there is none
 */
 
-static inline struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
+static inline struct
+s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
 {
 	if (dev->platform_data != NULL)
 		return (struct s3c2410_platform_i2c *)dev->platform_data;

@@ -123,7 +124,8 @@ static inline struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct d
  * or zero to mean ok.
 */
 
-static inline void s3c24xx_i2c_master_complete(struct s3c24xx_i2c *i2c, int ret)
+static inline void
+s3c24xx_i2c_master_complete(struct s3c24xx_i2c *i2c, int ret)
 {
 	dev_dbg(i2c->dev, "master_complete %d\n", ret);
 

@@ -273,7 +275,8 @@ static inline int is_msgend(struct s3c24xx_i2c *i2c)
  * process an interrupt and work out what to do
  */
 
-static int i2s_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
+static int i2s_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c,
+				unsigned long iicstat)
 {
 	unsigned long tmp;
 	unsigned char byte;

@@ -502,7 +505,8 @@ static int s3c24xx_i2c_set_master(struct s3c24xx_i2c *i2c)
  * this starts an i2c transfer
 */
 
-static int s3c24xx_i2c_doxfer(struct s3c24xx_i2c *i2c, struct i2c_msg *msgs, int num)
+static int s3c24xx_i2c_doxfer(struct s3c24xx_i2c *i2c,
+			 struct i2c_msg *msgs, int num)
 {
 	unsigned long timeout;
 	int ret;
Signature · 7 lines
1.5.6.5

-- 
---------------------------------
Zhenwen Xu - Open and Free
Home Page:	http://zhwen.org
My Studio:	http://dim4.cn
NAK
#1 lore raw

drivers/i2c/busses/i2c-s3c2410.c static inline int s3c24xx_i2c_is2440(struct s3c24xx_i2c *i2c) · line 113

Quoted 3 lines · Helight.Xu
drivers/i2c/busses/i2c-s3c2410.c +2 -1
-static inline struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
+static inline struct
+s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)

NAK!

#2 lore raw

PATCH 1/1 fix some code style that line over 80 characters

fix some code style that characters more than 80
in drivers/i2c/busses/i2c-s3c2410.c

Quoted 1 line

From 449a3ddd01a98aae9122d5199083f45ab9c98469 Mon Sep 17 00:00:00 2001

From: Zhwen Xu <[email protected]>
Date: Wed, 10 Dec 2008 21:29:04 +0800
Subject: [PATCH] fix some code style that characters more than 80

Signed-off-by ZhenwenXu <[email protected]>
---
 drivers/i2c/busses/i2c-s3c2410.c |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)
drivers/i2c/busses/i2c-s3c2410.c +8 -4
index c772e02..c466870 100644
@@ -109,7 +109,8 @@ static inline int s3c24xx_i2c_is2440(struct s3c24xx_i2c *i2c)
  * the default if there is none
 */
 
-static inline struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
+static inline
+struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
 {
 	if (dev->platform_data != NULL)
 		return (struct s3c2410_platform_i2c *)dev->platform_data;

@@ -123,7 +124,8 @@ static inline struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct d
  * or zero to mean ok.
 */
 
-static inline void s3c24xx_i2c_master_complete(struct s3c24xx_i2c *i2c, int ret)
+static inline void
+s3c24xx_i2c_master_complete(struct s3c24xx_i2c *i2c, int ret)
 {
 	dev_dbg(i2c->dev, "master_complete %d\n", ret);
 

@@ -273,7 +275,8 @@ static inline int is_msgend(struct s3c24xx_i2c *i2c)
  * process an interrupt and work out what to do
  */
 
-static int i2s_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
+static int i2s_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c,
+				unsigned long iicstat)
 {
 	unsigned long tmp;
 	unsigned char byte;

@@ -502,7 +505,8 @@ static int s3c24xx_i2c_set_master(struct s3c24xx_i2c *i2c)
  * this starts an i2c transfer
 */
 
-static int s3c24xx_i2c_doxfer(struct s3c24xx_i2c *i2c, struct i2c_msg *msgs, int num)
+static int s3c24xx_i2c_doxfer(struct s3c24xx_i2c *i2c,
+			 struct i2c_msg *msgs, int num)
 {
 	unsigned long timeout;
 	int ret;
Signature · 7 lines
1.5.6.5

-- 
---------------------------------
Zhenwen Xu - Open and Free
Home Page:	http://zhwen.org
My Studio:	http://dim4.cn
#3 lore raw
In reply to Alexey Dobriyan
Quoted 6 lines · On Wed, 10 Dec 2008 18:01:16 +0300 Alexey Dobriyan wrote:

drivers/i2c/busses/i2c-s3c2410.c static inline int s3c24xx_i2c_is2440(struct s3c24xx_i2c *i2c) · line 113

Quoted 3 lines · Helight.Xu
drivers/i2c/busses/i2c-s3c2410.c +2 -1
-static inline struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
+static inline struct
+s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)

NAK!

OK, but please includes reason(s) for NAKs...

---
~Randy

#4 lore raw
Quoted 10 lines · Randy Dunlap
Quoted 6 lines · On Wed, 10 Dec 2008 18:01:16 +0300 Alexey Dobriyan wrote:

drivers/i2c/busses/i2c-s3c2410.c static inline int s3c24xx_i2c_is2440(struct s3c24xx_i2c *i2c) · line 113

Quoted 3 lines · Helight.Xu
drivers/i2c/busses/i2c-s3c2410.c +2 -1
-static inline struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
+static inline struct
+s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)

NAK!

OK, but please includes reason(s) for NAKs...

I can provide a reason - it splits "struct" and the structure name across different lines. That manes 'struct s3c2410_platform_i2c' hard to grep for.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
#5 lore raw
Quoted 10 lines · Russell King
Quoted 9 lines · Randy Dunlap
Quoted 6 lines · On Wed, 10 Dec 2008 18:01:16 +0300 Alexey Dobriyan wrote:

drivers/i2c/busses/i2c-s3c2410.c static inline int s3c24xx_i2c_is2440(struct s3c24xx_i2c *i2c) · line 113

Quoted 3 lines · Helight.Xu
drivers/i2c/busses/i2c-s3c2410.c +2 -1
-static inline struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)
+static inline struct
+s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)

NAK!

Quoted 5 lines
Quoted 1 line

OK, but please includes reason(s) for NAKs...

I can provide a reason - it splits "struct" and the structure name across different lines. That manes 'struct s3c2410_platform_i2c' hard to grep for.

yes, it should be:
static inline
struct s3c2410_platform_i2c *s3c24xx_i2c_get_platformdata(struct device *dev)

Quoted 5 lines
Signature · 4 lines
-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
Signature · 4 lines
---------------------------------
Zhenwen Xu - Open and Free
Home Page:	http://zhwen.org
My Studio:	http://dim4.cn