handle unaligned data in xfs_bmbt_disk_get_all
PATCH 1/1 handle unaligned data in xfs_bmbt_disk_get_all
In libxfs xfs_bmbt_disk_get_all needs to handle unaligned data and thus has been updated to use get_unaligned_be64. In kernelspace we don't strictly need it as the routine is only used for tracing and xfsidbg, but let's keep the two implementations in sync.
Index: xfs/fs/xfs/xfs_bmap_btree.c
fs/xfs/xfs_bmap_btree.c +2 -1
@@ -208,7 +208,8 @@ xfs_bmbt_disk_get_all( xfs_bmbt_rec_t *r, xfs_bmbt_irec_t *s) { -__xfs_bmbt_get_all (be64_to_cpu (r->l0),be64_to_cpu (r->l1), s); +__xfs_bmbt_get_all (get_unaligned_be64 (&r->l0), +get_unaligned_be64 (&r->l1), s); }/*
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Looks good.
Quoted 22 lines · Christoph Hellwig
In libxfs
xfs_bmbt_disk_get_allneeds to handle unaligned data and thus has been updated to useget_unaligned_be64. In kernelspace we don't strictly need it as the routine is only used for tracing and xfsidbg, but let's keep the two implementations in sync.Signed-off-by Christoph Hellwig <[email protected]>Index:
xfs/fs/xfs/xfs_bmap_btree.cfs/xfs/xfs_bmap_btree.c +2
-1@@ -208,7 +208,8 @@ xfs_bmbt_disk_get_all( xfs_bmbt_rec_t *r, xfs_bmbt_irec_t *s) { -__xfs_bmbt_get_all (be64_to_cpu (r->l0),be64_to_cpu (r->l1), s); +__xfs_bmbt_get_all (get_unaligned_be64 (&r->l0), +get_unaligned_be64 (&r->l1), s); }/*
Quoted 4 lines
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs