mlx4_en: Memory leak on completion queue free
Subsystems (2)
PATCH 1/9 mlx4_en: Memory leak on completion queue free
If port is being destroyed without being activated before, CQ resources are not freed.
Signed-off-by Yevgeny Petrilin <[email protected]>
--- drivers/net/mlx4/en_cq.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/net/mlx4/en_cq.c +2 -1
@@ -71,6 +71,8 @@ int mlx4_en_create_cq(struct mlx4_en_priv *priv, err =mlx4_en_map_buffer (&cq->wqres.buf);if (err)mlx4_free_hwq_res (mdev->dev, &cq->wqres, cq->buf_size); +else + cq->buf = (struct mlx4_cqe *) cq->wqres.buf.direct.buf;return err; }
@@ -85,7 +87,6 @@ int mlx4_en_activate_cq(struct mlx4_en_priv *priv, struct mlx4_en_cq *cq) cq->mcq.arm_db = cq->wqres.db.db +1 ; *cq->mcq.set_ci_db =0 ; *cq->mcq.arm_db =0 ; - cq->buf = (struct mlx4_cqe *) cq->wqres.buf.direct.buf;memset (cq->buf,0 , cq->buf_size); err = mlx4_cq_alloc(mdev->dev, cq->size, &cq->wqres.mtt, &mdev->priv_uar,
Signature · 1 line
1.5.4
From: Yevgeny Petrilin <[email protected]>
Date: Mon, 22 Dec 2008 12:00:04 +0200
Quoted 4 lines
If port is being destroyed without being activated before, CQ resources are not freed.
Signed-off-by Yevgeny Petrilin <[email protected]>
Applied.