fs/exec.c: make do_coredump() void

PATCH New Américo Wang 1 participant 1 message Dec 26, 2008

Subsystems (2)

VFS exec and binfmt

lore

Share & tools

lore

Américo Wang

author

2008-12-26 09:40 UTC #0 lore raw

PATCH 1/1 fs/exec.c: make do_coredump() void

No one cares do_coredump()'s return value, and also it seems that it is also not necessary. So make it void.

Signed-off-by WANG Cong <[email protected]>

Cc Alexander Viro <[email protected]>

---

fs/exec.c +2 -2

index ec5df9a..c48a040 100644
@@ -1708,7 +1708,7 @@ int get_dumpable(struct mm_struct *mm)
 	return (ret >= 2) ? 2 : ret;
 }
 
-int do_coredump(long signr, int exit_code, struct pt_regs * regs)
+void do_coredump(long signr, int exit_code, struct pt_regs * regs)
 {
 	struct core_state core_state;
 	char corename[CORENAME_MAX_SIZE + 1];

@@ -1845,5 +1845,5 @@ fail_unlock:
 	current->fsuid = fsuid;
 	coredump_finish(mm);
 fail:
-	return retval;
+	return;
 }

include/linux/binfmts.h +1 -1

index 7394b5b..a063f7e 100644
@@ -102,7 +102,7 @@ extern int setup_arg_pages(struct linux_binprm * bprm,
 extern int bprm_mm_init(struct linux_binprm *bprm);
 extern int copy_strings_kernel(int argc,char ** argv,struct linux_binprm *bprm);
 extern void compute_creds(struct linux_binprm *binprm);
-extern int do_coredump(long signr, int exit_code, struct pt_regs * regs);
+extern void do_coredump(long signr, int exit_code, struct pt_regs * regs);
 extern int set_binfmt(struct linux_binfmt *new);
 extern void free_bprm(struct linux_binprm *);