Skip to contentSkip to conversation

m68k: fix recursive dependency in Kconfig

PATCH Applied Sam Ravnborg 2 participants 5 messages Dec 26, 2008 – Dec 29, 2008 m68k architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 m68k: fix recursive dependency in Kconfig

We had a recursive dependency between MMU_MOTOROLA and MMU_SUN3 Fix it by dropping the unused dependencies on MMU_MOTOROLA.

MMU_MOTOROLA is set to y only using select so any dependencies are anyway ignored.

Cc Geert Uytterhoeven <[email protected]>
Cc Roman Zippel <[email protected]>

---

I hit this recursive dependency with a patched version of kconfig so you may not see it today.
The fix is obvious - please apply.

Sam

 arch/m68k/Kconfig |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/m68k/Kconfig +0 -1
index 836fb66..c825bde 100644
@@ -280,7 +280,6 @@ config M68060
 
 config MMU_MOTOROLA
 	bool
-	depends on MMU && !MMU_SUN3
 
 config MMU_SUN3
 	bool
Signature · 1 line
1.6.0.2.GIT
maintainer Applied
#1 lore raw
Quoted 6 lines · Sam Ravnborg

We had a recursive dependency between MMU_MOTOROLA and MMU_SUN3 Fix it by dropping the unused dependencies on MMU_MOTOROLA.

MMU_MOTOROLA is set to y only using select so any dependencies are anyway ignored.

Quoted 8 lines
Cc Geert Uytterhoeven <[email protected]>
Cc Roman Zippel <[email protected]>

---

I hit this recursive dependency with a patched version of kconfig so you may not see it today.
The fix is obvious - please apply.

Queued in for-next.

I guess you want this in Linus' tree for 2.6.29?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#2 lore raw
Quoted 12 lines · Geert Uytterhoeven
Quoted 11 lines · Sam Ravnborg

We had a recursive dependency between MMU_MOTOROLA and MMU_SUN3 Fix it by dropping the unused dependencies on MMU_MOTOROLA.

MMU_MOTOROLA is set to y only using select so any dependencies are anyway ignored.

Cc Geert Uytterhoeven <[email protected]>
Cc Roman Zippel <[email protected]>

---

Quoted 7 lines
Quoted 3 lines

I hit this recursive dependency with a patched version of kconfig so you may not see it today.
The fix is obvious - please apply.

Queued in for-next.

I guess you want this in Linus' tree for 2.6.29?

Yes please. I plan to submit the improved dependency check in my second kbuild update if Roman do not nack it.

Sam

maintainer Acked-by
#3 lore raw
Quoted 17 lines · Sam Ravnborg
Quoted 16 lines · Geert Uytterhoeven
Quoted 14 lines · Sam Ravnborg

We had a recursive dependency between MMU_MOTOROLA and MMU_SUN3 Fix it by dropping the unused dependencies on MMU_MOTOROLA.

MMU_MOTOROLA is set to y only using select so any dependencies are anyway ignored.

Cc Geert Uytterhoeven <[email protected]>
Cc Roman Zippel <[email protected]>

---

I hit this recursive dependency with a patched version of kconfig so you may not see it today.
The fix is obvious - please apply.

Quoted 6 lines
Quoted 3 lines

Queued in for-next.

I guess you want this in Linus' tree for 2.6.29?

Yes please. I plan to submit the improved dependency check in my second kbuild update if Roman do not nack it.

As Linus just pulled from the m68k tree, it may take a while before I have some more stuff ready. So please feel free to add it to the kbuild tree before submitting the improved dependency check.

Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#4 lore raw
Quoted 22 lines · Geert Uytterhoeven
Quoted 21 lines · Sam Ravnborg
Quoted 19 lines · Geert Uytterhoeven
Quoted 6 lines · Sam Ravnborg

We had a recursive dependency between MMU_MOTOROLA and MMU_SUN3 Fix it by dropping the unused dependencies on MMU_MOTOROLA.

MMU_MOTOROLA is set to y only using select so any dependencies are anyway ignored.

Quoted 8 lines
Cc Geert Uytterhoeven <[email protected]>
Cc Roman Zippel <[email protected]>

---

I hit this recursive dependency with a patched version of kconfig so you may not see it today.
The fix is obvious - please apply.

Queued in for-next.

I guess you want this in Linus' tree for 2.6.29?

Quoted 8 lines
Quoted 2 lines

Yes please. I plan to submit the improved dependency check in my second kbuild update if Roman do not nack it.

As Linus just pulled from the m68k tree, it may take a while before I have some more stuff ready. So please feel free to add it to the kbuild tree before submitting the improved dependency check.

OK - I added it to kbuild with your ack - thanks.

Sam