Skip to contentSkip to conversation

powerpc/fsl_pci: Fix sparse warnings

PATCH Applied Anton Vorontsov 2 participants 2 messages Dec 29, 2008 – Dec 30, 2008 PowerPC

lore
Share & tools
lore

Anton Vorontsov

author
#0 lore raw

PATCH 1/4 powerpc/fsl_pci: Fix sparse warnings

This patch fixes following sparse warnings:

CHECK fsl_pci.c
fsl_pci.c:32:13: warning: symbol 'setup_pci_atmu' was not declared. Should it be static? fsl_pci.c:89:13: warning: symbol 'setup_pci_cmd' was not declared. Should it be static? fsl_pci.c:133:12: warning: symbol 'fsl_pcie_check_link' was not declared. Should it be static?

Signed-off-by Anton Vorontsov <[email protected]>
---
 arch/powerpc/sysdev/fsl_pci.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
arch/powerpc/sysdev/fsl_pci.c +4 -3
index d5f9ae0..f611d03 100644
@@ -29,7 +29,8 @@
 
 #if defined(CONFIG_PPC_85xx) || defined(CONFIG_PPC_86xx)
 /* atmu setup for fsl pci/pcie controller */
-void __init setup_pci_atmu(struct pci_controller *hose, struct resource *rsrc)
+static void __init setup_pci_atmu(struct pci_controller *hose,
+				  struct resource *rsrc)
 {
 	struct ccsr_pci __iomem *pci;
 	int i;

@@ -86,7 +87,7 @@ void __init setup_pci_atmu(struct pci_controller *hose, struct resource *rsrc)
 	out_be32(&pci->piw[2].piwar, PIWAR_2G);
 }
 
-void __init setup_pci_cmd(struct pci_controller *hose)
+static void __init setup_pci_cmd(struct pci_controller *hose)
 {
 	u16 cmd;
 	int cap_x;

@@ -130,7 +131,7 @@ static void __init quirk_fsl_pcie_header(struct pci_dev *dev)
 	return ;
 }
 
-int __init fsl_pcie_check_link(struct pci_controller *hose)
+static int __init fsl_pcie_check_link(struct pci_controller *hose)
 {
 	u32 val;
 	early_read_config_dword(hose, 0, 0, PCIE_LTSSM, &val);
Signature · 1 line
1.5.6.5
Applied
#1 lore raw
Quoted 11 lines · Anton Vorontsov

This patch fixes following sparse warnings:

CHECK fsl_pci.c
fsl_pci.c:32:13: warning: symbol 'setup_pci_atmu' was not declared. Should it be static? fsl_pci.c:89:13: warning: symbol 'setup_pci_cmd' was not declared. Should it be static? fsl_pci.c:133:12: warning: symbol 'fsl_pcie_check_link' was not declared. Should it be static?

Signed-off-by Anton Vorontsov <[email protected]>

---
arch/powerpc/sysdev/fsl_pci.c | 7 ++++---

1 files changed, 4 insertions(+), 3 deletions(-)

applied to next

- k