Skip to contentSkip to conversation

xfsprogs: make install-qa should only install additional headers

PATCH In review Christoph Hellwig 2 participants 2 messages Dec 30, 2008 – Jan 1, 2009 Kbuild

lore
Share & tools
lore

Christoph Hellwig

author
#0 lore raw

PATCH 1/1 xfsprogs: make install-qa should only install additional headers

make install-qa should only install the headers a normal install-dev doesn't install instead of repeating the whole game.

That way the additional headers for xfsqa can be installed manually while using dpkg / rpm for the normal package.

Signed-off-by Christoph Hellwig <[email protected]>
Makefile +1 -1
Index: xfsprogs/Makefile
===================================================================
@@ -76,7 +76,7 @@
 
 install-dev: default $(addsuffix -install-dev,$(SUBDIRS))
 
-install-qa: install $(addsuffix -install-qa,$(SUBDIRS))
+install-qa: default $(addsuffix -install-qa,$(SUBDIRS))
 
 %-install:
 	$(MAKE) -C $* install
include/Makefile +1 -1
Index: xfsprogs/include/Makefile
===================================================================
@@ -54,5 +54,5 @@
 	$(INSTALL) -m 755 -d $(DK_INC_DIR)
 	$(INSTALL) -m 644 $(DKHFILES) $(DK_INC_DIR)
 
-install-qa: install-dev
+install-qa: default
 	$(INSTALL) -m 644 $(QAHFILES) $(PKG_INC_DIR)
libdisk/Makefile +1 -1
Index: xfsprogs/libdisk/Makefile
===================================================================
@@ -29,4 +29,4 @@
 install-dev: default
 	$(INSTALL_LTLIB_STATIC)
 
-install-qa: install-dev
+install-qa: default
libhandle/Makefile +1 -1
Index: xfsprogs/libhandle/Makefile
===================================================================
@@ -22,4 +22,4 @@
 install-dev: default
 	$(INSTALL_LTLIB_DEV)
 
-install-qa: install-dev
+install-qa: default

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#1 lore raw
Quoted 5 lines · Christoph Hellwig

make install-qa should only install the headers a normal install-dev doesn't install instead of repeating the whole game.

That way the additional headers for xfsqa can be installed manually while using dpkg / rpm for the normal package.

This seems mostly ok, but "install-qa" sort of sounds like it should install the headers you need for qa and it doesn't, it only (now) installs the extras right...? By itself it's kind of a useless target without also running install-dev isn't it?

To be correct, I think install-qa should have install-dev as a prereq.

Maybe do that, and add a new install-qa-only target? :)

Quoted 48 lines
Signed-off-by Christoph Hellwig <[email protected]>

Index: xfsprogs/Makefile
===================================================================

Makefile +1 -1
@@ -76,7 +76,7 @@
 
 install-dev: default $(addsuffix -install-dev,$(SUBDIRS))
 
-install-qa: install $(addsuffix -install-qa,$(SUBDIRS))
+install-qa: default $(addsuffix -install-qa,$(SUBDIRS))
 
 %-install:
 	$(MAKE) -C $* install

Index: xfsprogs/include/Makefile
===================================================================

include/Makefile +1 -1
@@ -54,5 +54,5 @@
 	$(INSTALL) -m 755 -d $(DK_INC_DIR)
 	$(INSTALL) -m 644 $(DKHFILES) $(DK_INC_DIR)
 
-install-qa: install-dev
+install-qa: default
 	$(INSTALL) -m 644 $(QAHFILES) $(PKG_INC_DIR)

Index: xfsprogs/libdisk/Makefile
===================================================================

libdisk/Makefile +1 -1
@@ -29,4 +29,4 @@
 install-dev: default
 	$(INSTALL_LTLIB_STATIC)
 
-install-qa: install-dev
+install-qa: default

Index: xfsprogs/libhandle/Makefile
===================================================================

libhandle/Makefile +1 -1
@@ -22,4 +22,4 @@
 install-dev: default
 	$(INSTALL_LTLIB_DEV)
 
-install-qa: install-dev
+install-qa: default
Quoted 5 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs