vfs patches, part 1
Beginning of VFS queue for .29-rc1; that's just the first part. Please pull fromgit://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/ for-linus.
Shortlog:
Al Viro (8):
fix switch_names() breakage in short-to-short case take init_fs to saner place
kill ->dir_notify()
nfsd/create race fixes, infrastructure nfsd races, ext2
nfsd races, ext3
nfsd races, ext4
nfsd races, reiserfs
Arjan van de Ven (1):
[patch 10/11] vfs: expand some comments (d_path / seq_path)
Christoph Hellwig (4):
remove incorrect comment in inode_permission kill walk_init_root
pass a struct path * to may_open kill vfs_permission
Dave Kleikamp (1):
nfsd races, jfs
Denis ChengRq (1):
[patch 05/11] fs/block_dev.c: __read_mostly improvement and sb_is_blkdev_sb utilization
Duane Griffin (9):
eCryptfs: check readlink result was not an error before using it
vfs: introduce helper function to safely NUL-terminate symlinks
vfs: ensure page symlinks are NUL-terminated
ext2: ensure fast symlinks are NUL-terminated
ext3: ensure fast symlinks are NUL-terminated
ext4: ensure fast symlinks are NUL-terminated
sysv: ensure fast symlinks are NUL-terminated
freevxfs: ensure fast symlinks are NUL-terminated
befs: ensure fast symlinks are NUL-terminated
Eric Dumazet (2):
fix f_count description in Documentation/filesystems/files.txt filp_cachep can be static in fs/file_table.c
Eric Paris (1):
filesystem notification: create fs/notify to contain all fs
Jan Engelhardt (1):
[patch 02/11] include: linux/fs.h: put declarations in __KERNEL__
Julia Lawall (1):
[patch 03/11] fs/namespace.c: drop code after return
Kentaro Takeda (1):
introduce new LSM hooks where vfsmount is available.
Nick Piggin (1):
[patch][rfc] fs: shrink struct dentry
Richard Kennedy (1):
fs: reorder struct inotify_device on 64bits to remove
Steven Rostedt (1):
make INIT_FS use the __RW_LOCK_UNLOCKED initialization
Zhaolei (1):
[patch 09/11] vfs: correct wrong function name of d_put in kernel document and source comment
Diffstat:
Documentation/filesystems/Locking | 2 -
Documentation/filesystems/files.txt | 6 +-
Documentation/filesystems/vfs.txt | 5 +-
arch/alpha/kernel/init_task.c | 1 -
arch/arm/kernel/init_task.c | 1 -
arch/avr32/kernel/init_task.c | 1 -
arch/blackfin/kernel/init_task.c | 1 -
arch/cris/kernel/process.c | 1 -
arch/frv/kernel/init_task.c | 1 -
arch/h8300/kernel/init_task.c | 1 -
arch/ia64/kernel/init_task.c | 1 -
arch/m32r/kernel/init_task.c | 1 -
arch/m68k/kernel/process.c | 1 -
arch/m68knommu/kernel/init_task.c | 1 -
arch/mips/kernel/init_task.c | 1 -
arch/mn10300/kernel/init_task.c | 1 -
arch/parisc/kernel/init_task.c | 1 -
arch/powerpc/kernel/init_task.c | 1 -
arch/powerpc/oprofile/cell/spu_task_sync.c | 2 +-
arch/s390/kernel/init_task.c | 1 -
arch/sh/kernel/init_task.c | 1 -
arch/sparc/kernel/init_task.c | 1 -
arch/um/kernel/init_task.c | 1 -
arch/x86/kernel/init_task.c | 1 -
arch/xtensa/kernel/init_task.c | 1 -
drivers/oprofile/buffer_sync.c | 2 +-
fs/Kconfig | 39 +--------
fs/Makefile | 5 +-
fs/bad_inode.c | 6 -
fs/befs/linuxvfs.c | 5 +-
fs/block_dev.c | 9 +-
fs/cifs/Makefile | 2 +-
fs/cifs/cifsfs.c | 7 --
fs/cifs/cifsfs.h | 1 -
fs/cifs/fcntl.c | 118 ------------------------
fs/dcache.c | 25 ++---
fs/dcookies.c | 28 ++++--
fs/ecryptfs/inode.c | 3 +-
fs/exec.c | 5 +-
fs/ext2/ialloc.c | 6 +-
fs/ext2/inode.c | 7 +-
fs/ext2/namei.c | 15 +++-
fs/ext3/ialloc.c | 6 +-
fs/ext3/inode.c | 7 +-
fs/ext3/namei.c | 15 +++-
fs/ext4/ialloc.c | 6 +-
fs/ext4/inode.c | 7 +-
fs/ext4/namei.c | 14 +++-
fs/file_table.c | 10 ++-
fs/freevxfs/vxfs_inode.c | 4 +-
fs/inode.c | 59 ++++++++++++
fs/jfs/jfs_inode.c | 29 ++++--
fs/jfs/namei.c | 24 +++--
fs/namei.c | 115 +++++++++++++++--------
fs/namespace.c | 2 +-
fs/nfsctl.c | 5 +-
fs/notify/Kconfig | 2 +
fs/notify/Makefile | 2 +
fs/notify/dnotify/Kconfig | 10 ++
fs/notify/dnotify/Makefile | 1 +
fs/{ => notify/dnotify}/dnotify.c | 3 -
fs/notify/inotify/Kconfig | 27 ++++++
fs/notify/inotify/Makefile | 2 +
fs/{ => notify/inotify}/inotify.c | 0
fs/{ => notify/inotify}/inotify_user.c | 2 +-
fs/open.c | 5 +
fs/reiserfs/inode.c | 15 ++-
fs/reiserfs/namei.c | 8 ++
fs/seq_file.c | 10 ++-
fs/sysv/inode.c | 6 +-
include/linux/dcache.h | 21 +++--
include/linux/fdtable.h | 2 -
include/linux/fs.h | 24 +++---
include/linux/fs_struct.h | 6 -
include/linux/init_task.h | 1 +
include/linux/namei.h | 5 +
include/linux/security.h | 137 ++++++++++++++++++++++++++++
net/unix/af_unix.c | 4 +
security/Kconfig | 9 ++
security/capability.c | 57 ++++++++++++
security/security.c | 66 +++++++++++++
81 files changed, 696 insertions(+), 351 deletions(-)Quoted 3 lines · Al Viro
Beginning of VFS queue for .29-rc1; that's just the first part. Please pull from
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/for-linus.
Al, can you please try to clean up the commit messages?
There's tons of unnecessary "[PATCH, v5]" things in those commit headers, and that seems to mean that you intentionally pass the "--keep" flag to git to keep the crap in subject lines, rather than let git clean it up for you.
Git by default will try to clean things up, so you literally have done extra work to make your commits look like shit!
Similarly, look at commit ef564e5cb82dbadc49949c93d8f7908f58c1016b: not only does it have a "[patch][rfc]" at the head of the subject line (it sure as hell isn't a rfc any more when you've committed it and intend to push it to me!), but the commit message itself contains
Hi,
Comments?
Thanks,
Nick
--in front of the actual message (that commit also lacks a sign-off, btw, probably exactly because Nick wasn't sure it should be applied).
Those things make sense when people pass around patches for comments, but you're supposed to clean the damn things up before applying them! They are pure and utter crap if they make it into the git history - they only add distracting noise, and look bad.
I can understand _occasional_ cases where you miss something like this, but EVERY SINGLE COMMIT is broken in this series. Some just have the crappy [PATCH] thing, but there are several that have extra email crud that makes sense in an email, but not in a commit message.
I pulled it, but after looking at it, I unpulled it again. It really is every single commit that is broken. Even the ones that aren't from emails (they seem to be just your own commits) are broken. Look at 4edb9c1f26c7b7ccd39b7e3fe8aee5096786fdee: it has that [PATCH] header even though it's your own commit (so you apparently wrote it by hand), and the one-liner thing (the one you see in shortlogs or in the gitk overview) is just
[PATCH] nfsd races, reiserfs
which isn't exactly readable. Why isn't it real proper English, something like
Fix nfsd races in reiserfs
which is a properly capitalized real sentence and thus just more readable? And shorter to boot?
Yeah, "git shortlog" will get rid of at least some of these things (it will remove the pure "[patch] " prefixes), and yeah, it used to be common to see [PATCH] in the git logs back early on before we learnt how to make things more readable, so it wouldn't _hurt_ to pull. But I decided to unpull just because I don't want to continue to see things like this.
And btw, feel free to push the pain downward. If they people who send you patches send bad changelogs, just tell them to re-send with a better one. I end up just always editing the mbox I have by hand in order to fix things like this, but I also make sure that people who send me lots of patches know to send them in the right format where I no longer need to fix things. After a while, the number of messages I need to fix up has dropped dramatically, and everybody is happy.
Linus
Quoted 8 lines · Linus Torvalds
There's tons of unnecessary "[PATCH, v5]" things in those commit headers, and that seems to mean that you intentionally pass the "--keep" flag to git to keep the crap in subject lines, rather than let git clean it up for you.
Git by default will try to clean things up, so you literally have done extra work to make your commits look like shit!
The alternative, of course, is that you're using some _really_ old git version, or that you have your own scripts that create the commits by hand. If so, please just update.
Linus
Quoted 3 lines · Linus Torvalds
I pulled it, but after looking at it, I unpulled it again. It really is every single commit that is broken.
Btw, I can re-pull and just do a rebase and fix things up by hand myself, so if you don't want to, I can clean up this sequence myself. But I just don't want it to become a habit, so I want to make sure that at least in the future these things won't look as horrible.
In case you wonder what the easiest way to fix things up is: just export the series as a mbox ("git log -p --stat --pretty=email linus.. > mbox") and then just edit the single mbox file to remove crud. Then you can re-apply it with "git am".
Of course, with git you can do it in a million different ways: You could do it with "git format-patch" or with "git rebase -i" too, for example, but exporting it as an mbox means that you can do it in one single editing session, which is how at least I personally work. Much nicer than having to handle each commit individually.
Linus
Quoted 10 lines · Linus Torvalds
In case you wonder what the easiest way to fix things up is: just export the series as a mbox ("git log -p --stat --pretty=email linus.. > mbox") and then just edit the single mbox file to remove crud. Then you can re-apply it with "git am".
Of course, with git you can do it in a million different ways: You could do it with "git format-patch" or with "git rebase -i" too, for example, but exporting it as an mbox means that you can do it in one single editing session, which is how at least I personally work. Much nicer than having to handle each commit individually.
The "format-patch" equivalent to export to a single mbox is:
$ git format-patch --stdout linus.. >mbox
Quoted 8 lines · Linus Torvalds
Quoted 3 lines · Al Viro
Beginning of VFS queue for .29-rc1; that's just the first part. Please pull from
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/for-linus.Al, can you please try to clean up the commit messages?
Done. Same branch, same patches...
Quoted 5 lines · Al Viro
Quoted 2 lines · Linus Torvalds
Al, can you please try to clean up the commit messages?
Done. Same branch, same patches...
Thanks. Pulled. You had missed one (e2b689d82), but now it's par for the course (ie just the normal occasional mistake) and so I don't mind any more.
Linus