Skip to contentSkip to conversation

mmc: warn about voltage mismatches

PATCH In review David Brownell 2 participants 2 messages Dec 31, 2008 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: warn about voltage mismatches

From: David Brownell <[email protected]>

Get rid of a silent failure mode when the MMC/SD host doesn't support the voltages needed to operate a given card, by adding a warning. A 3.3V host and a 3.0V card, for example, no longer need to mysteriously just not work at all.

This isn't the best diagnostic; ideally it would also tell what voltage the card and host support (and not just by dumping the bitmasks).

---
 drivers/mmc/core/core.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/mmc/core/core.c +2 -0
@@ -467,6 +467,8 @@ u32 mmc_select_voltage(struct mmc_host *
 		host->ios.vdd = bit;
 		mmc_set_ios(host);
 	} else {
+		pr_warning("%s: host doesn't support card's voltages\n",
+				mmc_hostname(host));
 		ocr = 0;
 	}
 
#1 lore raw
Quoted 7 lines · On Wed, 31 Dec 2008 09:50:30 -0800 David Brownell <[email protected]> wrote:

From: David Brownell <[email protected]>

Get rid of a silent failure mode when the MMC/SD host doesn't support the voltages needed to operate a given card, by adding a warning. A 3.3V host and a 3.0V card, for example, no longer need to mysteriously just not work at all.

Hmm... I have sort of always assumed that 3.3V was always required by the host and card, but re-reading the specs that clearly isn't the case.

Quoted 4 lines

This isn't the best diagnostic; ideally it would also tell what voltage the card and host support (and not just by dumping the bitmasks).

Still, it's better than nothing.

Quoted 2 lines

---

Queued.

Signature · 9 lines
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.