Skip to contentSkip to conversation

USB:Fix goku_udc usb speed handling

PATCH In review sangsu 2 participants 2 messages Jan 1, 2009 – Jan 5, 2009 USB

lore
Share & tools
lore

sangsu

author
#0 lore raw

PATCH 1/1 USB:Fix goku_udc usb speed handling

The usb gadget framework revealed weakness in the godu_udc gadget driver register function. Instead of checking if speed asked for was USB_LOW_SPEED upon usb_gadget_register() to deny service, it checked only for USB_FULL_SPEED, thus denying service to usb high speed capable gadgets.

---
drivers/usb/gadget/goku_udc.c |2+-

1 files changed, 1 insertion(+), 1 deletions(-)
drivers/usb/gadget/goku_udc.c +1 -1
@@ -1349,7 +1349,7 @@
 	int			retval;
 
 	if (!driver
-			|| driver->speed != USB_SPEED_FULL
+			|| driver->speed < USB_SPEED_FULL
 			|| !driver->bind
 			|| !driver->disconnect
 			|| !driver->setup)
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · sangsu

The usb gadget framework revealed weakness in the godu_udc gadget driver register function. Instead of checking if speed asked for was USB_LOW_SPEED upon usb_gadget_register() to deny service, it checked only for USB_FULL_SPEED, thus denying service to usb high speed capable gadgets.

Good to know this USB peripheral driver is getting some use. :)

Quoted 18 lines

---
drivers/usb/gadget/goku_udc.c |2+-

1 files changed, 1 insertion(+), 1 deletions(-)
drivers/usb/gadget/goku_udc.c +1 -1
@@ -1349,7 +1349,7 @@
 	int			retval;
 
 	if (!driver
-			|| driver->speed != USB_SPEED_FULL
+			|| driver->speed < USB_SPEED_FULL
 			|| !driver->bind
 			|| !driver->disconnect
 			|| !driver->setup)