sparc: Use 64BIT config entry
PATCH 1/1 sparc: Use 64BIT config entry
Use 64BIT config entry to distinguish between 32 and 64bit builds instead of relying on the ARCH setting. Using sparc64 as ARCH still forces 64BIT on.
Inspired by the x86 and s390 configs.
Signature · 2 lines
You can't evaluate a man by logic alone. -- McCoy, "I, Mudd", stardate 4513.3
arch/sparc/Kconfig +9 -16
@@ -4,6 +4,13 @@ mainmenu "Linux/SPARC Kernel Configuration" +config 64BIT + bool "64-bit kernel" if ARCH = "sparc" + default ARCH = "sparc64" + help + Say yes to build a 64-bit kernel - formerly known as sparc64 + Say no to build a 32-bit kernel - formerly known as sparc + config SPARC bool default y
@@ -15,22 +22,11 @@ config SPARC select RTC_CLASS select RTC_DRV_M48T59 -# Identify this as a Sparc32 build config SPARC32 - bool - default y if ARCH = "sparc" - help - SPARC is a family of RISC microprocessors designed and marketed by - Sun Microsystems, incorporated. They are very widely found in Sun - workstations and clones. This port covers the original 32-bit SPARC; - it is old and stable and usually considered one of the "big three" - along with the Intel and Alpha ports. The UltraLinux project - maintains both the SPARC32 and SPARC64 ports; its web page is - available at <http://www.ultralinux.org/>. + def_bool !64BIT config SPARC64 - bool - default y if ARCH = "sparc64" + def_bool 64BIT select ARCH_SUPPORTS_MSI select HAVE_FUNCTION_TRACER select HAVE_KRETPROBES
@@ -53,9 +49,6 @@ config BITS default 32 if SPARC32 default 64 if SPARC64 -config 64BIT - def_bool y if SPARC64 - config GENERIC_TIME bool default y if SPARC64
Quoted 3 lines · Bastian Blank
Use 64BIT config entry to distinguish between 32 and 64bit builds instead of relying on the ARCH setting. Using sparc64 as ARCH still forces 64BIT on.
Hi Bastian.
I have tested the patch and it works as expected.
One small nit below.
Sam
Quoted 14 lines
Inspired by the x86 and s390 configs.
Signed-off-by Bastian Blank <[email protected]>Signature · 2 lines
You can't evaluate a man by logic alone. -- McCoy, "I, Mudd", stardate 4513.3arch/sparc/Kconfig +0
-0
arch/sparc/Kconfig line 12
Quoted 9 lines
arch/sparc/Kconfig +6
-0@@ -4,6 +4,13 @@ mainmenu "Linux/SPARC Kernel Configuration" +config 64BIT + bool "64-bit kernel" if ARCH = "sparc" + default ARCH = "sparc64" + help + Say yes to build a 64-bit kernel - formerly known as sparc64 + Say no to build a 32-bit kernel - formerly known as sparc
We should update this help escription with something remotely like this:
arch/sparc/Kconfig line 15
Quoted 3 lines
arch/sparc/Kconfig +3
-0+ SPARC is a family of RISC microprocessors designed and marketed by + Sun Microsystems, incorporated. They are very widely found in Sun + workstations and clones.
Just a raw copy from the (always hidden) help text for SPARC32.
Sam
From: Sam Ravnborg <[email protected]>
Date: Fri, 2 Jan 2009 09:04:20 +0100
Quoted 10 lines · Bastian Blank
Review
Quoted 6 lines
(quoted diff) +6
-0+config 64BIT + bool "64-bit kernel" if ARCH = "sparc" + default ARCH = "sparc64" + help + Say yes to build a 64-bit kernel - formerly known as sparc64 + Say no to build a 32-bit kernel - formerly known as sparcWe should update this help escription with something remotely like this:
Quoted 5 lines
Review
Quoted 3 lines
(quoted diff) +3
-0+ SPARC is a family of RISC microprocessors designed and marketed by + Sun Microsystems, incorporated. They are very widely found in Sun + workstations and clones.Just a raw copy from the (always hidden) help text for SPARC32.
I've made this adjustment and commited this change as follows below.
Thanks everyone.
sparc: Use 64BIT config entry
Use 64BIT config entry to distinguish between 32 and 64bit builds instead of relying on the ARCH setting. Using sparc64 as ARCH still forces 64BIT on.
Inspired by the x86 and s390 configs.
[ Integrated CONFIG_64BIT help text suggestions from Sam -DaveM ]
--- arch/sparc/Kconfig | 29 +++++++++++++---------------- 1 files changed, 13 insertions(+), 16 deletions(-)
arch/sparc/Kconfig +13 -16
@@ -4,6 +4,17 @@ mainmenu "Linux/SPARC Kernel Configuration" +config 64BIT + bool "64-bit kernel" if ARCH = "sparc" + default ARCH = "sparc64" + help + SPARC is a family of RISC microprocessors designed and marketed by + Sun Microsystems, incorporated. They are very widely found in Sun + workstations and clones. + + Say yes to build a 64-bit kernel - formerly known as sparc64 + Say no to build a 32-bit kernel - formerly known as sparc + config SPARC bool default y
@@ -15,22 +26,11 @@ config SPARC select RTC_CLASS select RTC_DRV_M48T59 -# Identify this as a Sparc32 build config SPARC32 - bool - default y if ARCH = "sparc" - help - SPARC is a family of RISC microprocessors designed and marketed by - Sun Microsystems, incorporated. They are very widely found in Sun - workstations and clones. This port covers the original 32-bit SPARC; - it is old and stable and usually considered one of the "big three" - along with the Intel and Alpha ports. The UltraLinux project - maintains both the SPARC32 and SPARC64 ports; its web page is - available at <http://www.ultralinux.org/>. + def_bool !64BIT config SPARC64 - bool - default y if ARCH = "sparc64" + def_bool 64BIT select ARCH_SUPPORTS_MSI select HAVE_FUNCTION_TRACER select HAVE_KRETPROBES
@@ -53,9 +53,6 @@ config BITS default 32 if SPARC32 default 64 if SPARC64 -config 64BIT - def_bool y if SPARC64 - config GENERIC_TIME bool default y if SPARC64
Signature · 1 line
1.6.1.15.g159c88