rt2x00: Fix radio LED type check
PATCH 1/1 rt2x00: Fix radio LED type check
Since commit 9a95dba32735534bda59def40c747bf606fedf05 "rt2x00: Fix LED state handling", rt2x00leds_led_radio wrongly checks that the LED type is LED_TYPE_ASSOC. This patch makes it check for LED_TYPE_RADIO once again.
--- drivers/net/wireless/rt2x00/rt2x00leds.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/wireless/rt2x00/rt2x00leds.c +1 -1
@@ -97,7 +97,7 @@ void rt2x00leds_led_assoc(struct rt2x00_dev *rt2x00dev, bool enabled)void rt2x00leds_led_radio (struct rt2x00_dev *rt2x00dev,bool enabled) { -if (rt2x00dev->led_radio.type ==LED_TYPE_ASSOC ) +if (rt2x00dev->led_radio.type ==LED_TYPE_RADIO )rt2x00led_led_simple (&rt2x00dev->led_radio, enabled); }
Signature · 1 line
1.5.6.5
Quoted 6 lines · Andrew Price
Since commit
9a95dba32735534bda59def40c747bf606fedf05"rt2x00: Fix LED state handling",rt2x00leds_led_radiowrongly checks that the LED type isLED_TYPE_ASSOC. This patch makes it check forLED_TYPE_RADIOonce again.Signed-off-by Andrew Price <[email protected]>
Good catch. Thanks.
Quoted 25 lines
--- drivers/net/wireless/rt2x00/rt2x00leds.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/net/wireless/rt2x00/rt2x00leds.c +1
-2@@ -97,7 +97,7 @@ void rt2x00leds_led_assoc(struct rt2x00_dev *rt2x00dev, bool enabled)void rt2x00leds_led_radio (struct rt2x00_dev *rt2x00dev,bool enabled) { -if (rt2x00dev->led_radio.type ==LED_TYPE_ASSOC ) +if (rt2x00dev->led_radio.type ==LED_TYPE_RADIO )rt2x00led_led_simple (&rt2x00dev->led_radio, enabled); } --1.5.6.5
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Ivo,
Quoted 10 lines
Quoted 6 lines
Since commit
9a95dba32735534bda59def40c747bf606fedf05"rt2x00: Fix LED state handling",rt2x00leds_led_radiowrongly checks that the LED type isLED_TYPE_ASSOC. This patch makes it check forLED_TYPE_RADIOonce again.Signed-off-by Andrew Price <[email protected]>Good catch. Thanks.
Signed-off-by Ivo van Doorn <[email protected]>
small comment from my side here. Signed-off-by is only suppose to be used if you pick up the patch and then send it to John by yourself. If you just wanna indicate that it is fine for John to pick up this patch, then it should be an Acked-by: line.
The Signed-off-by should indicate the steps (aka persons) this patch when through until it reached Linus. This doesn't include people testing or acknowledging a patch.
Regards
Marcel
Quoted 13 lines · Marcel Holtmann
Hi Ivo,
Quoted 10 lines
Quoted 6 lines
Since commit
9a95dba32735534bda59def40c747bf606fedf05"rt2x00: Fix LED state handling",rt2x00leds_led_radiowrongly checks that the LED type isLED_TYPE_ASSOC. This patch makes it check forLED_TYPE_RADIOonce again.Signed-off-by Andrew Price <[email protected]>Good catch. Thanks.
Signed-off-by Ivo van Doorn <[email protected]>
Quoted 8 lines
small comment from my side here. Signed-off-by is only suppose to be used if you pick up the patch and then send it to John by yourself. If you just wanna indicate that it is fine for John to pick up this patch, then it should be an Acked-by: line.
The Signed-off-by should indicate the steps (aka persons) this patch when through until it reached Linus. This doesn't include people testing or acknowledging a patch.
Ok, feel free to change it to a Acked-by then. ;)
Ivo
Quoted 11 lines · Ivo Van Doorn
Quoted 6 lines · Andrew Price
Since commit
9a95dba32735534bda59def40c747bf606fedf05"rt2x00: Fix LED state handling",rt2x00leds_led_radiowrongly checks that the LED type isLED_TYPE_ASSOC. This patch makes it check forLED_TYPE_RADIOonce again.Signed-off-by Andrew Price <[email protected]>Good catch. Thanks.
Acked-by Ivo van Doorn <[email protected]>
Thanks for that. I'm a little new to this so I'm not sure what happens now. Will the patch go into John's tree and make it's way to Linus' tree (where the bug is) or should I send it directly to Linus/LKML with Ivo's Acked-by line?
Regards,
--
Andrew Price
Quoted 9 lines · Andrew Price
Quoted 8 lines · Ivo Van Doorn
Quoted 6 lines · Andrew Price
Since commit
9a95dba32735534bda59def40c747bf606fedf05"rt2x00: Fix LED state handling",rt2x00leds_led_radiowrongly checks that the LED type isLED_TYPE_ASSOC. This patch makes it check forLED_TYPE_RADIOonce again.Signed-off-by Andrew Price <[email protected]>
Quoted 7 lines
Quoted 3 lines
Good catch. Thanks.
Acked-by Ivo van Doorn <[email protected]>Thanks for that. I'm a little new to this so I'm not sure what happens now. Will the patch go into John's tree and make it's way to Linus' tree (where the bug is) or should I send it directly to Linus/LKML with Ivo's Acked-by line?
I had added John to the CC list in my initial reply to notify him of the patch, he will pick up the patch and make sure it will make its way to Linus. :)
Ivo
Quoted 9 lines · Andrew Price
Quoted 8 lines · Ivo Van Doorn
Quoted 6 lines · Andrew Price
Since commit
9a95dba32735534bda59def40c747bf606fedf05"rt2x00: Fix LED state handling",rt2x00leds_led_radiowrongly checks that the LED type isLED_TYPE_ASSOC. This patch makes it check forLED_TYPE_RADIOonce again.Signed-off-by Andrew Price <[email protected]>
Quoted 7 lines
Quoted 3 lines
Good catch. Thanks.
Acked-by Ivo van Doorn <[email protected]>Thanks for that. I'm a little new to this so I'm not sure what happens now. Will the patch go into John's tree and make it's way to Linus' tree (where the bug is) or should I send it directly to Linus/LKML with Ivo's Acked-by line?
I've got it, thanks.
John
Signature · 2 lines
John W. Linville Linux should be at the core [email protected] of your literate lifestyle.