Skip to contentSkip to conversation

Series short description

PATCH In review Alan Cox 2 participants 4 messages Jan 2, 2009 Char and misc drivers

lore
Share & tools
lore

Alan Cox

author
#0 lore raw

cover Series short description

Various i8k updates got lost but have now been chased up, signed off and this adds them to the tree.
---

Andy Spencer (1):
i8k: Enable i8k on Dell Precision Systems

Federico Heinz (1):
i8k: Add Dell Vostro systems

 drivers/char/i8k.c |   16 +++++++++++++++-
 1 files changed, 15 insertions(+), 1 deletions(-)
author
#1 lore raw

PATCH 1/2 i8k: Enable i8k on Dell Precision Systems

From: Andy Spencer <[email protected]>

Patch to enable i8k on Dell Precisions.

---

 drivers/char/i8k.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
drivers/char/i8k.c +7 -0
index b60d425..099fc89 100644
@@ -485,6 +485,13 @@ static struct dmi_system_id __initdata i8k_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "MP061"),
 		},
 	},
+	{
+		.ident = "Dell Precision",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Precision"),
+		},
+	},
 	{ }
 };
 
author
#2 lore raw

PATCH 2/2 i8k: Add Dell Vostro systems

In reply to Alan Cox

From: Federico Heinz <[email protected]>

This trivial patch adds support for i8k on the new Dell Vostro models. I tested it on my Vostro 1400, and it works. It does print a warning when loading the module:

i8k: unable to get SMM BIOS version

But I couldn't figure out how to fix that. The module seems to work fine, anyway...

---

 drivers/char/i8k.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)
drivers/char/i8k.c +8 -1
index 099fc89..fc8cf7a 100644
@@ -492,7 +492,14 @@ static struct dmi_system_id __initdata i8k_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Precision"),
 		},
 	},
-	{ }
+	{
+		.ident = "Dell Vostro",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Vostro"),
+		},
+	},
+        { }
 };
 
 /*
#3 lore raw

Re: [PATCH 2/2] i8k: Add Dell Vostro systems

On Fri, 02 Jan 2009 16:19:23 +0000
Alan Cox <[email protected]> wrote:

Hi! I bet, it does not pass checkpatch (tabs to spaces clash) Sorry, can't send fixed patch.

Quoted 23 lines

From: Federico Heinz <[email protected]>

This trivial patch adds support for i8k on the new Dell Vostro models. I tested it on my Vostro 1400, and it works. It does print a warning when loading the module:

i8k: unable to get SMM BIOS version

But I couldn't figure out how to fix that. The module seems to work fine, anyway...

---

 drivers/char/i8k.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)
drivers/char/i8k.c +0 -0
index 099fc89..fc8cf7a 100644

...

drivers/char/i8k.c static struct dmi_system_id __initdata i8k_dmi_table[] = { · line 495

Quoted 1 line
drivers/char/i8k.c +0 -1
-	{ }

^^^^^^
This one
vvvvvvv

Quoted 2 lines

+ { }
};

Signature · 1 line
  Sergei