Resurrect IT8172 IDE controller driver
PATCH v5 1/1 Resurrect IT8172 IDE controller driver
Support for the IT8172 IDE controller was removed from the kernel sometime after 2.6.18. Support for the only boards that used the IT8172 was removed from the kernel after 2.6.18, as they had never compiled since 2.6.0. However, there are a couple of platforms that use this
chip: the PMC-Sierra Xiao Hu thin-client computer, which is no longer in production, and the Linksys NSS4000 Network Attached Storage box, which is based on the Xiao Hu board. I am attempting to add support for the Xiao Hu to the kernel, and this IT8172 IDE controller is the first bit of code in this effort.
This patch resurrects the IT8172 IDE controller code. I began with the 2.6.18 version of the it8172.c file, and have moved it forward so that it works with the latest version of the kernel. I have run this driver on a PMC-Sierra Xiao Hu board with the 2.6.28 kernel, and I have had no problems with it in my configuration. The attached patch applies cleanly against 2.6.28.
--- drivers/ide/Kconfig | 7 + drivers/ide/Makefile | 1 drivers/ide/it8172.c | 166 ++++++++++++++++++++++++++++++++++++++ include/linux/pci_ids.h | 1 4 files changed, 175 insertions(+)
Changes since version 4 of the patch:
- corrected location of comment re. timings array
- simplified timings array by making it one dimensional
- simplified setting of timings bit through use of the one dimensional array
drivers/ide/Kconfig +7 -0
@@ -524,6 +524,13 @@ config BLK_DEV_PIIX This allows the kernel to change PIO, DMA and UDMA speeds and to configure the chip to optimum performance. +config BLK_DEV_IT8172 + tristate "IT8172 IDE support" + select BLK_DEV_IDEDMA_PCI + help + This driver adds support for the IDE controller on the + IT8172 System Controller. + config BLK_DEV_IT8213 tristate "IT8213 IDE support" select BLK_DEV_IDEDMA_PCI
drivers/ide/Makefile +1 -0
@@ -46,6 +46,7 @@ obj-$(CONFIG_BLK_DEV_SC1200) += sc1200. obj-$(CONFIG_BLK_DEV_CY82C693) += cy82c693.o obj-$(CONFIG_BLK_DEV_DELKIN) += delkin_cb.o obj-$(CONFIG_BLK_DEV_HPT366) += hpt366.o +obj-$(CONFIG_BLK_DEV_IT8172) += it8172.o obj-$(CONFIG_BLK_DEV_IT8213) += it8213.o obj-$(CONFIG_BLK_DEV_IT821X) += it821x.o obj-$(CONFIG_BLK_DEV_JMICRON) += jmicron.o
drivers/ide/it8172.c +166 -0
166 lines not on this page · raw message
include/linux/pci_ids.h +1 -0
@@ -1658,6 +1658,7 @@#define PCI_VENDOR_ID_ROCKWELL 0x127A#define PCI_VENDOR_ID_ITE 0x1283 +#define PCI_DEVICE_ID_ITE_8172 0x8172#define PCI_DEVICE_ID_ITE_8211 0x8211#define PCI_DEVICE_ID_ITE_8212 0x8212#define PCI_DEVICE_ID_ITE_8213 0x8213
Bartlomiej Zolnierkiewicz
AppliedQuoted 17 lines · Shane McDonald
Support for the IT8172 IDE controller was removed from the kernel sometime after 2.6.18. Support for the only boards that used the IT8172 was removed from the kernel after 2.6.18, as they had never compiled since 2.6.0. However, there are a couple of platforms that use this
chip: the PMC-Sierra Xiao Hu thin-client computer, which is no longer in production, and the Linksys NSS4000 Network Attached Storage box, which is based on the Xiao Hu board. I am attempting to add support for the Xiao Hu to the kernel, and this IT8172 IDE controller is the first bit of code in this effort.This patch resurrects the IT8172 IDE controller code. I began with the 2.6.18 version of the
it8172.cfile, and have moved it forward so that it works with the latest version of the kernel. I have run this driver on a PMC-Sierra Xiao Hu board with the 2.6.28 kernel, and I have had no problems with it in my configuration. The attached patch applies cleanly against 2.6.28.
Quoted 2 lines
Signed-off-by Shane McDonald <[email protected]>Acked-by Sergei Shtylyov <[email protected]>
applied, thanks!
Hello.
Quoted 20 lines · Shane McDonald
Support for the IT8172 IDE controller was removed from the kernel sometime after 2.6.18. Support for the only boards that used the IT8172 was removed from the kernel after 2.6.18, as they had never compiled since 2.6.0. However, there are a couple of platforms that use this
chip: the PMC-Sierra Xiao Hu thin-client computer, which is no longer in production, and the Linksys NSS4000 Network Attached Storage box, which is based on the Xiao Hu board. I am attempting to add support for the Xiao Hu to the kernel, and this IT8172 IDE controller is the first bit of code in this effort.This patch resurrects the IT8172 IDE controller code. I began with the 2.6.18 version of the
it8172.cfile, and have moved it forward so that it works with the latest version of the kernel. I have run this driver on a PMC-Sierra Xiao Hu board with the 2.6.28 kernel, and I have had no problems with it in my configuration. The attached patch applies cleanly against 2.6.28.Signed-off-by Shane McDonald <[email protected]>Acked-by Sergei Shtylyov <[email protected]>
[...]
Quoted 48 lines
diff -uprN
a/drivers/ide/it8172.cb/drivers/ide/it8172.cdrivers/ide/it8172.c +43
-0@@ -0,0 +1,166 @@ +/* +* +* BRIEF MODULE DESCRIPTION +* IT8172 IDE controller support +* +* Copyright (C) 2000 MontaVista Software Inc. +* Copyright (C) 2008 Shane McDonald +* +* This program is free software; you can redistribute it and/or modify it +* under the terms of the GNU General Public License as published by the +* Free Software Foundation; either version 2 of the License, or (at your +* option) any later version. +* +* THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED +* WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF +* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN +* NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, +* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT +* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF +* USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON +* ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF +* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +* +* You should have received a copy of the GNU General Public License along +* with this program; if not, write to the Free Software Foundation, Inc., +* 675 Mass Ave, Cambridge, MA 02139, USA. +*/ + +#include <linux/module.h> +#include <linux/types.h> +#include <linux/kernel.h> +#include <linux/ioport.h> +#include <linux/pci.h> +#include <linux/ide.h> +#include <linux/init.h> + +#define DRV_NAME "IT8172" + +static void it8172_set_pio_mode (ide_drive_t *drive,const u8 pio) +{ +ide_hwif_t *hwif =HWIF (drive); +struct pci_dev *dev =to_pci_dev (hwif->dev);
drivers/ide/it8172.c line 53
Quoted 10 lines
drivers/ide/it8172.c +10
-0+u16 drive_enables; +u32 drive_timing; + +/* +* The highest value of DIOR/DIOW pulse width and recovery time +* that can be set in the IT8172 is 8 PCI clock cycles. As a result, +* it cannot be configured for PIO mode 0. This table sets these +* parameters to the maximum supported by the IT8172. +*/ +static const u8 timings[] = {0x3f ,0x3c ,0x1b ,0x12 ,0x0a };
The octal literals would fit this case better (3-bit field == octal
digit). Oh well... :-)
MBR, Sergei