xfstests: add test 199, bad_features2 correction
PATCH 1/1 xfstests: add test 199, bad_features2 correction
199 new file +65 -0
@@ -0,0 +1,65 @@ +#! /bin/sh +# FS QA Test No. 199 +# +# Check that a filesystem first mounted read-only and then remounted +# performs the features2 fixup properly. +# +#----------------------------------------------------------------------- +# Copyright (c) 2008 Christoph Hellwig. +#----------------------------------------------------------------------- +# +# creator [email protected] + +seq=`basename $0` +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! + +_cleanup() +{ + cd / + umount $SCRATCH_MNT >/dev/null 2>&1 +} +trap "_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common.rc +. ./common.filter + +# real QA test starts here +_supported_fs xfs +_supported_os Linux + +_require_scratch + +_scratch_mkfs_xfs >/dev/null 2>&1 + +# +# Print the current flags. Just a dummy so that the test breaks +# in an obvious way when the default feature flags changed in mkfs +# +echo "Default feature2 flags:" +xfs_db -x $SCRATCH_DEV -c 'sb' -c 'print features2' +xfs_db -x $SCRATCH_DEV -c 'sb' -c 'print bad_features2' + +# +# Now clear the normal flags +# +echo "Clearing features2:" +xfs_db -x $SCRATCH_DEV -c 'sb' -c 'write features2 0' + +# +# And print the flags after a mount ro and remount rw +_scratch_mount -o ro +_scratch_mount -o remount,rw +umount $SCRATCH_MNT +echo "Features 2 after mount ro and remount rw:" +xfs_db -x $SCRATCH_DEV -c 'sb' -c 'print features2' + +# success, all done +echo "*** done" +rm -f $seq.full +status=0
group +1 -0
@@ -300,3 +300,4 @@ 195 ioctl dump auto 196 quota auto 197 dir auto +199 mount auto
199.out new file +9 -0
@@ -0,0 +1,9 @@ +QA output created by 199 +Default feature2 flags: +features2 = 0x8 +bad_features2 = 0x8 +Clearing features2: +features2 = 0 +Features 2 after mount ro and remount rw: +features2 = 0x8 +*** done
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
199 line 5
Quoted 10 lines · Christoph Hellwig
Index: xfstests-dev/199
===================================================================199 new file +5
-0@@ -0,0 +1,65 @@ +#! /bin/sh +# FS QA Test No. 199 +# +# Check that a filesystem first mounted read-only and then remounted +# performs the features2 fixup properly.
Seems fine. Would it be worth adding a few more lines to also test that a simple rw mount (w/o going through ro first) also properly fixes it?
-Eric
Quoted 84 lines
199 new file +60
-0+# +#----------------------------------------------------------------------- +# Copyright (c) 2008 Christoph Hellwig. +#----------------------------------------------------------------------- +# +# creator [email protected] + +seq=`basename $0` +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! + +_cleanup() +{ + cd / + umount $SCRATCH_MNT >/dev/null 2>&1 +} +trap "_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common.rc +. ./common.filter + +# real QA test starts here +_supported_fs xfs +_supported_os Linux + +_require_scratch + +_scratch_mkfs_xfs >/dev/null 2>&1 + +# +# Print the current flags. Just a dummy so that the test breaks +# in an obvious way when the default feature flags changed in mkfs +# +echo "Default feature2 flags:" +xfs_db -x $SCRATCH_DEV -c 'sb' -c 'print features2' +xfs_db -x $SCRATCH_DEV -c 'sb' -c 'print bad_features2' + +# +# Now clear the normal flags +# +echo "Clearing features2:" +xfs_db -x $SCRATCH_DEV -c 'sb' -c 'write features2 0' + +# +# And print the flags after a mount ro and remount rw +_scratch_mount -o ro +_scratch_mount -o remount,rw +umount $SCRATCH_MNT +echo "Features 2 after mount ro and remount rw:" +xfs_db -x $SCRATCH_DEV -c 'sb' -c 'print features2' + +# success, all done +echo "*** done" +rm -f $seq.full +status=0Index: xfstests-dev/group
===================================================================group +1
-0@@ -300,3 +300,4 @@ 195 ioctl dump auto 196 quota auto 197 dir auto +199 mount autoIndex: xfstests-dev/199.out
===================================================================199.out new file +9
-0@@ -0,0 +1,9 @@ +QA output created by 199 +Default feature2 flags: +features2 = 0x8 +bad_features2 = 0x8 +Clearing features2: +features2 = 0 +Features 2 after mount ro and remount rw: +features2 = 0x8 +*** done
Quoted 5 lines
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 14 lines · Eric Sandeen
199 line 5
Quoted 10 lines · Christoph Hellwig
Index: xfstests-dev/199
===================================================================199 new file +5
-0@@ -0,0 +1,65 @@ +#! /bin/sh +# FS QA Test No. 199 +# +# Check that a filesystem first mounted read-only and then remounted +# performs the features2 fixup properly.Seems fine. Would it be worth adding a few more lines to also test that a simple rw mount (w/o going through ro first) also properly fixes it?
I was under the impression that we already tested that somewhere else, but it seems like we don't. Yes, I'll add it, that's a good one.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs