Skip to contentSkip to conversation

bootchart: improve output based on Dave Jones' feedback

PATCH In review Arjan van de Ven 3 participants 5 messages Jan 4, 2009 – Jan 7, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bootchart: improve output based on Dave Jones' feedback

Subject: bootchart: improve output based on Dave Jones' feedback
From: Arjan van de Ven <[email protected]>

Dave Jones, in his blog, had some feedback about the bootchart script:
Primarily his complaint was that shorter delays weren't visualized.

The reason for that was that too small delays will have their labels mixed up in the graph in an unreadable mess.

This patch has a fix for this; for one, it makes the output wider, so more will fit.
The second part is that smaller delays are now shown with a much smaller font for the label; while this isn't per se readable at a 1:1 zoom, at least you can zoom in with most SVG viewing applications and see what it is you are looking at.

scripts/bootgraph.pl +11 -5
index f0af9aa..c6a01d8 100644
@@ -88,7 +89,7 @@ END
 }
 
 print "<?xml version=\"1.0\" standalone=\"no\"?> \n";
-print "<svg width=\"1000\" height=\"100%\" version=\"1.1\" xmlns=\"http://www.w3.org/2000/svg\">\n";
+print "<svg width=\"2000\" height=\"100%\" version=\"1.1\" xmlns=\"http://www.w3.org/2000/svg\">\n";
 
 my @styles;
 
@@ -105,8 +106,9 @@ $styles[9] = "fill:rgb(255,255,128);fill-opacity:0.5;stroke-width:1;stroke:rgb(0
 $styles[10] = "fill:rgb(255,128,255);fill-opacity:0.5;stroke-width:1;stroke:rgb(0,0,0)";
 $styles[11] = "fill:rgb(128,255,255);fill-opacity:0.5;stroke-width:1;stroke:rgb(0,0,0)";
 
-my $mult = 950.0 / ($maxtime - $firsttime);
-my $threshold = ($maxtime - $firsttime) / 60.0;
+my $mult = 1950.0 / ($maxtime - $firsttime);
+my $threshold2 = ($maxtime - $firsttime) / 120.0;
+my $threshold = $threshold2/10;
 my $stylecounter = 0;
 my %rows;
 my $rowscount = 1;
@@ -116,7 +118,7 @@ foreach my $key (@initcalls) {
 	my $duration = $end{$key} - $start{$key};
 
 	if ($duration >= $threshold) {
-		my ($s, $s2, $e, $w, $y, $y2, $style);
+		my ($s, $s2, $s3, $e, $w, $y, $y2, $style);
 		my $pid = $pids{$key};
 
 		if (!defined($rows{$pid})) {
@@ -125,6 +127,7 @@ foreach my $key (@initcalls) {
 		}
 		$s = ($start{$key} - $firsttime) * $mult;
 		$s2 = $s + 6;
+		$s3 = $s + 1;
 		$e = ($end{$key} - $firsttime) * $mult;
 		$w = $e - $s;
 
@@ -138,7 +141,11 @@ foreach my $key (@initcalls) {
 		};
 
 		print "<rect x=\"$s\" width=\"$w\" y=\"$y\" height=\"145\" style=\"$style\"/>\n";
-		print "<text transform=\"translate($s2,$y2) rotate(90)\">$key</text>\n";
+		if ($duration >= $threshold2) {
+			print "<text transform=\"translate($s2,$y2) rotate(90)\">$key</text>\n";
+		} else {
+			print "<text transform=\"translate($s3,$y2) rotate(90)\" font-size=\"3pt\">$key</text>\n";
+		}
 	}
 }
 
Signature · 7 lines
1.6.0.6


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
#1 lore raw

2009/1/4 Arjan van de Ven <[email protected]>:

Quoted 10 lines

Subject: bootchart: improve output based on Dave Jones' feedback
From: Arjan van de Ven <[email protected]>

Dave Jones, in his blog, had some feedback about the bootchart script:
Primarily his complaint was that shorter delays weren't visualized.

The reason for that was that too small delays will have their labels mixed up in the graph in an unreadable mess.

Quoted 8 lines

This patch has a fix for this; for one, it makes the output wider, so more will fit.
The second part is that smaller delays are now shown with a much smaller font for the label; while this isn't per se readable at a 1:1 zoom, at least you can zoom in with most SVG viewing applications and see what it is you are looking at.

BTW, it looks like the async initcall feature has not been merged upstream, even not in tip/master. Was it too
risky, not enough tested or something?

#2 lore raw
Quoted 4 lines · On Sun, 4 Jan 2009 16:36:18 +0100 "Frédéric Weisbecker" <[email protected]>…

BTW, it looks like the async initcall feature has not been merged upstream, even not in tip/master. Was it too
risky, not enough tested or something?

Linus didn't quite like how it was done (to put it mildly).

I've redone it this weekend (and am now cleaning the code up for posting later today hopefully)...
Linus was right (as usual); the new way is much better both in terms of code cleanness and in terms of faster boot.

Signature · 3 lines
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
#3 lore raw

2009/1/4 Arjan van de Ven <[email protected]>:

Quoted 4 lines
Quoted 1 line · On Sun, 4 Jan 2009 16:36:18 +0100 "Frédéric Weisbecker" <[email protected]>…
Quoted 8 lines
Quoted 3 lines

BTW, it looks like the async initcall feature has not been merged upstream, even not in tip/master. Was it too
risky, not enough tested or something?

Linus didn't quite like how it was done (to put it mildly).

I've redone it this weekend (and am now cleaning the code up for posting later today hopefully)...

So I will wait for your patches :-)
Since you are involved again in fastboot, perhaps you will use the boot tracer which now traces
the sched events. And I'm sure this sched tracing can be improved for your needs or anything.
Don't hesitate to report any feedbacks.

Thanks.

Quoted 2 lines

Linus was right (as usual); the new way is much better both in terms of code cleanness and in terms of faster boot.

#4 lore raw
In reply to Arjan van de Ven
Quoted 10 lines · Arjan van de Ven

Subject: bootchart: improve output based on Dave Jones' feedback
From: Arjan van de Ven <[email protected]>

Dave Jones, in his blog, had some feedback about the bootchart script:
Primarily his complaint was that shorter delays weren't visualized.

The reason for that was that too small delays will have their labels mixed up in the graph in an unreadable mess.

Quoted 8 lines

This patch has a fix for this; for one, it makes the output wider, so more will fit.
The second part is that smaller delays are now shown with a much smaller font for the label; while this isn't per se readable at a 1:1 zoom, at least you can zoom in with most SVG viewing applications and see what it is you are looking at.

Applied to kbuild-fixes.git

Sam