rt2x00: Fix TX short preamble detection

PATCH New Ivo van Doorn 1 participant 1 message Jan 4, 2009 Networking drivers (wireless)

Share & tools

Ivo van Doorn

author

2009-01-04 16:33 UTC #0 lore raw

PATCH 1/1 rt2x00: Fix TX short preamble detection

The short preamble mode was not correctly detected during TX, rt2x00 used the rate->hw_value_short field but mac80211 is not using this field that way.
Instead the flag IEEE80211_TX_RC_USE_SHORT_PREAMBLE should be used to determine if the frame should be send out using short preamble or not.

Signed-off-by Ivo van Doorn <[email protected]>

---
 drivers/net/wireless/rt2x00/rt2x00dev.c   |    8 +++-----
 drivers/net/wireless/rt2x00/rt2x00lib.h   |   11 -----------
 drivers/net/wireless/rt2x00/rt2x00queue.c |    2 +-
 3 files changed, 4 insertions(+), 17 deletions(-)

drivers/net/wireless/rt2x00/rt2x00dev.c +3 -5

index ab8aa97..12331b1 100644
@@ -523,13 +523,11 @@ static void rt2x00lib_rate(struct ieee80211_rate *entry,
 {
 	entry->flags = 0;
 	entry->bitrate = rate->bitrate;
-	entry->hw_value = rt2x00_create_rate_hw_value(index, 0);
-	entry->hw_value_short = entry->hw_value;
+	entry->hw_value =index;
+	entry->hw_value_short = index;
 
-	if (rate->flags & DEV_RATE_SHORT_PREAMBLE) {
+	if (rate->flags & DEV_RATE_SHORT_PREAMBLE)
 		entry->flags |= IEEE80211_RATE_SHORT_PREAMBLE;
-		entry->hw_value_short |= rt2x00_create_rate_hw_value(index, 1);
-	}
 }
 
 static int rt2x00lib_probe_hw_modes(struct rt2x00_dev *rt2x00dev,

drivers/net/wireless/rt2x00/rt2x00lib.h +0 ~~-11~~

index 8381985..92918f3 100644
@@ -52,22 +52,11 @@ struct rt2x00_rate {
 
 extern const struct rt2x00_rate rt2x00_supported_rates[12];
 
-static inline u16 rt2x00_create_rate_hw_value(const u16 index,
-					      const u16 short_preamble)
-{
-	return (short_preamble << 8) | (index & 0xff);
-}
-
 static inline const struct rt2x00_rate *rt2x00_get_rate(const u16 hw_value)
 {
 	return &rt2x00_supported_rates[hw_value & 0xff];
 }
 
-static inline int rt2x00_get_rate_preamble(const u16 hw_value)
-{
-	return (hw_value & 0xff00);
-}
-
 /*
  * Radio control handlers.
  */

drivers/net/wireless/rt2x00/rt2x00queue.c +1 -1

index fc28e23..c1e5a05 100644
@@ -232,7 +232,7 @@ static void rt2x00queue_create_tx_descriptor_plcp(struct queue_entry *entry,
 		 * When preamble is enabled we should set the
 		 * preamble bit for the signal.
 		 */
-		if (rt2x00_get_rate_preamble(rate->hw_value))
+		if (rate->flags & IEEE80211_TX_RC_USE_SHORT_PREAMBLE)
 			txdesc->signal |= 0x08;
 	}
 }

Signature · 1 line

1.5.6.1