Skip to contentSkip to conversation

usb : OMAP3 : Enable Mentor USB OTG module interface clock

PATCH New Thomas Abraham 5 participants 7 messages Jan 4, 2009 – Jan 21, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 2/4 usb : OMAP3 : Enable Mentor USB OTG module interface clock

This patch enables Mentor USB OTG module interface clock.

---
 cpu/arm_cortexa8/omap3/clock.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
cpu/arm_cortexa8/omap3/clock.c +3 -0
index 8ac31be..d6cf27d 100644
@@ -376,6 +376,9 @@ void per_clocks_enable(void)
 	sr32(&prcm_base->iclken_cam, 0, 32, ICK_CAM_ON);
 	sr32(&prcm_base->fclken_per, 0, 32, FCK_PER_ON);
 	sr32(&prcm_base->iclken_per, 0, 32, ICK_PER_ON);
+#ifdef CONFIG_USB_OMAP3530
+	sr32(&prcm_base->iclken1_core, 4, 1, 0x1);
+#endif
 
 	sdelay(1000);
 }
Signature · 1 line
1.5.6
#1 lore raw

PATCH 2/4 usb : OMAP3 : Enable Mentor USB OTG module interface clock

Hello Thomas,

2009/1/4 Thomas Abraham <[email protected]>:

Quoted 8 lines

This patch enables Mentor USB OTG module interface clock.

---
 cpu/arm_cortexa8/omap3/clock.c |    3 +++

This file does not exist in my u-boot-usb tree yet, so there is a dependency missing here in your list of patch dependencies.

Kind regards,

Remy

Quoted 24 lines
 1 files changed, 3 insertions(+), 0 deletions(-)
cpu/arm_cortexa8/omap3/clock.c +3 -1
index 8ac31be..d6cf27d 100644
@@ -376,6 +376,9 @@ void per_clocks_enable(void)
       sr32(&prcm_base->iclken_cam, 0, 32, ICK_CAM_ON);
       sr32(&prcm_base->fclken_per, 0, 32, FCK_PER_ON);
       sr32(&prcm_base->iclken_per, 0, 32, ICK_PER_ON);
+#ifdef CONFIG_USB_OMAP3530
+       sr32(&prcm_base->iclken1_core, 4, 1, 0x1);
+#endif
 
       sdelay(1000);
 }
--

1.5.6

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#2 lore raw

PATCH 2/4 usb : OMAP3 : Enable Mentor USB OTG module interface clock

Remy,

Quoted 6 lines

-----Original Message-----
From: l.pinguin at gmail.com [mailto:l.pinguin at gmail.com] On Behalf Of Remy Bohmer
Sent: Monday, January 05, 2009 1:52 AM
Subject: Re: [U-Boot] [PATCH 2/4] usb : OMAP3 : Enable Mentor USB OTG module interface clock

<snip>

Quoted 4 lines
Quoted 1 line
 cpu/arm_cortexa8/omap3/clock.c |    3 +++

This file does not exist in my u-boot-usb tree yet, so there is a dependency missing here in your list of patch dependencies.

I missed to list the dependency of the OMAP3 USB patches on the v6 OMAP3 patches. The OMAP3 USB patches were generated against http://git.gitorious.org/u-boot-omap3/mainline.git
and omap3-dev branch.

Thanks,
Thomas.

Quoted 4 lines

Kind regards,

Remy

<snip>

#3 lore raw

PATCH 2/4 usb : OMAP3 : Enable Mentor USB OTG module interface clock

Hello Thomas,

Quoted 8 lines
Quoted 3 lines
Quoted 1 line
 cpu/arm_cortexa8/omap3/clock.c |    3 +++

This file does not exist in my u-boot-usb tree yet, so there is a dependency missing here in your list of patch dependencies.

I missed to list the dependency of the OMAP3 USB patches on the v6 OMAP3 patches. The OMAP3 USB patches were generated against http://git.gitorious.org/u-boot-omap3/mainline.git
and omap3-dev branch.

Okay, in that case, what do you expect from me to do with these patches, related to the u-boot-usb tree?
I would suggest to mainline the OMAP3 v6 patches first, It is not up to the u-boot-USB tree to integrate new ARM boards/cpus, unless the ARM maintainer integrated and approved them in his tree. So, I am ignoring these OMAP3-USB patches for now.

Kind Regards,

Remy

#4 lore raw

PATCH 2/4 usb : OMAP3 : Enable Mentor USB OTG module interface clock

Quoted 6 lines · Remy Bohmer

Hello Thomas,

Quoted 4 lines
Quoted 3 lines
Quoted 1 line
 cpu/arm_cortexa8/omap3/clock.c |    3 +++

This file does not exist in my u-boot-usb tree yet, so there is a dependency missing here in your list of patch dependencies.

Quoted 7 lines
Quoted 4 lines

I missed to list the dependency of the OMAP3 USB patches on the v6 OMAP3 patches. The OMAP3 USB patches were generated against http://git.gitorious.org/u-boot-omap3/mainline.git
and omap3-dev branch.

Okay, in that case, what do you expect from me to do with these patches, related to the u-boot-usb tree?

please just review them and if you are ok ack them and I'll merge them when processing the OMAP3 patch seriers

Best Regards,
J.

#5 lore raw

PATCH 2/4 usb : OMAP3 : Enable Mentor USB OTG module interface clock

Hello Jean-Chistophe,

Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
Quoted 2 lines

This file does not exist in my u-boot-usb tree yet, so there is a dependency missing here in your list of patch dependencies.

I missed to list the dependency of the OMAP3 USB patches on the v6 OMAP3 patches. The OMAP3 USB patches were generated against http://git.gitorious.org/u-boot-omap3/mainline.git
and omap3-dev branch.

Quoted 4 lines
Quoted 2 lines

Okay, in that case, what do you expect from me to do with these patches, related to the u-boot-usb tree?

please just review them and if you are ok ack them and I'll merge them when processing the OMAP3 patch seriers

That is the complicated part, it depends also on patches I have in my tree, which are changing that fast (fix on fix, version on version), that I prefer to push them to the next release, when hopefully things are stabilized.

So, I have no problems with the separation Thomas has made to push the USB patches to the USB tree, and the basic board patches to you, but then I have to wait until you have the boards integrated. When the patches are in your tree, I believe we would not have merge conflicts in Wolfgangs tree, if my tree is pulled later than yours.
I think it would get really complicated if you are going to pull the other (unstable) USB patches also in your tree..

Kind Regards,

Remy

#6 lore raw

PATCH 2/4 usb : OMAP3 : Enable Mentor USB OTG module interface clock

Dear Remy,

Quoted 3 lines · In message <[email protected]> you…

So, I have no problems with the separation Thomas has made to push the USB patches to the USB tree, and the basic board patches to you, but

Actually this is the correct thing to do.

Quoted 1 line

then I have to wait until you have the boards integrated. When the

Correct. First the generic support has to go in through the ARM tree, and then you can apply the USB related patches on top of that.

Quoted 2 lines

patches are in your tree, I believe we would not have merge conflicts in Wolfgangs tree, if my tree is pulled later than yours.

Actually the sequence should be that the ARM tree gets merged into mainline first, then you update your USB repository from mainline (thus getting all the new ARM stuff, too), then you can apply the USB patches.

Quoted 2 lines

I think it would get really complicated if you are going to pull the other (unstable) USB patches also in your tree..

This is something that I definitely do not want to see.

Jean-Chistophe, please do *NOT* pull any USB (or other non-ARM) patches into the ARM repo.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There's another way to survive.  Mutual trust -- and help.
	-- Kirk, "Day of the Dove", stardate unknown