Skip to contentSkip to conversation

ide: can't use SSD/non-rotational queue flag for all CFA devices

PATCH In review Bartlomiej Zolnierkiewicz 2 participants 3 messages Jan 5, 2009 – Jan 6, 2009 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ide: can't use SSD/non-rotational queue flag for all CFA devices

From: Bartlomiej Zolnierkiewicz <[email protected]>
Subject: [PATCH] ide: can't use SSD/non-rotational queue flag for all CFA devices

Some rotating disks also present themselves as CFA devices.

---
 drivers/ide/ide-disk.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ide/ide-disk.c +1 -1
Index: b/drivers/ide/ide-disk.c
===================================================================
@@ -633,7 +633,7 @@ static void ide_disk_setup(ide_drive_t *
 	printk(KERN_INFO "%s: max request size: %dKiB\n", drive->name,
 		q->max_sectors / 2);
 
-	if (ata_id_is_ssd(id) || ata_id_is_cfa(id))
+	if (ata_id_is_ssd(id))
 		queue_flag_set_unlocked(QUEUE_FLAG_NONROT, q);
 
 	/* calculate drive capacity, and select LBA if possible */

Acked-by on v1 1/1
#1 lore raw

Hello.

Quoted 5 lines · Bartlomiej Zolnierkiewicz

Some rotating disks also present themselves as CFA devices.

Quoted 13 lines

Index: b/drivers/ide/ide-disk.c
===================================================================

drivers/ide/ide-disk.c +1 -1
@@ -633,7 +633,7 @@ static void ide_disk_setup(ide_drive_t *
 	printk(KERN_INFO "%s: max request size: %dKiB\n", drive->name,
 		q->max_sectors / 2);
 
-	if (ata_id_is_ssd(id) || ata_id_is_cfa(id))
+	if (ata_id_is_ssd(id))
 		queue_flag_set_unlocked(QUEUE_FLAG_NONROT, q);
 
 	/* calculate drive capacity, and select LBA if possible */
Quoted 1 line

N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±‰×¢žØ^n‡r¡ö¦zË�ëh™¨è­Ú&¢ø®G«�éh®(­éšŽŠÝ¢j"�ú¶m§ÿï�êäz¹Þ–Šàþf£¢·hšˆ§~ˆmml==

Hm, why your Kmail base64-encodes plain English messages and adds this kind of binary crap?

MBR, Sergei

#2 lore raw
Quoted 24 lines · Sergei Shtylyov

Hello.

Quoted 5 lines · Bartlomiej Zolnierkiewicz

Some rotating disks also present themselves as CFA devices.

Quoted 12 lines

Index: b/drivers/ide/ide-disk.c
===================================================================

drivers/ide/ide-disk.c +1 -1
@@ -633,7 +633,7 @@ static void ide_disk_setup(ide_drive_t *
 	printk(KERN_INFO "%s: max request size: %dKiB\n", drive->name,
 		q->max_sectors / 2);
 
-	if (ata_id_is_ssd(id) || ata_id_is_cfa(id))
+	if (ata_id_is_ssd(id))
 		queue_flag_set_unlocked(QUEUE_FLAG_NONROT, q);
 
Quoted 5 lines
Quoted 2 lines
drivers/ide/ide-disk.c +0 -0
 	/* calculate drive capacity, and select LBA if possible */

N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±‰×¢žØ^n‡r¡ö¦zË�ëh™¨è­Ú&¢ø®G«�éh®(­éšŽŠÝ¢j"�ú¶m§ÿï�êäz¹Þ–Šàþf£¢·hšˆ§~ˆmml==

Hm, why your Kmail base64-encodes plain English messages and adds this kind of binary crap?

Huh? Haven't you heard about the latest trend of inserting hidden data into your mails? All the cool dudes are doing it nowadays... 8-)

Now seriously... I would love to know the answer to your question myself.

[ After distro upgrade I noticed that new KMail's version started adding
a non-ascii character at the end of inserted file (when composing message and using "Message" -> "Insert File"). The workaround is to remove the character manually but I sometimes forget about it... ]

Thanks,
Bart