V3 of the async function call patches
cover V3 of the async function call patches
version 3 of the async function call patches
* Dropped the ACPI part; it broke i surprising ways; needs a rethink (working with Len and co on that)
* Included asynchronous delete()
There is still no integration with the out of tree slow-work patch; the slow-work patch does really weird things with refcounts that make it really specific to cachefs and, frankly, I think it's a rather weird design.
The overlap is maybe 200 lines of code at most, of which 100+ would need to be added just to deal with the various weirdnesses. I really don't think this is a good idea or a fair requirement on the async function call patch series.
The following changes since commit 8903709b054a8dafe4e8c6d9a6444034d7aba36f:
Harvey Harrison (1):
xtensa: introduce swab.h
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/arjan/linux-2.6-async.git master
Arjan van de Ven (7):
async: Asynchronous function calls to speed up kernel boot
fastboot: make scsi probes asynchronous
fastboot: make the libata port scan asynchronous
fastboot: Make libata initialization even more async
async: make the final inode deletion an asynchronous event
bootchart: improve output based on Dave Jones' feedback
async: don't do the initcall stuff post boot
drivers/ata/libata-core.c | 96 +++++++------- drivers/scsi/scsi_scan.c | 3 + drivers/scsi/sd.c | 109 ++++++++++------ fs/inode.c | 20 ++- fs/super.c | 10 ++ include/linux/async.h | 25 ++++ include/linux/fs.h | 5 + init/do_mounts.c | 2 + init/main.c | 5 +- kernel/Makefile | 3 +- kernel/async.c | 321 +++++++++++++++++++++++++++++++++++++++++++++ kernel/irq/autoprobe.c | 5 + kernel/module.c | 2 + scripts/bootgraph.pl | 16 ++- 14 files changed, 521 insertions(+), 101 deletions(-) create mode 100644 include/linux/async.h create mode 100644 kernel/async.c
Signature · 3 lines
Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
PATCH 1/7 async: Asynchronous function calls to speed up kernel boot
Quoted 1 line
From
22a9d645677feefd402befd02edd59b122289ef1Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <[email protected]>
Date: Wed, 7 Jan 2009 08:45:46 -0800
Subject: [PATCH] async: Asynchronous function calls to speed up kernel boot
Right now, most of the kernel boot is strictly synchronous, such that various hardware delays are done sequentially.
In order to make the kernel boot faster, this patch introduces infrastructure to allow doing some of the initialization steps asynchronously, which will hide significant portions of the hardware delays in practice.
In order to not change device order and other similar observables, this patch does NOT do full parallel initialization.
Rather, it operates more in the way an out of order CPU does; the work may be done out of order and asynchronous, but the observable effects (instruction retiring for the CPU) are still done in the original sequence.
--- include/linux/async.h | 25 ++++ init/do_mounts.c | 2 + init/main.c | 5 +- kernel/Makefile | 3 +- kernel/async.c | 321 ++++++++++++++++++++++++++++++++++++++++++++++++ kernel/irq/autoprobe.c | 5 + kernel/module.c | 2 + 7 files changed, 361 insertions(+), 2 deletions(-) create mode 100644 include/linux/async.h create mode 100644 kernel/async.c
include/linux/async.h new file +25 -0
@@ -0,0 +1,25 @@ +/* +* async.h: Asynchronous function calls for boot performance +* +* (C) Copyright 2009 Intel Corporation +* Author: Arjan van de Ven <[email protected]> +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License +* as published by the Free Software Foundation; version 2 +* of the License. +*/ + +#include <linux/types.h> +#include <linux/list.h> + +typedef u64 async_cookie_t ; +typedef void (async_func_ptr ) (void *data,async_cookie_t cookie); + +extern async_cookie_t async_schedule (async_func_ptr *ptr,void *data); +extern async_cookie_t async_schedule_special (async_func_ptr *ptr,void *data,struct list_head *list); +extern void async_synchronize_full (void ); +extern void async_synchronize_full_special (struct list_head *list); +extern void async_synchronize_cookie (async_cookie_t cookie); +extern void async_synchronize_cookie_special (async_cookie_t cookie,struct list_head *list); +
init/do_mounts.c +2 -0
@@ -13,6 +13,7 @@#include <linux/init.h> #include <linux/fs.h> #include <linux/initrd.h> +#include <linux/async.h> #include <linux/nfs_fs.h> #include <linux/nfs_fs_sb.h>
@@ -372,6 +373,7 @@ void __init prepare_namespace(void)/* wait for the known devices to complete their probing */ while (driver_probe_done () !=0 )msleep (100 ); +async_synchronize_full ();md_run_setup ();
init/main.c +4 -1
@@ -62,6 +62,7 @@#include <linux/signal.h> #include <linux/idr.h> #include <linux/ftrace.h> +#include <linux/async.h> #include <trace/boot.h> #include <asm/io.h>
@@ -684,7 +685,7 @@ asmlinkage void __init start_kernel(void)rest_init (); } -static int initcall_debug; +int initcall_debug;core_param (initcall_debug, initcall_debug, bool,0644 );int do_one_initcall (initcall_t fn)
@@ -785,6 +786,8 @@ static void run_init_process(char *init_filename)*/ static noinline int init_post(void) { +/* need to finish all async __init code before freeing the memory */ +async_synchronize_full ();free_initmem ();unlock_kernel ();mark_rodata_ro ();
kernel/Makefile +2 -1
@@ -9,7 +9,8 @@ obj-y = sched.o fork.o exec_domain.o panic.o printk.o \ rcupdate.o extable.o params.o posix-timers.o \ kthread.o wait.o kfifo.o sys_ni.o posix-cpu-timers.o mutex.o \ hrtimer.o rwsem.o nsproxy.o srcu.o semaphore.o \ - notifier.o ksysfs.o pm_qos_params.o sched_clock.o cred.o + notifier.o ksysfs.o pm_qos_params.o sched_clock.o cred.o \ + async.o ifdef CONFIG_FUNCTION_TRACER # Do not trace debug files and internal ftrace files
kernel/async.c new file +321 -0
321 lines not on this page · raw message
kernel/irq/autoprobe.c +5 -0
@@ -10,6 +10,7 @@#include <linux/module.h> #include <linux/interrupt.h> #include <linux/delay.h> +#include <linux/async.h> #include "internals.h"
@@ -34,6 +35,10 @@ unsigned long probe_irq_on(void)unsigned int status;int i; +/* +* quiesce the kernel, or at least the asynchronous portion +*/ +async_synchronize_full ();mutex_lock (&probing_active);/* * something may have generated an irq long ago and we want to
kernel/module.c +2 -0
@@ -50,6 +50,7 @@#include <asm/sections.h> #include <linux/tracepoint.h> #include <linux/ftrace.h> +#include <linux/async.h> #if 0 #define DEBUGP printk
@@ -816,6 +817,7 @@ sys_delete_module(const char __user *name_user, unsigned int flags) mod->exit ();blocking_notifier_call_chain (&module_notify_list,MODULE_STATE_GOING , mod); +async_synchronize_full ();mutex_lock (&module_mutex);/* Store the name of the last unloaded module for diagnostic purposes */ strlcpy (last_unloaded_module, mod->name,sizeof (last_unloaded_module));
Signature · 9 lines
1.6.0.6 -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
Re: [PATCH 1/7] async: Asynchronous function calls to speed up kernel boot
Em Wed, Jan 07, 2009 at 03:12:26PM -0800, Arjan van de Ven escreveu:
<SNIP>
kernel/async.c line 93
Quoted 9 lines
kernel/async.c new file +9
-0+/* +* MUST be called with the lock held! +*/ +static async_cookie_t __lowest_in_progress (struct list_head *running) +{ +struct async_entry *entry; +if (!list_empty (&async_pending)) { + entry =list_first_entry (&async_pending, + struct async_entry, list);
Small nitpick:
- > + return entry->cookie;
kernel/async.c line 97
Quoted 3 lines
kernel/async.c new file +3
-0+ }else if (!list_empty (running)) { + entry =list_first_entry (running, + struct async_entry, list);
- > + return entry->cookie;
kernel/async.c line 102
Quoted 4 lines
kernel/async.c new file +4
-0+ }else { +/* nothing in progress... next_cookie is "infinity" */ +return next_cookie; + }
+ return entry->cookie;
Quoted 9 lines
kernel/async.c new file +9
-0+/* +* pick the first pending entry and run it +*/ +static void run_one_entry (void ) +{ +unsigned long flags; +struct async_entry *entry; +ktime_t calltime, delta, rettime; +
kernel/async.c line 123
Quoted 10 lines
kernel/async.c new file +10
-0+/* 1) pick one task from the pending queue */ + +spin_lock_irqsave (&async_lock, flags); +if (list_empty (&async_pending)) + goto out; + entry = list_first_entry(&async_pending, struct async_entry, list); + +/* 2) move it to the running queue */ +list_del (&entry->list); +list_add_tail (&entry->list, &async_running);
We have list_move_tail()
kernel/async.c line 129
Quoted 6 lines
kernel/async.c new file +6
-0+spin_unlock_irqrestore (&async_lock, flags); + +/* 3) run it (and print duration)*/ +if (initcall_debug) { +printk ("calling %lli_%pF @ %i\n" , entry->cookie, entry->func,task_pid_nr (current)); + calltime =ktime_get ();
- Arnaldo
Re: [PATCH 1/7] async: Asynchronous function calls to speed up kernel boot
Quoted 13 lines · On Wed, 7 Jan 2009 22:31:41 -0200 Arnaldo Carvalho de Melo…
Small nitpick:
- > + return
entry->cookie;kernel/async.c line 97
Quoted 3 lines
kernel/async.c new file +3
-0+ }else if (!list_empty (running)) { + entry =list_first_entry (running, + struct async_entry, list);- > + return
entry->cookie;Quoted 5 lines
(quoted diff) +2
-0+ } else { + /* nothing in progress... next_cookie is"infinity" */
(quoted diff) +2
-0+ return next_cookie; + }
Review
Quoted 1 line
(quoted diff) +1
-0+ return entry->cookie;
no you cannot do this; entry can be freed by this time already from a thread.
Re: [PATCH 1/7] async: Asynchronous function calls to speed up kernel boot
In reply to Arjan van de Ven[A somewhat belated question...]
As I read the patch, I find the async_entry structure:
kernel/async.c line 74
Quoted 7 lines
kernel/async.c new file +7
-0+struct async_entry { +struct list_head list; +async_cookie_t cookie; +async_func_ptr *func; +void *data; +struct list_head *running; +};
The "running" field is, presumably, meant to hold a pointer to the "running" queue to be used when this function is actually run. But, then, I see:
kernel/async.c line 199
Quoted 5 lines
kernel/async.c new file +5
-0+async_cookie_t async_schedule (async_func_ptr *ptr,void *data) +{ +return __async_schedule (ptr, data, &async_pending); +} +EXPORT_SYMBOL_GPL (async_schedule);
It seems to me that you wanted &async_running there, no?
However, it doesn't matter in the current form of the patch:
Quoted 10 lines
kernel/async.c new file +10
-0+/* +* pick the first pending entry and run it +*/ +static void run_one_entry (void ) +{ +unsigned long flags; +struct async_entry *entry; +ktime_t calltime, delta, rettime; + +/* 1) pick one task from the pending queue */
kernel/async.c line 124
Quoted 10 lines
kernel/async.c new file +10
-0+ +spin_lock_irqsave (&async_lock, flags); +if (list_empty (&async_pending)) + goto out; + entry = list_first_entry(&async_pending, struct async_entry, list); + +/* 2) move it to the running queue */ +list_del (&entry->list); +list_add_tail (&entry->list, &async_running); +spin_unlock_irqrestore (&async_lock, flags);
Given the way things are designed, don't you want to add the entry to entry->running, rather than unconditionally to async_running? If not, I don't see how calls to async_synchronize_cookie_special() can work right.
Of course, I'm probably just confused...enlighten me?
Thanks,
jon
Re: [PATCH 1/7] async: Asynchronous function calls to speed up kernel boot
Quoted 51 lines · Jonathan Corbet
[A somewhat belated question...]
As I read the patch, I find the
async_entrystructure:Review
Quoted 7 lines
(quoted diff) +7
-0+struct async_entry { + struct list_head list; + async_cookie_t cookie; + async_func_ptr *func; + void *data; + struct list_head *running; +};The "running" field is, presumably, meant to hold a pointer to the "running" queue to be used when this function is actually run. But, then, I see:
Review
Quoted 5 lines
(quoted diff) +5
-0+async_cookie_t async_schedule(async_func_ptr *ptr, void *data) +{ + return __async_schedule(ptr, data, &async_pending); +} +EXPORT_SYMBOL_GPL(async_schedule);It seems to me that you wanted
&async_runningthere, no?However, it doesn't matter in the current form of the patch:
Quoted 10 lines
(quoted diff) +10
-0+/* + * pick the first pending entry and run it + */ +static void run_one_entry(void) +{ + unsigned long flags; + struct async_entry *entry; + ktime_t calltime, delta, rettime; + + /* 1) pick one task from the pending queue */Review
Quoted 10 lines
(quoted diff) +10
-0+ + spin_lock_irqsave(&async_lock, flags); + if (list_empty(&async_pending)) + goto out; + entry = list_first_entry(&async_pending, struct async_entry, list); + + /* 2) move it to the running queue */ + list_del(&entry->list); + list_add_tail(&entry->list, &async_running); + spin_unlock_irqrestore(&async_lock, flags);Given the way things are designed, don't you want to add the entry to
entry->running, rather than unconditionally toasync_running? If not, I don't see how calls toasync_synchronize_cookie_special()can work right.
Quoted 1 line
Of course, I'm probably just confused...enlighten me?
No, you're not confused, the code is :)
async_schedule() should pass in async_running as the running list, and run_one_entry() should put the entry to be run on the provided running list instead of always on the generic one.
--- kernel/async.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/async.c +2 -2
@@ -133,7 +133,7 @@ static void run_one_entry(void)/* 2) move it to the running queue */ list_del (&entry->list); -list_add_tail (&entry->list, &async_running); +list_add_tail (&entry->list, entry->running);spin_unlock_irqrestore (&async_lock, flags);/* 3) run it (and print duration)*/
@@ -207,7 +207,7 @@ static async_cookie_t __async_schedule(aasync_cookie_t async_schedule (async_func_ptr *ptr,void *data) { -return __async_schedule (ptr, data, &async_pending); +return __async_schedule (ptr, data, &async_running); }EXPORT_SYMBOL_GPL (async_schedule);
Re: [PATCH 1/7] async: Asynchronous function calls to speed up kernel boot
In reply to Arjan van de VenQuoted 12 lines · On Wed, 7 Jan 2009 15:12:26 -0800 Arjan van de Ven <[email protected]> wrote:
kernel/async.c new file +12
-0+static async_cookie_t __async_schedule (async_func_ptr *ptr,void *data,struct list_head *running) +{ +struct async_entry *entry; +unsigned long flags; +async_cookie_t newcookie; + + +/* allow irq-off callers */ + entry =kzalloc (sizeof (struct async_entry ),GFP_ATOMIC ); + +/* +* If we're out of memory or if there's too much work
kernel/async.c line 179
Quoted 10 lines
kernel/async.c new file +10
-0+* pending already, we execute synchronously. +*/ +if (!entry ||atomic_read (&entry_count) >MAX_WORK ) { +kfree (entry); +spin_lock_irqsave (&async_lock, flags); + newcookie = next_cookie++; +spin_unlock_irqrestore (&async_lock, flags); + +/* low on memory.. run synchronously */ +ptr (data, newcookie);
This is quite bad.
Quoted 4 lines
kernel/async.c new file +4
-0+return newcookie; + } + entry->func = ptr; + entry->data = data;
kernel/async.c line 193
Quoted 10 lines
kernel/async.c new file +10
-0+ entry->running = running; + +spin_lock_irqsave (&async_lock, flags); + newcookie = entry->cookie = next_cookie++; +list_add_tail (&entry->list, &async_pending); +atomic_inc (&entry_count); +spin_unlock_irqrestore (&async_lock, flags); +wake_up (&async_new); +return newcookie; +}
It means that sometimes, very rarely, the callback function will be called within the caller's context.
Hence this interface cannot be used to call might-sleep functions from within atomic contexts. Which should be a major application of this code!
It's bad that nobody discovers this shortcoming until __async_schedule() happens to be called when the system is out of memory. They will then discover it via might_sleep() warnings, or an interrupt-context kernel panic.
Furthermore:
- If the callback function can sleep then the caller must be able to sleep, so the GFP_ATOMIC is unneeded and undesirable, and the comment is wrong.
- Regardless of whether or not the callback function can sleep: if the caller can sleep then the GFP_ATOMIC allocation is undesirable and wrong.
We can fix these two issues by adding a gfp_t to the interface (as we almost always should).
But for the first issue we're kinda screwed. It makes the whole utility far less useful than it might otherwise have been.
I can't immediately think of a fix, apart from overhauling the implementation and doing it in the proper way: caller-provided storage rather than callee-provided (which always goes wrong). schedule_work() got this right.
Re: [PATCH 1/7] async: Asynchronous function calls to speed up kernel boot
Quoted 2 lines · On Fri, 13 Feb 2009 16:22:00 -0800 Andrew Morton <[email protected]>…
It means that sometimes, very rarely, the callback function will be called within the caller's context.
for the cases that use it right now it is ok.
Quoted 4 lines
Hence this interface cannot be used to call might-sleep functions from within atomic contexts. Which should be a major application of this code!
That is not what this was originally designed for. The original design goal was to offload existing function calls out of the synchronous execution path.
Now I understand that it would be nice to do what you propose, but it needs a little different interface for that; specifically, the caller will need to pass in the memory for the administration.
Quoted 8 lines
Furthermore:
- If the callback function can sleep then the caller must be able to sleep, so the
GFP_ATOMICis unneeded and undesirable, and the
comment is wrong.
And if the callback function does not sleep it can be used in atomic context just fine. Hence the GFP_ATOMIC.
.
Quoted 5 lines
I can't immediately think of a fix, apart from overhauling the implementation and doing it in the proper way: caller-provided storage rather than callee-provided (which always goes wrong).
schedule_work()got this right.
schedule_work() got it part right. Pushing the administration to the caller means the caller needs to allocate the memory or use static memory and then make sure it doesn't get reused for a 2nd piece of work. (schedule_work doesn't care, it will just execute it once in that case. Here we do absolutely care).
The caller only rarely can deal better with the memory allocation and lifetime rules than the implementation can. In fact, for the scenario of "I want to take this bit of code out of the synchronous path normally".. it is just fine and most easy this way; moving this to the caller just makes things more fragile.
So yes based on the discussions on lkml in the last week I was going to add an interface where you can pass in your own memory, but I want to get the interface right such that it is low complexity for the caller, and really hard to get wrong.. and that does involve dealing with the "how to do static allocation while doing multiple parallel calls" problem.
Signature · 3 lines
Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
Re: [PATCH 1/7] async: Asynchronous function calls to speed up kernel boot
Quoted 7 lines · On Fri, 13 Feb 2009 20:59:49 -0800 Arjan van de Ven <[email protected]> wrote:
Quoted 2 lines · On Fri, 13 Feb 2009 16:22:00 -0800 Andrew Morton <[email protected]>…
It means that sometimes, very rarely, the callback function will be called within the caller's context.
for the cases that use it right now it is ok.
That doesn't mean it's any good! There are only two callsites.
Plus there's the issue which I mentioned: if someone _does_ call this from atomic context they'll only find out about their bug when the GFP_ATOMIC allocation fails. This is bad!
Quoted 8 lines
Quoted 4 lines
Hence this interface cannot be used to call might-sleep functions from within atomic contexts. Which should be a major application of this code!
That is not what this was originally designed for. The original design goal was to offload existing function calls out of the synchronous execution path.
I'm desperately trying to avoid us ending up with multiple different-but-similar thread pool implementations. It's really quite important that the one which got there first (actually, it's approximately our fourth) be usable in place of Evgeniy's one and dhowells' one.
Quoted 3 lines
Now I understand that it would be nice to do what you propose, but it needs a little different interface for that; specifically, the caller will need to pass in the memory for the administration.
yep. And we should change the existing interface to take an additional gfp_t argument. Because it's silly doing an unreliable GFP_ATOMIC when the caller's context doesn't require that.
As for the fallback-to-synchronous-panics-the-kernel trap: I don't know how we can save people from falling into that one.
Quoted 18 lines
Quoted 7 lines
Furthermore:
- If the callback function can sleep then the caller must be able to sleep, so the
GFP_ATOMICis unneeded and undesirable, and the
comment is wrong.And if the callback function does not sleep it can be used in atomic context just fine. Hence the
GFP_ATOMIC.
.Quoted 5 lines
I can't immediately think of a fix, apart from overhauling the implementation and doing it in the proper way: caller-provided storage rather than callee-provided (which always goes wrong).
schedule_work()got this right.
Quoted 5 lines
schedule_work()got it part right. Pushing the administration to the caller means the caller needs to allocate the memory or use static memory and then make sure it doesn't get reused for a 2nd piece of work. (schedule_workdoesn't care, it will just execute it once in that case. Here we do absolutely care).
Caller needs to allocate storage for each invocation - that's fine.
It would be sensible for the code to be able to detect when the caller tries to use the same storage concurrently, and go BUG.
Quoted 2 lines
The caller only rarely can deal better with the memory allocation and lifetime rules than the implementation can.
Nonsense. The caller *always* knows better. That's a core design decision in Linux and we relearn it over and over again. Examples are the radix-tree code, where we went to exorbitant lengths to make callee-allocation reliable, and the IDR code, which completely sucks.
Quoted 4 lines
In fact, for the scenario of
"I want to take this bit of code out of the synchronous path normally".. it is just fine and most easy this way; moving this to the caller just makes things more fragile.
The code now is fragile. Requiring caller-provided storage and adding debugging to detect when the caller screws up is solid as a rock.
Quoted 6 lines
So yes based on the discussions on lkml in the last week I was going to add an interface where you can pass in your own memory, but I want to get the interface right such that it is low complexity for the caller, and really hard to get wrong.. and that does involve dealing with the "how to do static allocation while doing multiple parallel calls" problem.
An alternative is to keep doing the allocation in the callee, add a gfp_t argument and require that callers be able to handle the resulting -ENOMEM.
But this is bad because the caller's -ENOMEM handling will remain basically untested.
Re: [PATCH 1/7] async: Asynchronous function calls to speed up kernel boot
Quoted 6 lines · On Fri, 13 Feb 2009 23:29:26 -0800 Andrew Morton <[email protected]>…
Quoted 3 lines · On Fri, 13 Feb 2009 20:59:49 -0800 Arjan van de Ven <[email protected]> wrote:
On Fri, 13 Feb 2009 16:22:00 -0800
Andrew Morton <[email protected]> wrote:
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
It means that sometimes, very rarely, the callback function will be called within the caller's context.
for the cases that use it right now it is ok.
That doesn't mean it's any good! There are only two callsites.
.. in mainline.
There's a few more in various maintainer trees.
Quoted 4 lines
Plus there's the issue which I mentioned: if someone _does_ call this from atomic context they'll only find out about their bug when the
GFP_ATOMICallocation fails. This is bad!
as far as I know all current and pending callsites can deal with GFP_KERNEL, so I would just switch it to that for those; solves the entire issue. (I do need to check the suspend/resume speed improvements, S/R tends to be tricky with interrupts-off)
Fundamentally there are two types of usecases:
1) The case where you have "just turn this existing function call into something asynchronous".
2) I want to call <this> thing in a guaranteed different, process, context.
Both need some degree of synchronization, and I believe the current synchronization in the async stuff would work for both.
But these two are fundamentally different cases. The former is what is covered now, the later is what you would like to use.
Both are absolutely valid cases; I just think they need separate APIs (but can share the backend): a simple one for the simple case and a more complex one for the second case.
The first case really is replacing the function call with a small wrapper. (Ideally it'd be a gcc attribute but that's fantasy not reality).
The second case is a bit more complex, and is allowed to be more complex because the caller wants to do a more complex thing. So lets talk requirements for the second case; and please provide comments/additions/improvements
* The caller needs to provide the memory
- solves the case of the internal implementation getting a failed allocation. BUT it does not solve the caller not getting memory, it shifts the complexity to there.
- ... or needs to cope with the call potentially failing if it lets the infrastructure to do the allocation
* The caller needs to wait (at some point) for the operation to complete, and then take care of freeing the memory.
(the memory obviously could be part of some natural structure that
already has its own lifecycle rules)
* There must be enough worker threads such that deadlocks due to all threads waiting on each other will not happen. Practically this probably means that if there is no progress, we need to just swallow the pill and make more threads. In addition we can borrow the thread context of the threads that are waiting for work to complete
- alternative is to have 2 (or more) classes of work with a reserved thread pool for each, but I'm very not fond of this idea, because then all the advantages of sharing the implementation go away again, and over time we'll end up with many such classes
* The caller is not allowed to use the same memory for scheduling multiple outstanding function calls (this is fundamentally different from schedule_work, which does allow this).
- we could make a flag that marks an item as "if the function and data are the same silently allow it" but I'm not too fond of that idea, it'll be fragile.
Practically: the scheduled function is not allowed to make the metadata memory go away. At least for those cases where we later want to wait for the opertation; in principle we could do away with this requirement if we know nobody will ever wait for the operation.
Second practical issue:
We can have a flag in the metadata that says that the infrastructure is supposed to kfree() the metadata at the end. Or we can go wild and stick a pointer in of the function that needs to be called to free the metadata.
Signature · 3 lines
Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
Re: [PATCH 1/7] async: Asynchronous function calls to speed up kernel boot
Quoted 20 lines · On Sun, 15 Feb 2009 11:16:36 -0800 Arjan van de Ven <[email protected]> wrote:
Quoted 6 lines · On Fri, 13 Feb 2009 23:29:26 -0800 Andrew Morton <[email protected]>…
Quoted 3 lines · On Fri, 13 Feb 2009 20:59:49 -0800 Arjan van de Ven <[email protected]> wrote:
On Fri, 13 Feb 2009 16:22:00 -0800
Andrew Morton <[email protected]> wrote:Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
It means that sometimes, very rarely, the callback function will be called within the caller's context.
for the cases that use it right now it is ok.
That doesn't mean it's any good! There are only two callsites.
.. in mainline.
There's a few more in various maintainer trees.Quoted 1 line
Quoted 9 lines
Quoted 3 lines
Plus there's the issue which I mentioned: if someone _does_ call this from atomic context they'll only find out about their bug when the
GFP_ATOMICallocation fails. This is bad!as far as I know all current and pending callsites can deal with
GFP_KERNEL, so I would just switch it to that for those; solves the entire issue. (I do need to check the suspend/resume speed improvements, S/R tends to be tricky with interrupts-off)
btw if you have a poster child in the kernel that you would like to see use the new stuff let me know; very often having one or two good use cases makes the discussion and design a ton easier.
Signature · 3 lines
Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
Re: [PATCH 1/7] async: Asynchronous function calls to speed up kernel boot
In reply to Arjan van de VenQuoted 6 lines · Arjan van de Ven
* The caller needs to provide the memory
- solves the case of the internal implementation getting a failed allocation. BUT it does not solve the caller not getting memory, it shifts the complexity to there.
- ... or needs to cope with the call potentially failing if it lets the infrastructure to do the allocation
We could provide a small wrapper that allocates memory for the simple case - but having the caller provide the memory makes it more flexible.
Quoted 4 lines
* The caller needs to wait (at some point) for the operation to complete, and then take care of freeing the memory. (the memory obviously could be part of some natural structure that already has its own lifecycle rules)
So it's not so much freeing as giving up a reference.
Quoted 7 lines
* There must be enough worker threads such that deadlocks due to all threads waiting on each other will not happen. Practically this probably means that if there is no progress, we need to just swallow the pill and make more threads. In addition we can borrow the thread context of the threads that are waiting for work to complete
- alternative is to have 2 (or more) classes of work with a reserved thread pool for each, but I'm very not fond of this idea, because
Quoted 8 lines
then all the advantages of sharing the implementation go away again, and over time we'll end up with many such classes
* The caller is not allowed to use the same memory for scheduling multiple outstanding function calls (this is fundamentally different fromschedule_work, which does allow this).
- we could make a flag that marks an item as "if the function and data are the same silently allow it" but I'm not too fond of that idea, it'll be fragile.
Agreed, that would be fragile. The caller should be able to take care of it best.
Quoted 4 lines
Practically: the scheduled function is not allowed to make the metadata memory go away. At least for those cases where we later want to wait for the opertation; in principle we could do away with this requirement if we know nobody will ever wait for the operation.
But that would artificially limit the usefulness.
Quoted 3 lines
Second practical issue:
We can have a flag in the metadata that says that the infrastructure is supposed tokfree()the metadata at the end.
I tried that, but didn't like the result.
Quoted 3 lines
Or we can go wild and stick
a pointer in of the function that needs to be called to free the metadata.
krefs start to look attractive...
PATCH 2/7 fastboot: make scsi probes asynchronous
In reply to Arjan van de VenQuoted 1 line
From
4ace92fc112c6069b4fcb95a31d3142d4a43ff2aMon Sep 17 00:00:00 2001
From: Arjan van de Ven <[email protected]>
Date: Sun, 4 Jan 2009 05:32:28 -0800
Subject: [PATCH] fastboot: make scsi probes asynchronous
This patch makes part of the scsi probe (which is mostly device spin up and the partition scan) asynchronous. Only the part that runs after getting the device number allocated is asynchronous, ensuring that device numbering remains stable.
--- drivers/scsi/scsi_scan.c | 3 + drivers/scsi/sd.c | 109 ++++++++++++++++++++++++++++------------------ 2 files changed, 70 insertions(+), 42 deletions(-)
drivers/scsi/scsi_scan.c +3 -0
@@ -32,6 +32,7 @@#include <linux/delay.h> #include <linux/kthread.h> #include <linux/spinlock.h> +#include <linux/async.h> #include <scsi/scsi.h> #include <scsi/scsi_cmnd.h>
@@ -179,6 +180,8 @@ int scsi_complete_async_scans(void)spin_unlock (&async_scan_lock);kfree (data); +/* Synchronize async operations globally */ +async_synchronize_full ();return 0 ; }
drivers/scsi/sd.c +67 -42
127 lines not on this page · raw message
Signature · 8 lines
1.6.0.6 -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
PATCH 3/7 fastboot: make the libata port scan asynchronous
In reply to Arjan van de VenQuoted 2 lines
From
793180570ff2530d133343ceea85648de5f01b02Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <[email protected]>
Date: Sun, 4 Jan 2009 05:32:28 -0800
Subject: [PATCH] fastboot: make the libata port scan asynchronous
This patch makes the libata port scanning asynchronous (per device). There is a synchronization point before doing the actual disk scan so that device ordering is not affected.
--- drivers/ata/libata-core.c | 84 ++++++++++++++++++++++++-------------------- 1 files changed, 46 insertions(+), 38 deletions(-)
drivers/ata/libata-core.c +46 -38
@@ -56,6 +56,7 @@#include <linux/workqueue.h> #include <linux/scatterlist.h> #include <linux/io.h> +#include <linux/async.h> #include <scsi/scsi.h> #include <scsi/scsi_cmnd.h> #include <scsi/scsi_host.h>
@@ -5909,6 +5910,48 @@ void ata_host_init(struct ata_host *host, struct device *dev, host->ops = ops; } + +static void async_port_probe (void *data,async_cookie_t cookie) +{ +int rc; +struct ata_port *ap = data; +/* probe */ +if (ap->ops->error_handler) { +struct ata_eh_info *ehi = &ap->link.eh_info; +unsigned long flags; + +ata_port_probe (ap); + +/* kick EH for boot probing */ +spin_lock_irqsave (ap->lock, flags); + + ehi->probe_mask |=ATA_ALL_DEVICES ; + ehi->action |=ATA_EH_RESET |ATA_EH_LPM ; + ehi->flags |=ATA_EHI_NO_AUTOPSY |ATA_EHI_QUIET ; + + ap->pflags &= ~ATA_PFLAG_INITIALIZING ; + ap->pflags |=ATA_PFLAG_LOADING ; +ata_port_schedule_eh (ap); + +spin_unlock_irqrestore (ap->lock, flags); + +/* wait for EH to finish */ +ata_port_wait_eh (ap); + }else { +DPRINTK ("ata%u: bus probe begin\n" , ap->print_id); + rc =ata_bus_probe (ap); +DPRINTK ("ata%u: bus probe end\n" , ap->print_id); + +if (rc) { +/* FIXME: do something useful here? +* Current libata behavior will +* tear down everything when +* the module is removed +* or the h/w is unplugged. +*/ + } + } +}/** * ata_host_register - register initialized ATA host * @host: ATA host to register
@@ -5988,45 +6031,9 @@ int ata_host_register(struct ata_host *host, struct scsi_host_template *sht)DPRINTK ("probe begin\n" );for (i =0 ; i < host->n_ports; i++) {struct ata_port *ap = host->ports[i]; - -/* probe */ -if (ap->ops->error_handler) { -struct ata_eh_info *ehi = &ap->link.eh_info; -unsigned long flags; - -ata_port_probe (ap); - -/* kick EH for boot probing */ -spin_lock_irqsave (ap->lock, flags); - - ehi->probe_mask |=ATA_ALL_DEVICES ; - ehi->action |=ATA_EH_RESET |ATA_EH_LPM ; - ehi->flags |=ATA_EHI_NO_AUTOPSY |ATA_EHI_QUIET ; - - ap->pflags &= ~ATA_PFLAG_INITIALIZING ; - ap->pflags |=ATA_PFLAG_LOADING ; -ata_port_schedule_eh (ap); - -spin_unlock_irqrestore (ap->lock, flags); - -/* wait for EH to finish */ -ata_port_wait_eh (ap); - }else { -DPRINTK ("ata%u: bus probe begin\n" , ap->print_id); - rc =ata_bus_probe (ap); -DPRINTK ("ata%u: bus probe end\n" , ap->print_id); - -if (rc) { -/* FIXME: do something useful here? -* Current libata behavior will -* tear down everything when -* the module is removed -* or the h/w is unplugged. -*/ - } - } +async_schedule (async_port_probe, ap); } - +async_synchronize_full ();/* probes are done, now scan each port's disk(s) */ DPRINTK ("host probe begin\n" );for (i =0 ; i < host->n_ports; i++) {
@@ -6034,6 +6041,7 @@ int ata_host_register(struct ata_host *host, struct scsi_host_template *sht)ata_scsi_scan_host (ap,1 ); } +DPRINTK ("host probe end\n" );return 0 ; }
Signature · 7 lines
1.6.0.6 -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
PATCH 4/7 fastboot: Make libata initialization even more async
In reply to Arjan van de VenQuoted 1 line
From
f29d3b23238e1955a8094e038c72546e99308e61Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <[email protected]>
Date: Mon, 5 Jan 2009 15:07:07 -0800
Subject: [PATCH] fastboot: Make libata initialization even more async
As suggested by Linus: Don't do the libata init in 2 separate steps with a global sync inbetween, but do it as one async step, with a local sync before registering the device.
This cuts the boottime on my machine with 2 sata controllers down significantly, and it seems to work. Would be nice if the libata folks take a good look at this patch though..
--- drivers/ata/libata-core.c | 16 +++++++--------- 1 files changed, 7 insertions(+), 9 deletions(-)
drivers/ata/libata-core.c +7 -9
@@ -5951,6 +5951,12 @@ static void async_port_probe(void *data, async_cookie_t cookie)*/ } } + +/* in order to keep device order, we need to synchronize at this point */ +async_synchronize_cookie (cookie); + +ata_scsi_scan_host (ap,1 ); + }/** * ata_host_register - register initialized ATA host
@@ -6033,15 +6039,7 @@ int ata_host_register(struct ata_host *host, struct scsi_host_template *sht)struct ata_port *ap = host->ports[i];async_schedule (async_port_probe, ap); } -async_synchronize_full (); -/* probes are done, now scan each port's disk(s) */ -DPRINTK ("host probe begin\n" ); -for (i =0 ; i < host->n_ports; i++) { -struct ata_port *ap = host->ports[i]; - -ata_scsi_scan_host (ap,1 ); - } -DPRINTK ("host probe end\n" ); +DPRINTK ("probe end\n" );return 0 ; }
Signature · 9 lines
1.6.0.6 -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
PATCH 5/7 async: make the final inode deletion an asynchronous event
In reply to Arjan van de VenQuoted 1 line
From
efaee192063a54749c56b7383803e16fe553630eMon Sep 17 00:00:00 2001
From: Arjan van de Ven <[email protected]>
Date: Tue, 6 Jan 2009 07:20:54 -0800
Subject: [PATCH] async: make the final inode deletion an asynchronous event
this makes "rm -rf" on a (names cached) kernel tree go from 11.6 to 8.6 seconds on an ext3 filesystem
--- fs/inode.c | 20 +++++++++++++------- fs/super.c | 10 ++++++++++ include/linux/fs.h | 5 +++++ 3 files changed, 28 insertions(+), 7 deletions(-)
fs/inode.c +13 -7
@@ -22,6 +22,7 @@#include <linux/bootmem.h> #include <linux/inotify.h> #include <linux/mount.h> +#include <linux/async.h> /* * This is needed for the following functions:
@@ -1138,16 +1139,11 @@ EXPORT_SYMBOL(remove_inode_hash);* I_FREEING is set so that no-one will take a new reference to the inode while * it is being deleted. */ -void generic_delete_inode (struct inode *inode) +static void generic_delete_inode_async (void *data,async_cookie_t cookie) { +struct inode *inode = data;const struct super_operations *op = inode->i_sb->s_op; -list_del_init (&inode->i_list); -list_del_init (&inode->i_sb_list); - inode->i_state |=I_FREEING ; - inodes_stat.nr_inodes--; -spin_unlock (&inode_lock); -security_inode_delete (inode);if (op->delete_inode) {
@@ -1171,6 +1167,16 @@ void generic_delete_inode(struct inode *inode)destroy_inode (inode); } +void generic_delete_inode (struct inode *inode) +{ +list_del_init (&inode->i_list); +list_del_init (&inode->i_sb_list); + inode->i_state |=I_FREEING ; + inodes_stat.nr_inodes--; +spin_unlock (&inode_lock); +async_schedule_special (generic_delete_inode_async, inode, &inode->i_sb->s_async_list); +} +EXPORT_SYMBOL (generic_delete_inode);static void generic_forget_inode (struct inode *inode)
fs/super.c +10 -0
@@ -38,6 +38,7 @@#include <linux/kobject.h> #include <linux/mutex.h> #include <linux/file.h> +#include <linux/async.h> #include <asm/uaccess.h> #include "internal.h"
@@ -71,6 +72,7 @@ static struct super_block *alloc_super(struct file_system_type *type)INIT_HLIST_HEAD (&s->s_anon);INIT_LIST_HEAD (&s->s_inodes);INIT_LIST_HEAD (&s->s_dentry_lru); +INIT_LIST_HEAD (&s->s_async_list);init_rwsem (&s->s_umount);mutex_init (&s->s_lock);lockdep_set_class (&s->s_umount, &type->s_umount_key);
@@ -289,11 +291,18 @@ void generic_shutdown_super(struct super_block *sb) {const struct super_operations *sop = sb->s_op; +if (sb->s_root) {shrink_dcache_for_umount (sb);fsync_super (sb);lock_super (sb); sb->s_flags &= ~MS_ACTIVE ; + +/* +* wait for asynchronous fs operations to finish before going further +*/ +async_synchronize_full_special (&sb->s_async_list); +/* bad name - it should be evict_inodes() */ invalidate_inodes (sb);lock_kernel ();
@@ -449,6 +458,7 @@ void sync_filesystems(int wait)if (sb->s_flags &MS_RDONLY )continue ; sb->s_need_sync_fs =1 ; +async_synchronize_full_special (&sb->s_async_list); } restart:
include/linux/fs.h +5 -0
@@ -1184,6 +1184,11 @@ struct super_block {* generic_show_options() */ char *s_options; + +/* +* storage for asynchronous operations +*/ +struct list_head s_async_list; };extern struct timespec current_fs_time (struct super_block *sb);
Signature · 7 lines
1.6.0.6 -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
PATCH 6/7 bootchart: improve output based on Dave Jones' feedback
In reply to Arjan van de VenQuoted 1 line
From
24b0ecad07ac4d7ef74cb6f7da08c449fa9f6a4fMon Sep 17 00:00:00 2001
From: Arjan van de Ven <[email protected]>
Date: Sun, 4 Jan 2009 10:59:18 -0800
Subject: [PATCH] bootchart: improve output based on Dave Jones' feedback
Dave Jones, in his blog, had some feedback about the bootchart script:
Primarily his complaint was that shorter delays weren't visualized.
The reason for that was that too small delays will have their labels mixed up in the graph in an unreadable mess.
This patch has a fix for this; for one, it makes the output wider, so more will fit.
The second part is that smaller delays are now shown with a much smaller font for the label; while this isn't per se readable at a 1:1 zoom, at least you can zoom in with most SVG viewing applications and see what it is you are looking at.
--- scripts/bootgraph.pl | 16 +++++++++++----- 1 files changed, 11 insertions(+), 5 deletions(-)
scripts/bootgraph.pl +11 -5
@@ -88,7 +88,7 @@ END } print "<?xml version=\"1.0\" standalone=\"no\"?> \n"; -print "<svg width=\"1000\" height=\"100%\" version=\"1.1\" xmlns=\"http://www.w3.org/2000/svg\">\n"; +print "<svg width=\"2000\" height=\"100%\" version=\"1.1\" xmlns=\"http://www.w3.org/2000/svg\">\n"; my @styles;
@@ -105,8 +105,9 @@ $styles[9] = "fill:rgb(255,255,128);fill-opacity:0.5;stroke-width:1;stroke:rgb(0 $styles[10] = "fill:rgb(255,128,255);fill-opacity:0.5;stroke-width:1;stroke:rgb(0,0,0)"; $styles[11] = "fill:rgb(128,255,255);fill-opacity:0.5;stroke-width:1;stroke:rgb(0,0,0)"; -my $mult = 950.0 / ($maxtime - $firsttime); -my $threshold = ($maxtime - $firsttime) / 60.0; +my $mult = 1950.0 / ($maxtime - $firsttime); +my $threshold2 = ($maxtime - $firsttime) / 120.0; +my $threshold = $threshold2/10; my $stylecounter = 0; my %rows; my $rowscount = 1;
@@ -116,7 +117,7 @@ foreach my $key (@initcalls) { my $duration = $end{$key} - $start{$key}; if ($duration >= $threshold) { - my ($s, $s2, $e, $w, $y, $y2, $style); + my ($s, $s2, $s3, $e, $w, $y, $y2, $style); my $pid = $pids{$key}; if (!defined($rows{$pid})) {
@@ -125,6 +126,7 @@ foreach my $key (@initcalls) { } $s = ($start{$key} - $firsttime) * $mult; $s2 = $s + 6; + $s3 = $s + 1; $e = ($end{$key} - $firsttime) * $mult; $w = $e - $s;
@@ -138,7 +140,11 @@ foreach my $key (@initcalls) { }; print "<rect x=\"$s\" width=\"$w\" y=\"$y\" height=\"145\" style=\"$style\"/>\n"; - print "<text transform=\"translate($s2,$y2) rotate(90)\">$key</text>\n"; + if ($duration >= $threshold2) { + print "<text transform=\"translate($s2,$y2) rotate(90)\">$key</text>\n"; + } else { + print "<text transform=\"translate($s3,$y2) rotate(90)\" font-size=\"3pt\">$key</text>\n"; + } } }
Signature · 8 lines
1.6.0.6 -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
PATCH 7/7 async: don't do the initcall stuff post boot
In reply to Arjan van de VenQuoted 1 line
From
ad160d23198193135cb2bcc75222e0816b5838c0Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <[email protected]>
Date: Wed, 7 Jan 2009 09:28:53 -0800
Subject: [PATCH] async: don't do the initcall stuff post boot
while tracking the asynchronous calls during boot using the initcall_debug convention is useful, doing it once the kernel is done is actually bad now that we use asynchronous operations post boot as well...
--- kernel/async.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
kernel/async.c +4 -4
@@ -124,12 +124,12 @@ static void run_one_entry(void)spin_unlock_irqrestore (&async_lock, flags);/* 3) run it (and print duration)*/ -if (initcall_debug) { +if (initcall_debug && system_state ==SYSTEM_BOOTING ) {printk ("calling %lli_%pF @ %i\n" , entry->cookie, entry->func,task_pid_nr (current)); calltime =ktime_get (); } entry->func (entry->data, entry->cookie); -if (initcall_debug) { +if (initcall_debug && system_state ==SYSTEM_BOOTING ) { rettime =ktime_get (); delta =ktime_sub (rettime, calltime); printk("initcall %lli_%pF returned 0 after %lld usecs\n", entry->cookie,
@@ -220,14 +220,14 @@ void async_synchronize_cookie_special(async_cookie_t cookie, struct list_head *r {ktime_t starttime, delta, endtime; -if (initcall_debug) { +if (initcall_debug && system_state ==SYSTEM_BOOTING ) {printk ("async_waiting @ %i\n" ,task_pid_nr (current)); starttime =ktime_get (); }wait_event (async_done,__lowest_in_progress (running) >= cookie); -if (initcall_debug) { +if (initcall_debug && system_state ==SYSTEM_BOOTING ) { endtime =ktime_get (); delta =ktime_sub (endtime, starttime);
Signature · 8 lines
1.6.0.6 -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
Quoted 6 lines · Arjan van de Ven
version 3 of the async function call patches
* Dropped the ACPI part; it broke i surprising ways; needs a rethink (working with Len and co on that)
* Included asynchronousdelete()
Ok, I pulled this, because I really do want the boot speedups and the previous version missed the last merge window, but after booting it, I started to worry:
My dmesg shows:
[ 2.264955] sd 5:0:0:0: [sdb] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA [ 2.264958] sdb:<6>Freeing unused kernel memory: 408k freed
Ouch. How come that "Freeing unused kernel memory" got done in the middle of the sdb partition thing?
There's a async_synchronize_full() there before the free_initmem(), but I'm worrying that it just isn't working. Hmm? What am I missing?
Linus
Quoted 17 lines · On Wed, 7 Jan 2009 16:17:24 -0800 (PST) Linus Torvalds…
Quoted 6 lines · Arjan van de Ven
version 3 of the async function call patches
* Dropped the ACPI part; it broke i surprising ways; needs a rethink (working with Len and co on that)
* Included asynchronousdelete()Ok, I pulled this, because I really do want the boot speedups and the previous version missed the last merge window, but after booting it, I started to worry:
My dmesg shows:
[ 2.264955] sd 5:0:0:0: [sdb] Write cache: enabled, read cache:
Quoted 9 lines
enabled, doesn't support DPO or FUA [ 2.264958] sdb:<6>Freeing
unused kernel memory: 408k freedOuch. How come that "Freeing unused kernel memory" got done in the middle of the sdb partition thing?
There's a
async_synchronize_full()there before thefree_initmem(), but I'm worrying that it just isn't working. Hmm? What am I missing?
ok this part looks funny but it's not really (and it's safe I think).
The async sata thing launches another async thing (the scsi partition scan).
The synchronize_full() waits for the sata to complete, but doesn't wait for things that the sata async schedules after the wait started.
is this a problem? not right now, but it means we have a rule that if an async item schedules another async item, the second one cannot be __init. (which is ok right now.. scsi already had some of this async anyway).
I could make the async_full() be more strict if that makes you feel better, but for this specific purpose it would be over-synchronizing.
Signature · 3 lines
Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
Quoted 21 lines
Quoted 4 lines
My dmesg shows:
[ 2.264955] sd 5:0:0:0: [sdb] Write cache: enabled, read cache:Quoted 9 lines
enabled, doesn't support DPO or FUA [ 2.264958] sdb:<6>Freeing
unused kernel memory: 408k freedOuch. How come that "Freeing unused kernel memory" got done in the middle of the sdb partition thing?
There's a
async_synchronize_full()there before thefree_initmem(), but I'm worrying that it just isn't working. Hmm? What am I missing?ok this part looks funny but it's not really (and it's safe I think).
The async sata thing launches another async thing (the scsi partition scan).
Thesynchronize_full()waits for the sata to complete, but doesn't wait for things that the sata async schedules after the wait started.
Quoted 7 lines
is this a problem? not right now, but it means we have a rule that if an async item schedules another async item, the second one cannot be
__init. (which is ok right now.. scsi already had some of this async anyway).I could make the
async_full()be more strict if that makes you feel better, but for this specific purpose it would be over-synchronizing.
Really? If you run userspace before partitions are ready, its attempts to read partitions will result in problems, right?
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
I just wanted to say that because of these patches the kernel boots faster than some hard drives can spin up/init... I have these patches included in a patchset I maintain some users now need rootwait in the kernel command line :D
-Ryan
Quoted 65 lines · Arjan van de Ven
version 3 of the async function call patches
* Dropped the ACPI part; it broke i surprising ways; needs a rethink (working with Len and co on that)
* Included asynchronousdelete()There is still no integration with the out of tree slow-work patch; the slow-work patch does really weird things with refcounts that make it really specific to cachefs and, frankly, I think it's a rather weird design.
The overlap is maybe 200 lines of code at most, of which 100+ would need to be added just to deal with the various weirdnesses. I really don't think this is a good idea or a fair requirement on the async function call patch series.
The following changes since commit
8903709b054a8dafe4e8c6d9a6444034d7aba36f:
Harvey Harrison (1):
xtensa: introduceswab.hare available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/arjan/linux-2.6-async.git
masterArjan van de Ven (7):
async: Asynchronous function calls to speed up kernel boot
fastboot: make scsi probes asynchronous
fastboot: make the libata port scan asynchronous
fastboot: Make libata initialization even more async
async: make the final inode deletion an asynchronous event
bootchart: improve output based on Dave Jones' feedback
async: don't do the initcall stuff post bootdrivers/ata/libata-core.c | 96 +++++++------- drivers/scsi/scsi_scan.c | 3 + drivers/scsi/sd.c | 109 ++++++++++------ fs/inode.c | 20 ++- fs/super.c | 10 ++ include/linux/async.h | 25 ++++ include/linux/fs.h | 5 + init/do_mounts.c | 2 + init/main.c | 5 +- kernel/Makefile | 3 +- kernel/async.c | 321 +++++++++++++++++++++++++++++++++++++++++++++ kernel/irq/autoprobe.c | 5 + kernel/module.c | 2 + scripts/bootgraph.pl | 16 ++- 14 files changed, 521 insertions(+), 101 deletions(-) create mode 100644 include/linux/async.h create mode 100644 kernel/async.c--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/