Skip to contentSkip to conversation

rcu: Make a seperate Kconfig menu for RCU

PATCH Dhaval Giani 2 participants 3 messages Jan 7, 2009

lore
Share & tools
lore
#0 lore raw

Hi Paul, Ingo,

On selecting tree RCU, there are a total of 4 different RCU Kconfig options. Maybe its time to give RCU a menu of its own.

---
 init/Kconfig |    4 ++++
 1 file changed, 4 insertions(+)
init/Kconfig +4 -0
Index: linux-2.6/init/Kconfig
===================================================================
@@ -945,6 +945,8 @@ source "block/Kconfig"
 config PREEMPT_NOTIFIERS
 	bool
 
+menu "RCU related options"
+
 choice
 	prompt "RCU Implementation"
 	default CLASSIC_RCU
@@ -1032,3 +1034,5 @@ config PREEMPT_RCU_TRACE
 	help
 	  This option provides tracing for the PREEMPT_RCU implementation,
 	  permitting Makefile to trivially select kernel/rcupreempt_trace.c.
+
+endmenu
Signature · 2 lines
regards,
Dhaval
Reviewed-by
#1 lore raw
Quoted 4 lines · Dhaval Giani

Hi Paul, Ingo,

On selecting tree RCU, there are a total of 4 different RCU Kconfig options. Maybe its time to give RCU a menu of its own.

Looks good to me!

Quoted 28 lines
---
 init/Kconfig |    4 ++++
 1 file changed, 4 insertions(+)

Index: linux-2.6/init/Kconfig
===================================================================

init/Kconfig +4 -0
@@ -945,6 +945,8 @@ source "block/Kconfig"
 config PREEMPT_NOTIFIERS
 	bool
 
+menu "RCU related options"
+
 choice
 	prompt "RCU Implementation"
 	default CLASSIC_RCU
@@ -1032,3 +1034,5 @@ config PREEMPT_RCU_TRACE
 	help
 	  This option provides tracing for the PREEMPT_RCU implementation,
 	  permitting Makefile to trivially select kernel/rcupreempt_trace.c.
+
+endmenu
Signature · 2 lines
regards,
Dhaval
#2 lore raw
Quoted 12 lines · Paul E. McKenney
Quoted 4 lines · Dhaval Giani

Hi Paul, Ingo,

On selecting tree RCU, there are a total of 4 different RCU Kconfig options. Maybe its time to give RCU a menu of its own.

Looks good to me!

Quoted 2 lines

And I messed up Ingo's email address in the initial post. Correcting it!

Quoted 23 lines
Quoted 23 lines
---
 init/Kconfig |    4 ++++
 1 file changed, 4 insertions(+)

Index: linux-2.6/init/Kconfig
===================================================================

init/Kconfig +4 -0
@@ -945,6 +945,8 @@ source "block/Kconfig"
 config PREEMPT_NOTIFIERS
 	bool
 
+menu "RCU related options"
+
 choice
 	prompt "RCU Implementation"
 	default CLASSIC_RCU
@@ -1032,3 +1034,5 @@ config PREEMPT_RCU_TRACE
 	help
 	  This option provides tracing for the PREEMPT_RCU implementation,
 	  permitting Makefile to trivially select kernel/rcupreempt_trace.c.
+
+endmenu
Signature · 2 lines
regards,
Dhaval