linux/types.h: Do not depend on GNUC for le64 and be64

PATCH In review Detlef Riekenberg 3 participants 6 messages Dec 29, 2008 – Jan 7, 2009

Share & tools

Detlef Riekenberg

author

2008-12-29 23:55 UTC #0 lore raw

PATCH 1/1 linux/types.h: Do not depend on __GNUC__ for __le64 and __be64

Hi.
<linux/cdrom.h> is used in Wine, but failed to compile with pcc. (__le64 and __be64 are referenced in <linux/byteorder/little_endian.h>)

There is no reason to restrict the typedefs with __GNUC__. As reference, the typedefs for __u64 and __s64 where fixed to be available with pcc on 02. Mai 2008 by H. Peter Anvin (commit edfa5cfa3dc5bfa95e6aa82a2b8904e7f6c35ed7)

Wine: http://www.winehq.org
pcc:  http://pcc.ludd.ltu.se

Please CC me personally. Thanks

Signature · 1 line

By by ... Detlef

Quoted 1 line

From 009605de95d2148c8c54ff83f72ebe0177b805ac Mon Sep 17 00:00:00 2001

From: Detlef Riekenberg <[email protected]>
Date: Mon, 29 Dec 2008 23:52:48 +0100
Subject: [PATCH] linux/types.h: Do not depend on __GNUC__ for __le64 and __be64

Signed-off-by Detlef Riekenberg <[email protected]>

---
 include/linux/types.h |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

include/linux/types.h +1 -2

index 1d98330..ccf6742 100644
@@ -181,10 +181,9 @@ typedef __u16 __bitwise __le16;
 typedef __u16 __bitwise __be16;
 typedef __u32 __bitwise __le32;
 typedef __u32 __bitwise __be32;
-#if defined(__GNUC__)
 typedef __u64 __bitwise __le64;
 typedef __u64 __bitwise __be64;
-#endif
+
 typedef __u16 __bitwise __sum16;
 typedef __u32 __bitwise __wsum;

Signature · 1 line

1.5.4.3

H. Peter Anvin

Acked-by on v1 1/1

2008-12-30 00:05 UTC #1 lore raw

Quoted 4 lines · Detlef Riekenberg

Hi.
<linux/cdrom.h> is used in Wine, but failed to compile with pcc. (__le64 and __be64 are referenced in <linux/byteorder/little_endian.h>)

Quoted 8 lines

There is no reason to restrict the typedefs with __GNUC__. As reference, the typedefs for __u64 and __s64 where fixed to be available with pcc on 02. Mai 2008 by H. Peter Anvin (commit edfa5cfa3dc5bfa95e6aa82a2b8904e7f6c35ed7)
Wine: http://www.winehq.org
pcc:  http://pcc.ludd.ltu.se

Acked-by H. Peter Anvin <[email protected]>

Signature · 2 lines

H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

Detlef Riekenberg

author

2009-01-04 00:40 UTC #2 lore raw

PATCH 1/1 linux/types.h: Do not depend on __GNUC__ for __le64 and __be64 [synced to git]

In reply to Detlef Riekenberg

Hi.
<linux/cdrom.h> is used in Wine, but failed to compile with pcc. (__le64 and __be64 are referenced in <linux/byteorder/little_endian.h>)

Wine: http://www.winehq.org
pcc:  http://pcc.ludd.ltu.se

This patch is a resync to current git.

Please CC me personally. Thanks

Signature · 1 line

By by ... Detlef

Quoted 1 line

From 83199a23ff35af6f10d16ebcb7ca283b3f5f05e3 Mon Sep 17 00:00:00 2001

From: Detlef Riekenberg <[email protected]>
Date: Thu, 1 Jan 2009 22:55:21 +0100
Subject: [PATCH] linux/types.h: Do not depend on __GNUC__ for __le64/__be64

Acked-by H. Peter Anvin <[email protected]>

Signed-off-by Detlef Riekenberg <[email protected]>

---
 include/linux/types.h |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

include/linux/types.h +1 -2

index 121f349..e2a2788 100644
@@ -176,10 +176,9 @@ typedef __u16 __bitwise __le16;
 typedef __u16 __bitwise __be16;
 typedef __u32 __bitwise __le32;
 typedef __u32 __bitwise __be32;
-#if defined(__GNUC__)
 typedef __u64 __bitwise __le64;
 typedef __u64 __bitwise __be64;
-#endif
+
 typedef __u16 __bitwise __sum16;
 typedef __u32 __bitwise __wsum;

Signature · 1 line

1.5.4.3

Detlef Riekenberg

author

2009-01-07 09:29 UTC #3 lore raw

PATCH 1/1 linux/types.h: Don't depend on __GNUC__ for __le64 / __be64 [synced to git]

Hi.
<linux/cdrom.h> is used in Wine, but failed to compile with pcc. (__le64 and __be64 are referenced in <linux/byteorder/little_endian.h>)

There is no reason to restrict the typedefs to __GNUC__. This Patch is trivial for gcc and icc, but required for other compiler.

As reference, the typedefs for __u64 and __s64 where fixed to be available for other compiler on 02. Mai 2008 by H. Peter Anvin (commit edfa5cfa3dc5bfa95e6aa82a2b8904e7f6c35ed7)

Wine: http://www.winehq.org
pcc:  http://pcc.ludd.ltu.se

This patch is again a resync to current git.
Is there anything, that I can do for this Patch?

Please CC me personally. Thanks

Signature · 1 line

Bye bye ... Detlef

Quoted 1 line

From ce469182d86b94e4e2fd4c84028369a2eefdfb0c Mon Sep 17 00:00:00 2001

From: Detlef Riekenberg <[email protected]>
Date: Wed, 7 Jan 2009 10:11:44 +0100
Subject: [PATCH] linux/types.h: Don't depend on __GNUC__ for __le64/__be64

Acked-by H. Peter Anvin <[email protected]>

Signed-off-by Detlef Riekenberg <[email protected]>

---
 include/linux/types.h |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

include/linux/types.h +1 -2

index 3b864f2..712ca53 100644
@@ -176,10 +176,9 @@ typedef __u16 __bitwise __le16;
 typedef __u16 __bitwise __be16;
 typedef __u32 __bitwise __le32;
 typedef __u32 __bitwise __be32;
-#if defined(__GNUC__)
 typedef __u64 __bitwise __le64;
 typedef __u64 __bitwise __be64;
-#endif
+
 typedef __u16 __bitwise __sum16;
 typedef __u32 __bitwise __wsum;

Signature · 1 line

1.5.4.3

H. Peter Anvin

Acked-by on v1 1/1

2009-01-07 19:21 UTC #4 lore raw

Re: [PATCH] [TRIVIAL] linux/types.h: Don't depend on __GNUC__ for __le64 / __be64 [synced to git]

Quoted 11 lines · Detlef Riekenberg

Hi.
<linux/cdrom.h> is used in Wine, but failed to compile with pcc. (__le64 and __be64 are referenced in <linux/byteorder/little_endian.h>)
There is no reason to restrict the typedefs to __GNUC__. This Patch is trivial for gcc and icc, but required for other compiler.
As reference, the typedefs for __u64 and __s64 where fixed to be available for other compiler on 02. Mai 2008 by H. Peter Anvin (commit edfa5cfa3dc5bfa95e6aa82a2b8904e7f6c35ed7)

Quoted 6 lines

Wine: http://www.winehq.org
pcc:  http://pcc.ludd.ltu.se
This patch is again a resync to current git.
Is there anything, that I can do for this Patch?

For what it's worth...

Acked-by H. Peter Anvin <[email protected]>

This isn't an x86 thing so it's a bit out of scope for me to push it through -tip, but it's a valid bugfix.

-hpa

Sam Ravnborg

2009-01-07 19:33 UTC #5 lore raw

Re: [PATCH] [TRIVIAL] linux/types.h: Don't depend on __GNUC__ for __le64 / __be64 [synced to git]

Quoted 19 lines · H. Peter Anvin

Quoted 11 lines · Detlef Riekenberg
Hi.
<linux/cdrom.h> is used in Wine, but failed to compile with pcc. (__le64 and __be64 are referenced in <linux/byteorder/little_endian.h>)
There is no reason to restrict the typedefs to __GNUC__. This Patch is trivial for gcc and icc, but required for other compiler.
As reference, the typedefs for __u64 and __s64 where fixed to be available for other compiler on 02. Mai 2008 by H. Peter Anvin (commit edfa5cfa3dc5bfa95e6aa82a2b8904e7f6c35ed7)
Quoted 6 lines
Wine: http://www.winehq.org
pcc:  http://pcc.ludd.ltu.se
This patch is again a resync to current git.
Is there anything, that I can do for this Patch?

Quoted 6 lines

For what it's worth...
Acked-by H. Peter Anvin <[email protected]>
This isn't an x86 thing so it's a bit out of scope for me to push it through -tip, but it's a valid bugfix.

I have applied it to kbuild-fixes.git.

Thanks,
Sam