Blackfin EMAC driver updates
Subsystems (2)
cover Blackfin EMAC driver updates
Hi Jeff,
Please take a look at these 2 patches for Blackfin EMAC driver
Thanks
-Bryan
PATCH 1/2 netdev: bfin_mac: enable bfin_mac net dev driver for BF51x
From: Sonic Zhang <[email protected]>
--- drivers/net/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/Kconfig +1 -1
@@ -830,7 +830,7 @@ config ULTRA32 config BFIN_MAC tristate "Blackfin on-chip MAC support" - depends on NET_ETHERNET && (BF526 || BF527 || BF536 || BF537) + depends on NET_ETHERNET && (BF516 || BF518 || BF526 || BF527 || BF536 || BF537) select CRC32 select MII select PHYLIB
Signature · 1 line
1.5.6
Re: [PATCH 1/2] netdev: bfin_mac: enable bfin_mac net dev driver for BF51x
From: Bryan Wu <[email protected]>
Date: Thu, 8 Jan 2009 00:14:38 +0800
Quoted 2 lines
Signed-off-by Sonic Zhang <[email protected]>Signed-off-by Bryan Wu <[email protected]>
Applied.
PATCH 2/2 netdev: bfin_mac: enable VLAN support in Blackfin MAC driver
In reply to Bryan WuFrom: Graf Yang <[email protected]>
Fill EMAC_VLAN1 with 0x8100 to admit 1522 long bytes frames. EMAC_VLAN2 seems need not use for now.
--- drivers/net/bfin_mac.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)
drivers/net/bfin_mac.c +8 -0
@@ -517,6 +517,14 @@ void setup_system_regs(struct net_device *dev)bfin_write_EMAC_MMC_CTL (RSTC |CROLL ); +#if defined(CONFIG_VLAN_8021Q ) || defined(CONFIG_VLAN_8021Q_MODULE ) +#define VLAN_ETHER_TYPE 0x8100 +/* The legal length of the frame is increased to 1522 bytes */ +bfin_write_EMAC_VLAN1 (VLAN_ETHER_TYPE ); +/* The legal length of the frame is increased to 1538 bytes */ +/*bfin_write_EMAC_VLAN2(VLAN_ETHER_TYPE);*/ +#endif +/* Initialize the TX DMA channel registers */ bfin_write_DMA2_X_COUNT (0 );bfin_write_DMA2_X_MODIFY (4 );
Signature · 1 line
1.5.6
David Miller
maintainerRe: [PATCH 2/2] netdev: bfin_mac: enable VLAN support in Blackfin MAC driver
From: Bryan Wu <[email protected]>
Date: Thu, 8 Jan 2009 00:14:39 +0800
Quoted 1 line
+#define
VLAN_ETHER_TYPE0x8100
Please use ETH_P_8021Q from linux/if_ether.h instead of inventing your own definition.
drivers/net/bfin_mac.c void setup_system_regs(struct net_device *dev) · line 525
Quoted 2 lines
drivers/net/bfin_mac.c +2
-0+/* The legal length of the frame is increased to 1538 bytes */ +/*bfin_write_EMAC_VLAN2(VLAN_ETHER_TYPE);*/
Please do not add code that is just going to be commented out and not used.
Also, I disagree with the:
+#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
conditional. Probably this part of the chip should be programmed unconditionally.
We can get VLAN packets received and sent, using AF_PACKET sockets, for example. The chip should still respect those even if VLAN proper is not being utilized.
Re: [PATCH 2/2] netdev: bfin_mac: enable VLAN support in Blackfin MAC driver
Quoted 5 lines · David Miller
From: Bryan Wu <[email protected]>
Quoted 1 line
+#define
VLAN_ETHER_TYPE0x8100Please use
ETH_P_8021Qfromlinux/if_ether.hinstead of inventing your own definition.
was a copy & paste due to not finding a better definition (3c59x.c)
Quoted 6 lines
drivers/net/bfin_mac.c void setup_system_regs(struct net_device *dev) · line 525
Quoted 2 lines
drivers/net/bfin_mac.c +2
-0+/* The legal length of the frame is increased to 1538 bytes */ +/*bfin_write_EMAC_VLAN2(VLAN_ETHER_TYPE);*/ Please do not add code that is just going to be commented out and not used.
Quoted 6 lines
Also, I disagree with the:
+#if
defined(CONFIG_VLAN_8021Q)||defined(CONFIG_VLAN_8021Q_MODULE)conditional. Probably this part of the chip should be programmed unconditionally.
again, more of a copy & paste ... this is how a bunch of drivers are doing it now ...
Quoted 3 lines
We can get VLAN packets received and sent, using
AF_PACKETsockets, for example. The chip should still respect those even if VLAN proper is not being utilized.
any tips on doing that ?
thanks for reviewing!
-mike
Re: [PATCH 2/2] netdev: bfin_mac: enable VLAN support in Blackfin MAC driver
Quoted 6 lines · Mike Frysinger
Quoted 3 lines · David Miller
We can get VLAN packets received and sent, using
AF_PACKETsockets, for example. The chip should still respect those even if VLAN proper is not being utilized.any tips on doing that ?
or rather, is there a driver or you two you can point out that is doing this correctly ? the ones i looked at seemed to be doing it like the patch we posted ...
-mike
David Miller
maintainerRe: [PATCH 2/2] netdev: bfin_mac: enable VLAN support in Blackfin MAC driver
From: "Mike Frysinger" <[email protected]>
Date: Thu, 8 Jan 2009 14:05:33 -0500
Quoted 11 lines · Mike Frysinger
Quoted 6 lines · David Miller
Quoted 3 lines
We can get VLAN packets received and sent, using
AF_PACKETsockets, for example. The chip should still respect those even if VLAN proper is not being utilized.any tips on doing that ?
or rather, is there a driver or you two you can point out that is doing this correctly ? the ones i looked at seemed to be doing it like the patch we posted ...
And I disagree with how those drivers are doing it :-)
At least the programming of the chip to accept all packet types properly, VLAN or not, regardless of kernel config, is definitely IMHO the way to go.
Re: [PATCH 2/2] netdev: bfin_mac: enable VLAN support in Blackfin MAC driver
Quoted 13 lines · David Miller
From: "Mike Frysinger" <vapier
Quoted 11 lines · Mike Frysinger
Quoted 6 lines · David Miller
Quoted 3 lines
We can get VLAN packets received and sent, using
AF_PACKETsockets, for example. The chip should still respect those even if VLAN proper is not being utilized.any tips on doing that ?
or rather, is there a driver or you two you can point out that is doing this correctly ? the ones i looked at seemed to be doing it like the patch we posted ...
Quoted 5 lines
And I disagree with how those drivers are doing it :-)
At least the programming of the chip to accept all packet types properly, VLAN or not, regardless of kernel config, is definitely IMHO the way to go.
i know on our side we all agree with you, we just didnt (dont) know any better ;)
-mike
David Miller
maintainerRe: [PATCH 2/2] netdev: bfin_mac: enable VLAN support in Blackfin MAC driver
In reply to Mike FrysingerFrom: "Mike Frysinger" <[email protected]>
Date: Thu, 8 Jan 2009 14:01:49 -0500
Quoted 5 lines
Quoted 3 lines
We can get VLAN packets received and sent, using
AF_PACKETsockets, for example. The chip should still respect those even if VLAN proper is not being utilized.any tips on doing that ?
No, sorry.