Skip to contentSkip to conversation

mfd/ucb1400: don't depend on gpiolib

RFC In review Sebastian Andrzej Siewior 2 participants 4 messages Jan 8, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

RFC 1/1 mfd/ucb1400: don't depend on gpiolib

it didn't in the past and I can't see how it does.

---
I use ucb1400 with its ts capabilities without *gpiolib* on a ppc system.

 drivers/mfd/Kconfig |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/mfd/Kconfig +0 -1
index 2572773..8bcd600 100644
@@ -53,7 +53,6 @@ config HTC_PASIC3
 config UCB1400_CORE
 	tristate "Philips UCB1400 Core driver"
 	depends on AC97_BUS
-	depends on GPIOLIB
 	help
 	  This enables support for the Philips UCB1400 core functions.
 	  The UCB1400 is an AC97 audio codec.
Signature · 1 line
1.5.6.5
#1 lore raw
Quoted 14 lines · On Thursday 08 of January 2009 12:06:12 Sebastian Andrzej Siewior wrote:

it didn't in the past and I can't see how it does.

---
I use ucb1400 with its ts capabilities without *gpiolib* on a ppc system.

 drivers/mfd/Kconfig |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/mfd/Kconfig +0 -0
index 2572773..8bcd600 100644

drivers/mfd/Kconfig config HTC_PASIC3 · line 58

Quoted 7 lines
drivers/mfd/Kconfig +0 -1
@@ -53,7 +53,6 @@ config HTC_PASIC3
 config UCB1400_CORE
 	tristate "Philips UCB1400 Core driver"
 	depends on AC97_BUS
-	depends on GPIOLIB
 	help
 	  This enables support for the Philips UCB1400 core functions.
 	  The UCB1400 is an AC97 audio codec.

That dependency was added there later, I got email from Andrew Morton from 22.9.2008 23:44 adding that there, go ask him about it. CCed.

#2 lore raw
Quoted 10 lines · Marek Vasut
Quoted 9 lines · On Thursday 08 of January 2009 12:06:12 Sebastian Andrzej Siewior wrote:

it didn't in the past and I can't see how it does.

---
I use ucb1400 with its ts capabilities without *gpiolib* on a ppc system.

 drivers/mfd/Kconfig |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Quoted 14 lines

drivers/mfd/Kconfig config HTC_PASIC3 · line 58

Quoted 12 lines
drivers/mfd/Kconfig +0 -1
index 2572773..8bcd600 100644
@@ -53,7 +53,6 @@ config HTC_PASIC3
 config UCB1400_CORE
 	tristate "Philips UCB1400 Core driver"
 	depends on AC97_BUS
-	depends on GPIOLIB
 	help
 	  This enables support for the Philips UCB1400 core functions.
 	  The UCB1400 is an AC97 audio codec.

That dependency was added there later, I got email from Andrew Morton from 22.9.2008 23:44 adding that there, go ask him about it. CCed.

The header file exports functions which have gpio in its name. However I did not find any users in tree. Andrew, do you remember the reason why GPIOLIB got added as a dependency?

Sebastian

#3 lore raw
Quoted 26 lines · Sebastian Andrzej Siewior
Quoted 10 lines · Marek Vasut
Quoted 9 lines · On Thursday 08 of January 2009 12:06:12 Sebastian Andrzej Siewior wrote:

it didn't in the past and I can't see how it does.

---
I use ucb1400 with its ts capabilities without *gpiolib* on a ppc system.

 drivers/mfd/Kconfig |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Quoted 14 lines

drivers/mfd/Kconfig config HTC_PASIC3 · line 58

Quoted 12 lines
drivers/mfd/Kconfig +0 -1
index 2572773..8bcd600 100644
@@ -53,7 +53,6 @@ config HTC_PASIC3
 config UCB1400_CORE
     tristate "Philips UCB1400 Core driver"
     depends on AC97_BUS
-    depends on GPIOLIB
     help
       This enables support for the Philips UCB1400 core functions.
       The UCB1400 is an AC97 audio codec.

That dependency was added there later, I got email from Andrew Morton from 22.9.2008 23:44 adding that there, go ask him about it. CCed.

Quoted 2 lines

The header file exports functions which have gpio in its name. However I did not find any users in tree. Andrew, do you remember the reason why GPIOLIB got added as a dependency?

I've found [1]. Will look later into it.

[1] http://marc.info/?l=linux-mm-commits&m=121919139002830&w=2

Sebastian