git-latest: kernel oops in IOMMU setup
latest git from Linus. On a Thinkpad x200s with VT-d enabled (if I disable VT-d, this of course goes away).
The oops happens very early during boot in device_to_iommu (called from domain_context_mapping_one).
Looking at the code dump and the disassembled function here's where the error happens:
static struct intel_iommu *device_to_iommu(u8 bus, u8 devfn)
{
struct dmar_drhd_unit *drhd = NULL;
int i;
for_each_drhd_unit(drhd) {
if (drhd->ignored)
continue;
for (i = 0; i < drhd->devices_cnt; i++)
if (drhd->devices[i]->bus->number == bus &&
--> drhd->devices[0] is NULL
drhd->devices[i]->devfn == devfn)
return drhd->iommu;Given how early this happens it's a little hard to provide logs, etc. I literally used delay_boot=100 and wrote things down by hand (forgot my digital camera) and then added printk's to verify).
please let me know what other data I should collect.
The system ran fine with the 2.6.28 release kernel.
/D
Signature · 2 lines
Dirk Hohndel Intel Open Source Technology Center
Quoted 26 lines · Dirk Hohndel
latest git from Linus. On a Thinkpad x200s with VT-d enabled (if I disable VT-d, this of course goes away).
The oops happens very early during boot in
device_to_iommu(called fromdomain_context_mapping_one).Looking at the code dump and the disassembled function here's where the error happens:
static struct
intel_iommu*device_to_iommu(u8 bus, u8 devfn){ struct dmar_drhd_unit *drhd = NULL; int i; for_each_drhd_unit(drhd) { if (drhd->ignored) continue; for (i = 0; i < drhd->devices_cnt; i++) if (drhd->devices[i]->bus->number == bus && --> drhd->devices[0] is NULL drhd->devices[i]->devfn == devfn) return drhd->iommu;
Quoted 5 lines
Given how early this happens it's a little hard to provide logs, etc. I literally used delay_boot=100 and wrote things down by hand (forgot my digital camera) and then added printk's to verify).
please let me know what other data I should collect.
If you can, a back trace. Basically just need to know which caller
is tripping over this. But there can't be that many callers and they
are all in this file:
0 intel-iommu.c device_to_iommu 431 static struct intel_iommu *device_to_iommu(u8 bus, u8 devfn)
1 intel-iommu.c domain_context_mapping_on 1471 iommu = device_to_iommu(bus, devfn);
2 intel-iommu.c domain_context_mapped 1593 iommu = device_to_iommu(pdev->bus->number, pdev->devfn);
3 intel-iommu.c domain_remove_dev_info 1684 iommu = device_to_iommu(info->bus, info->devfn);
4 intel-iommu.c vm_domain_remove_one_dev_ 2773 iommu = device_to_iommu(pdev->bus->number, pdev->devfn); 5 intel-iommu.c vm_domain_remove_one_dev_ 2803 if (device_to_iommu(info->bus, info->devfn) == iommu) 6 intel-iommu.c vm_domain_remove_all_dev_ 2836 iommu = device_to_iommu(info->bus, info->devfn); 7 intel-iommu.c intel_iommu_attach_device 3023 iommu = device_to_iommu(pdev->bus->number, pdev->devfn);
so it should be possible to figure out which one is called before the dev is setup. It's unlikely to be anything with "remove" in the name. :)
My guess is it's intel_iommu_attach_device being called "too early".
hth,
grant
hth,
grant
Quoted 12 lines
The system ran fine with the 2.6.28 release kernel.
/D
Signature · 6 lines
Dirk Hohndel Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 7 lines · On Thu, 8 Jan 2009 14:41:16 -0700 Grant Grundler <[email protected]>…
Quoted 6 lines · Dirk Hohndel
latest git from Linus. On a Thinkpad x200s with VT-d enabled (if I disable VT-d, this of course goes away).
The oops happens very early during boot in
device_to_iommu(called fromdomain_context_mapping_one).
Look here, that's where it's called from. Do you want me to note down the complete backtrace?
Quoted 7 lines
If you can, a back trace. Basically just need to know which caller is tripping over this. But there can't be that many callers and they are all in this file:
...
so it should be possible to figure out which one is called before the dev is setup. It's unlikely to be anything with "remove" in the name. :)
correct - it's context_mapping_one
Signature · 2 lines
Dirk Hohndel Intel Open Source Technology Center
Quoted 49 lines · Grant Grundler
Quoted 22 lines · Dirk Hohndel
latest git from Linus. On a Thinkpad x200s with VT-d enabled (if I disable VT-d, this of course goes away).
The oops happens very early during boot in
device_to_iommu(called fromdomain_context_mapping_one).Looking at the code dump and the disassembled function here's where the error happens:
static struct intel_iommu *device_to_iommu(u8 bus, u8 devfn) { struct dmar_drhd_unit *drhd = NULL; int i; for_each_drhd_unit(drhd) { if (drhd->ignored) continue; for (i = 0; i < drhd->devices_cnt; i++) if (drhd->devices[i]->bus->number == bus && --> drhd->devices[0] is NULL drhd->devices[i]->devfn == devfn)Quoted 8 lines
return
drhd->iommu;Given how early this happens it's a little hard to provide logs, etc. I literally used delay_boot=100 and wrote things down by hand (forgot my digital camera) and then added printk's to verify).
please let me know what other data I should collect.
If you can, a back trace. Basically just need to know which caller is tripping over this. But there can't be that many callers and they are all in this file:
0intel-iommu.cdevice_to_iommu431 static structintel_iommu*device_to_iommu(u8 bus, u8 devfn) 1intel-iommu.cdomain_context_mapping_on1471 iommu =device_to_iommu(bus, devfn); 2intel-iommu.cdomain_context_mapped1593 iommu =device_to_iommu(pdev->bus->number, pdev->devfn); 3intel-iommu.cdomain_remove_dev_info1684 iommu = device_to_iommu(info->bus,info->devfn); 4intel-iommu.cvm_domain_remove_one_dev_2773 iommu =device_to_iommu(pdev->bus->number, pdev->devfn); 5intel-iommu.cvm_domain_remove_one_dev_2803 if (device_to_iommu(info->bus, info->devfn)== iommu) 6intel-iommu.cvm_domain_remove_all_dev_2836 iommu =device_to_iommu(info->bus, info->devfn); 7intel-iommu.cintel_iommu_attach_device3023 iommu =device_to_iommu(pdev->bus->number, pdev->devfn);
Quoted 5 lines
so it should be possible to figure out which one is called before the dev is setup. It's unlikely to be anything with "remove" in the name. :)
My guess is it's
intel_iommu_attach_devicebeing called "too early".
yes, pls get the call trace. When device_to_iommu() is called, DMAR should be already parsed from acpi table and registered, so device_to_iommu() should not fail unless it's called earlier than DMAR is parsed and registered.
Regards,
Weidong
Quoted 24 lines
hth,
granthth,
grantQuoted 5 lines
The system ran fine with the 2.6.28 release kernel.
/D
Quoted 7 lines
--
Dirk Hohndel
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html_______________________________________________
iommu mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/iommu
Quoted 26 lines · Weidong
Quoted 26 lines
Quoted 26 lines
The oops happens very early during boot in
device_to_iommu(called fromdomain_context_mapping_one).Looking at the code dump and the disassembled function here's where the error happens:
static struct intel_iommu *device_to_iommu(u8 bus, u8 devfn) { struct dmar_drhd_unit *drhd = NULL; int i; for_each_drhd_unit(drhd) { if (drhd->ignored) continue; for (i = 0; i < drhd->devices_cnt; i++) if (drhd->devices[i]->bus->number == bus && --> drhd->devices[0] is NULL drhd->devices[i]->devfn == devfn)return
drhd->iommu;Given how early this happens it's a little hard to provide logs, etc. I literally used delay_boot=100 and wrote things down by hand (forgot my digital camera) and then added printk's to verify).
Quoted 6 lines
Quoted 2 lines
Quoted 1 line
please let me know what other data I should collect.
yes, pls get the call trace. When
device_to_iommu()is called, DMAR should be already parsed from acpi table and registered, sodevice_to_iommu()should not fail unless it's called earlier than DMAR is parsed and registered.
I updated to Linus' latest git (as your description made me wonder if the async stuff might play a role here). I still get an oops - but at a different spot and the system no longer hangs - it partly recovers (but things aren't too well - for example my USB keyboard / mouse don't work anymore).
Here's the oops:
Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 12.359578] ------------[ cut here ]------------ Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 12.410579] WARNING: at arch/x86/mm/ioremap.c:240 __ioremap_caller+0x150/0x2bd() Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 12.461578] Hardware name: 7465CTO Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 12.512578] Modules linked in: Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 12.614579] Pid: 1, comm: swapper Not tainted 2.6.28 #12 Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 12.665578] Call Trace: Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 12.767581] [<ffffffff81038b49>] warn_slowpath+0xb1/0xed Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 12.869580] [<ffffffff81028319>] ? change_page_attr_set_clr+0x13e/0x2e6 Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 12.971580] [<ffffffff810275b2>] __ioremap_caller+0x150/0x2bd Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 13.073581] [<ffffffff81158363>] ? alloc_iommu+0x140/0x181 Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 13.175580] [<ffffffff810277f2>] ioremap_nocache+0x12/0x14 Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 13.277580] [<ffffffff81158363>] alloc_iommu+0x140/0x181 Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 13.379581] [<ffffffff8166a5d6>] dmar_table_init+0x115/0x265 Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 13.481580] [<ffffffff8165687b>] ? pci_iommu_init+0x0/0x17 Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 13.583580] [<ffffffff8166abb1>] intel_iommu_init+0x16/0x8f3 Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 13.685581] [<ffffffff813ce372>] ? mutex_lock+0x11/0x23 Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 13.787581] [<ffffffff813bb9d1>] ? sysctl_net_init+0x1b/0x1f Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 13.889580] [<ffffffff8165687b>] ? pci_iommu_init+0x0/0x17 Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 13.991580] [<ffffffff81656884>] pci_iommu_init+0x9/0x17 Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 14.093581] [<ffffffff81009056>] _stext+0x56/0x12b Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 14.195581] [<ffffffff81071220>] ? register_irq_proc+0xa3/0xbf Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 14.297582] [<ffffffff810e0000>] ? proc_coredump_filter_write+0xe0/0xfe Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 14.399581] [<ffffffff8164e673>] kernel_init+0x139/0x191 Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 14.501581] [<ffffffff8100d27a>] child_rip+0xa/0x20 Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 14.603581] [<ffffffff8164e53a>] ? kernel_init+0x0/0x191 Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 14.705581] [<ffffffff8100d270>] ? child_rip+0x0/0x20 Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 14.756580] ---[ end trace 4eaa2a86a8e2da22 ]--- Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 14.807580] IOMMU: can't map the region Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 14.858580] DMAR:parse DMAR table failure.
later in the log file I find lots of these:
Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 40.403251] nommu_map_single: overflow 13a08b248+8 of device mask ffffffff
and finally
Jan 8 17:51:00 dhohndel-mobl4 kernel: [ 66.777166] hub 4-0:1.0: unable to enumerate USB device on port 2
/D
Signature · 2 lines
Dirk Hohndel Intel Open Source Technology Center
Quoted 7 lines · On Thu, 8 Jan 2009 18:05:15 -0800 Dirk Hohndel <[email protected]> wrote:
On Fri, 9 Jan 2009 08:58:46 +0800 "Han, Weidong"
I updated to Linus' latest git (as your description made me wonder if the async stuff might play a role here). I still get an oops - but at a different spot and the system no longer hangs - it partly recovers (but things aren't too well - for example my USB keyboard / mouse don't work anymore).
Spoke too soon. Rebooted and had the same hard lockup again. This time I had my camera within reach, so here's the trace:
device_to_iommu+0x33/0x73 domain_context_mapping_one+0x37/0x335 domain_context_mapping+0x25/0xa7 iommu_prepare_identity+0xd7/0xf3 intel_iommu_init+0x4e4/0x8f3
? mutex_lock
? sysctl_net_init
? pci_iommu_initpci_iommu_init
I also have stack, code and register values. Let me know if you need them. Or I can just post the picture :-)
Again, very latest git tree, VT-d enabled.
/D
Signature · 2 lines
Dirk Hohndel Intel Open Source Technology Center
Quoted 24 lines · Dirk Hohndel
Quoted 7 lines · On Thu, 8 Jan 2009 18:05:15 -0800 Dirk Hohndel <[email protected]> wrote:
On Fri, 9 Jan 2009 08:58:46 +0800 "Han, Weidong"
I updated to Linus' latest git (as your description made me wonder if the async stuff might play a role here). I still get an oops - but at a different spot and the system no longer hangs - it partly recovers (but things aren't too well - for example my USB keyboard / mouse don't work anymore).
Spoke too soon. Rebooted and had the same hard lockup again. This time I had my camera within reach, so here's the trace:
device_to_iommu+0x33/0x73 domain_context_mapping_one+0x37/0x335 domain_context_mapping+0x25/0xa7 iommu_prepare_identity+0xd7/0xf3 intel_iommu_init+0x4e4/0x8f3?
mutex_lock
?sysctl_net_init
?pci_iommu_initpci_iommu_init
Quoted 6 lines
I also have stack, code and register values. Let me know if you need them. Or I can just post the picture :-)
Again, very latest git tree, VT-d enabled.
/D
I tried latest git tree, it works for me. Above call trace looks right.
Regards,
Weidong
Quoted 28 lines · Weidong
Quoted 27 lines · Dirk Hohndel
Quoted 7 lines · On Thu, 8 Jan 2009 18:05:15 -0800 Dirk Hohndel <[email protected]> wrote:
On Fri, 9 Jan 2009 08:58:46 +0800 "Han, Weidong"
I updated to Linus' latest git (as your description made me wonder if the async stuff might play a role here). I still get an oops - but at a different spot and the system no longer hangs - it partly recovers (but things aren't too well - for example my USB keyboard / mouse don't work anymore).
Spoke too soon. Rebooted and had the same hard lockup again. This time I had my camera within reach, so here's the trace:
device_to_iommu+0x33/0x73 domain_context_mapping_one+0x37/0x335 domain_context_mapping+0x25/0xa7 iommu_prepare_identity+0xd7/0xf3 intel_iommu_init+0x4e4/0x8f3?
mutex_lock
?sysctl_net_init
?pci_iommu_initpci_iommu_initI also have stack, code and register values. Let me know if you need them. Or I can just post the picture :-)
Quoted 6 lines
Quoted 3 lines
Again, very latest git tree, VT-d enabled.
/D
I tried latest git tree, it works for me. Above call trace looks right.
Spent some more time reading the code. Can't quite claim to understand all of it, yet, but I notice that most everywhere else drhd->devices[i] is checked to be != NULL before it is accessed. Why is it safe not to do that in device_to_iommu()?
Would the patch below be a valid fix? It stops my system from hanging at boot. But I wonder if there is an assertion that if drhd->ignored is 0 then drhd->devices[0..drhd->device_cnt] is known to be != NULL and therefore this test is just hiding a bug somewhere else...
/D
--- drivers/pci/intel-iommu.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/pci/intel-iommu.c +0 -0
@@ -438,7 +438,8 @@ static struct intel_iommu *device_to_iommu(u8 bus,
u8 devfn) continue;
for (i = 0; i < drhd->devices_cnt; i++)
- if (drhd->devices[i]->bus->number == bus &&
+ if (drhd->devices[i] &&
+ drhd->devices[i]->bus->number == bus &&
drhd->devices[i]->devfn == devfn)
return drhd->iommu;
Signature · 6 lines
1.6.0.6 -- Dirk Hohndel Intel Open Source Technology Center
Zhao, Yu
Acked-byQuoted 58 lines · Dirk Hohndel
Quoted 24 lines · Weidong
Quoted 23 lines · Dirk Hohndel
Quoted 7 lines · On Thu, 8 Jan 2009 18:05:15 -0800 Dirk Hohndel <[email protected]> wrote:
On Fri, 9 Jan 2009 08:58:46 +0800 "Han, Weidong"
I updated to Linus' latest git (as your description made me wonder if the async stuff might play a role here). I still get an oops - but at a different spot and the system no longer hangs - it partly recovers (but things aren't too well - for example my USB keyboard / mouse don't work anymore).
Spoke too soon. Rebooted and had the same hard lockup again. This time I had my camera within reach, so here's the trace:
device_to_iommu+0x33/0x73 domain_context_mapping_one+0x37/0x335 domain_context_mapping+0x25/0xa7 iommu_prepare_identity+0xd7/0xf3 intel_iommu_init+0x4e4/0x8f3?
mutex_lock
?sysctl_net_init
?pci_iommu_initpci_iommu_initQuoted 8 lines
Quoted 6 lines
I also have stack, code and register values. Let me know if you need them. Or I can just post the picture :-)
Again, very latest git tree, VT-d enabled.
/D
I tried latest git tree, it works for me. Above call trace looks right.
Spent some more time reading the code. Can't quite claim to understand all of it, yet, but I notice that most everywhere else drhd->devices[i] is checked to be != NULL before it is accessed. Why is it safe not to do that in
device_to_iommu()?Would the patch below be a valid fix? It stops my system from hanging at boot. But I wonder if there is an assertion that if
drhd->ignoredis 0 then drhd->devices[0..drhd->device_cnt] is known to be != NULL and therefore this test is just hiding a bug somewhere else.../D
Signed-off-by Dirk Hohndel <[email protected]>--- drivers/pci/intel-iommu.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)drivers/pci/intel-iommu.c +0
-0
drivers/pci/intel-iommu.c static struct intel_iommu *device_to_iommu(u8 bus, · line 445
Quoted 9 lines
drivers/pci/intel-iommu.c +2
-1@@ -438,7 +438,8 @@ static struct intel_iommu *device_to_iommu(u8 bus, u8 devfn) continue;for (i =0 ; i < drhd->devices_cnt; i++) -if (drhd->devices[i]->bus->number == bus && +if (drhd->devices[i] && + drhd->devices[i]->bus->number == bus && drhd->devices[i]->devfn == devfn)return drhd->iommu;
Did you see following in the kernel message?
printk(KERN_WARNING PREFIX
"Device scope device [%04x:%02x:%02x.%02x] not found\n",
segment, scope->bus, path->dev, path->fn);If yes, then
Quoted 71 lines · Yu
Quoted 59 lines · Dirk Hohndel
Quoted 24 lines · Weidong
Quoted 23 lines · Dirk Hohndel
Quoted 7 lines · On Thu, 8 Jan 2009 18:05:15 -0800 Dirk Hohndel <[email protected]> wrote:
On Fri, 9 Jan 2009 08:58:46 +0800 "Han, Weidong"
I updated to Linus' latest git (as your description made me wonder if the async stuff might play a role here). I still get an oops - but at a different spot and the system no longer hangs
- it partly recovers (but things aren't too well - for example my USB keyboard / mouse don't work anymore).Spoke too soon. Rebooted and had the same hard lockup again. This time I had my camera within reach, so here's the trace:
device_to_iommu+0x33/0x73 domain_context_mapping_one+0x37/0x335 domain_context_mapping+0x25/0xa7 iommu_prepare_identity+0xd7/0xf3 intel_iommu_init+0x4e4/0x8f3?
mutex_lock
?sysctl_net_init
?pci_iommu_initpci_iommu_initQuoted 8 lines
Quoted 6 lines
I also have stack, code and register values. Let me know if you need them. Or I can just post the picture :-)
Again, very latest git tree, VT-d enabled.
/D
I tried latest git tree, it works for me. Above call trace looks right.
Spent some more time reading the code. Can't quite claim to understand all of it, yet, but I notice that most everywhere else drhd->devices[i] is checked to be != NULL before it is accessed. Why is it safe not to do that in
device_to_iommu()?Would the patch below be a valid fix? It stops my system from hanging at boot. But I wonder if there is an assertion that if
drhd->ignoredis 0 then drhd->devices[0..drhd->device_cnt] is known to be != NULL and therefore this test is just hiding a bug somewhere else.../D
Signed-off-by Dirk Hohndel <[email protected]>--- drivers/pci/intel-iommu.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)drivers/pci/intel-iommu.c +0
-0drivers/pci/intel-iommu.c static struct intel_iommu *device_to_iommu(u8 · line 445
Quoted 9 lines
drivers/pci/intel-iommu.c +2
-1@@ -438,7 +438,8 @@ static struct intel_iommu *device_to_iommu(u8 bus, u8 devfn) continue;for (i =0 ; i < drhd->devices_cnt; i++) -if (drhd->devices[i]->bus->number == bus && +if (drhd->devices[i] && + drhd->devices[i]->bus->number == bus && drhd->devices[i]->devfn == devfn)return drhd->iommu;Did you see following in the kernel message?
Quoted 6 lines
printk(KERN_WARNING PREFIX "Device scope device [%04x:%02x:%02x.%02x] notfound\n", segment,
scope->bus,path->dev,path->fn);If yes, then
Acked-by Yu Zhao <[email protected]>
Yes,
DMAR: Device scope device [0000:00:03:02] not found
DMAR: Device scope device [0000:00:03:02] not found
DMAR: Device scope device [0000:00:03:03] not found
DMAR: Device scope device [0000:00:03:03] not found
/D
Signature · 2 lines
Dirk Hohndel Intel Open Source Technology Center
Quoted 79 lines · Dirk Hohndel
Quoted 69 lines · Yu
Quoted 58 lines · Dirk Hohndel
Quoted 24 lines · Weidong
Quoted 23 lines · Dirk Hohndel
Quoted 7 lines · On Thu, 8 Jan 2009 18:05:15 -0800 Dirk Hohndel <[email protected]> wrote:
On Fri, 9 Jan 2009 08:58:46 +0800 "Han, Weidong"
I updated to Linus' latest git (as your description made me wonder if the async stuff might play a role here). I still get an oops - but at a different spot and the system no longer hangs
- it partly recovers (but things aren't too well - for example my USB keyboard / mouse don't work anymore).Spoke too soon. Rebooted and had the same hard lockup again. This time I had my camera within reach, so here's the trace:
device_to_iommu+0x33/0x73 domain_context_mapping_one+0x37/0x335 domain_context_mapping+0x25/0xa7 iommu_prepare_identity+0xd7/0xf3 intel_iommu_init+0x4e4/0x8f3?
mutex_lock
?sysctl_net_init
?pci_iommu_initpci_iommu_initQuoted 8 lines
Quoted 6 lines
I also have stack, code and register values. Let me know if you need them. Or I can just post the picture :-)
Again, very latest git tree, VT-d enabled.
/D
I tried latest git tree, it works for me. Above call trace looks right.
Spent some more time reading the code. Can't quite claim to understand all of it, yet, but I notice that most everywhere else drhd->devices[i] is checked to be != NULL before it is accessed. Why is it safe not to do that in
device_to_iommu()?Would the patch below be a valid fix? It stops my system from hanging at boot. But I wonder if there is an assertion that if
drhd->ignoredis 0 then drhd->devices[0..drhd->device_cnt] is known to be != NULL and therefore this test is just hiding a bug somewhere else.../D
Signed-off-by Dirk Hohndel <[email protected]>--- drivers/pci/intel-iommu.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)drivers/pci/intel-iommu.c +0
-0drivers/pci/intel-iommu.c static struct intel_iommu *device_to_iommu(u8 · line 445
Quoted 9 lines
drivers/pci/intel-iommu.c +2
-1@@ -438,7 +438,8 @@ static struct intel_iommu *device_to_iommu(u8 bus, u8 devfn) continue;for (i =0 ; i < drhd->devices_cnt; i++) -if (drhd->devices[i]->bus->number == bus && +if (drhd->devices[i] && + drhd->devices[i]->bus->number == bus && drhd->devices[i]->devfn == devfn)return drhd->iommu;Did you see following in the kernel message?
Quoted 6 lines
printk(KERN_WARNING PREFIX "Device scope device [%04x:%02x:%02x.%02x] notfound\n", segment,
scope->bus,path->dev,path->fn);If yes, then
Acked-by Yu Zhao <[email protected]>
Quoted 6 lines
Yes,
DMAR: Device scope device [0000:00:03:02] not found
DMAR: Device scope device [0000:00:03:02] not found
DMAR: Device scope device [0000:00:03:03] not found
DMAR: Device scope device [0000:00:03:03] not found
The laptop has a nasty bios, try to update it if you want to get rid of these noises... assuming you are luck enough :-)
Quoted 9 lines · Yu
Quoted 6 lines
Yes,
DMAR: Device scope device [0000:00:03:02] not found
DMAR: Device scope device [0000:00:03:02] not found
DMAR: Device scope device [0000:00:03:03] not found
DMAR: Device scope device [0000:00:03:03] not foundThe laptop has a nasty bios, try to update it if you want to get rid of these noises... assuming you are luck enough :-)
It's a Lenovo Thinkpad X200s - and I am running the latest BIOS (at least according to their support website) :-(
kernel: thinkpad_acpi: ThinkPad ACPI Extras v0.21
kernel: thinkpad_acpi: http://ibm-acpi.sf.net/
kernel: thinkpad_acpi: ThinkPad BIOS 6DET33WW (1.10 ), EC 7XHT21WW-1.03
kernel: thinkpad_acpi: Lenovo ThinkPad X200s, model 7465CTO
/D
Signature · 2 lines
Dirk Hohndel Intel Open Source Technology Center
PATCH 1/1 Prevent oops at boot with VT-d
In reply to Zhao, YuResending with appropriate Subject
--- drivers/pci/intel-iommu.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/pci/intel-iommu.c +0 -0
@@ -438,7 +438,8 @@ static struct intel_iommu *device_to_iommu(u8 bus,
u8 devfn) continue;
for (i = 0; i < drhd->devices_cnt; i++)
- if (drhd->devices[i]->bus->number == bus &&
+ if (drhd->devices[i] &&
+ drhd->devices[i]->bus->number == bus &&
drhd->devices[i]->devfn == devfn)
return drhd->iommu;
Signature · 1 line
1.6.0.6
PATCH RESEND 1/1 Prevent oops at boot with VT-d
This wasn't included in 2.6.29-rc1
With some broken BIOSs when VT-d is enabled, the data structures are filled incorrectly. This can cause a NULL pointer dereference in very early boot.
--- drivers/pci/intel-iommu.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/pci/intel-iommu.c +2 -1
@@ -438,7 +438,8 @@ static struct intel_iommu *device_to_iommu(u8 bus, u8 devfn)continue ;for (i =0 ; i < drhd->devices_cnt; i++) -if (drhd->devices[i]->bus->number == bus && +if (drhd->devices[i] && + drhd->devices[i]->bus->number == bus && drhd->devices[i]->devfn == devfn)return drhd->iommu;
Signature · 4 lines
1.6.0.6 -- Dirk Hohndel Intel Open Source Technology Center